You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jojy Varghese <jo...@mesosphere.io> on 2015/11/23 21:18:35 UTC
Review Request 40610: Changed getBlob invocation to use defer
mechanism.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40610/
-----------------------------------------------------------
Review request for mesos, Michael Park and Timothy Chen.
Repository: mesos
Description
-------
Fixed possible dangling pointer in getBlob continuation.
Diffs
-----
src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp f488640d631cf06b71c614dc1828c71dc43be9aa
Diff: https://reviews.apache.org/r/40610/diff/
Testing
-------
make check.
Thanks,
Jojy Varghese
Re: Review Request 40610: Changed getBlob invocation to use defer
mechanism.
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40610/#review107639
-----------------------------------------------------------
Ship it!
Ship It!
- Timothy Chen
On Nov. 23, 2015, 8:18 p.m., Jojy Varghese wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40610/
> -----------------------------------------------------------
>
> (Updated Nov. 23, 2015, 8:18 p.m.)
>
>
> Review request for mesos, Michael Park and Timothy Chen.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed possible dangling pointer in getBlob continuation.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp f488640d631cf06b71c614dc1828c71dc43be9aa
>
> Diff: https://reviews.apache.org/r/40610/diff/
>
>
> Testing
> -------
>
> make check.
>
>
> Thanks,
>
> Jojy Varghese
>
>
Re: Review Request 40610: Changed getBlob invocation to use defer
mechanism.
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40610/#review107638
-----------------------------------------------------------
src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp (line 754)
<https://reviews.apache.org/r/40610/#comment166866>
Agrh, missed this during the review :(
- Timothy Chen
On Nov. 23, 2015, 8:18 p.m., Jojy Varghese wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40610/
> -----------------------------------------------------------
>
> (Updated Nov. 23, 2015, 8:18 p.m.)
>
>
> Review request for mesos, Michael Park and Timothy Chen.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed possible dangling pointer in getBlob continuation.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp f488640d631cf06b71c614dc1828c71dc43be9aa
>
> Diff: https://reviews.apache.org/r/40610/diff/
>
>
> Testing
> -------
>
> make check.
>
>
> Thanks,
>
> Jojy Varghese
>
>