You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Stefan Küng <to...@gmail.com> on 2006/02/14 17:06:35 UTC

svn ls -v not showing locks with some URLs

Hi,

I guess this says all:

$ svnadmin create repo
$ svn co file:///d:/test/repo wc
$ cd wc
$ svn mkdir "test folder"
$ echo test > "test folder\testfile"
$ svn add "test folder\testfile"
$ svn ci -m ""
$ svn lock "test folder\testfile"
$ svn ls -v -R file:///d:/test/repo
1 kueng            Feb 14 18:03 test folder/
1 kueng   O      7 Feb 14 18:03 test folder/testfile

But:
$ svn ls -v -R file:///d:/test/repo/test%20folder
1 kueng          7 Feb 14 18:03 testfile

The lock information is lost!

This is with
$ svn --version
svn, Version 1.3.0 (r17949)

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.tigris.org

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: svn ls -v not showing locks with some URLs

Posted by Peter Lundblad <pe...@famlundblad.se>.
Stefan Küng writes:
 > I guess this says all:
 > 
 > $ svnadmin create repo
 > $ svn co file:///d:/test/repo wc
 > $ cd wc
 > $ svn mkdir "test folder"
 > $ echo test > "test folder\testfile"
 > $ svn add "test folder\testfile"
 > $ svn ci -m ""
 > $ svn lock "test folder\testfile"
 > $ svn ls -v -R file:///d:/test/repo
 > 1 kueng            Feb 14 18:03 test folder/
 > 1 kueng   O      7 Feb 14 18:03 test folder/testfile
 > 
 > But:
 > $ svn ls -v -R file:///d:/test/repo/test%20folder
 > 1 kueng          7 Feb 14 18:03 testfile
 > 
 > The lock information is lost!
 > 

This is now fixed in r18668 on a backport branch and proposed for backport for 1.3.1.

Thanks,
//Peter

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org


Re: svn ls -v not showing locks with some URLs

Posted by "Peter N. Lundblad" <pe...@famlundblad.se>.
On Wed, 15 Feb 2006, Ben Collins-Sussman wrote:

> On 2/15/06, Peter N. Lundblad <pe...@famlundblad.se> wrote:
>
> > This works correctly on trunk, since I rewrote the list function.  It is a
> > simple URI-decoding omission.
> >
>
> Is the fix 1.3.1 backportable?

Not asis, since the code was reworked, but it should a one-liner plus a
test.  I may look at it before 1.3.1 if no one beats me to it.  Anyone
needs a bite-sized?...

//Peter

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: svn ls -v not showing locks with some URLs

Posted by Ben Collins-Sussman <su...@red-bean.com>.
On 2/15/06, Peter N. Lundblad <pe...@famlundblad.se> wrote:

> This works correctly on trunk, since I rewrote the list function.  It is a
> simple URI-decoding omission.
>

Is the fix 1.3.1 backportable?

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org


Re: svn ls -v not showing locks with some URLs

Posted by "Peter N. Lundblad" <pe...@famlundblad.se>.
On Tue, 14 Feb 2006, Stefan Küng wrote:

> I guess this says all:
>
> $ svnadmin create repo
> $ svn co file:///d:/test/repo wc
> $ cd wc
> $ svn mkdir "test folder"
> $ echo test > "test folder\testfile"
> $ svn add "test folder\testfile"
> $ svn ci -m ""
> $ svn lock "test folder\testfile"
> $ svn ls -v -R file:///d:/test/repo
> 1 kueng            Feb 14 18:03 test folder/
> 1 kueng   O      7 Feb 14 18:03 test folder/testfile
>
> But:
> $ svn ls -v -R file:///d:/test/repo/test%20folder
> 1 kueng          7 Feb 14 18:03 testfile
>
> The lock information is lost!
>
This works correctly on trunk, since I rewrote the list function.  It is a
simple URI-decoding omission.

(If this was some other language than C, I would seriously consider
introduce different types for local paths, URLs and FS paths instead of
using simple strings so the compilers typechecking could help.  We've had
too many encoding bugs during the years:-(

Thanks,
//Peter

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org