You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/04/01 15:03:41 UTC
[GitHub] [flink] tillrohrmann opened a new pull request #11604:
[BP-1.10][FLINK-14316] Properly manage rpcConnection in
JobManagerLeaderListener under leader change
tillrohrmann opened a new pull request #11604: [BP-1.10][FLINK-14316] Properly manage rpcConnection in JobManagerLeaderListener under leader change
URL: https://github.com/apache/flink/pull/11604
This PR is a backport of #11603, #11552 and #11313 onto `release-1.10`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] tillrohrmann closed pull request #11604:
[BP-1.10][FLINK-14316] Properly manage rpcConnection in
JobManagerLeaderListener under leader change
Posted by GitBox <gi...@apache.org>.
tillrohrmann closed pull request #11604: [BP-1.10][FLINK-14316] Properly manage rpcConnection in JobManagerLeaderListener under leader change
URL: https://github.com/apache/flink/pull/11604
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #11604: [BP-1.10][FLINK-14316]
Properly manage rpcConnection in JobManagerLeaderListener under leader change
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11604: [BP-1.10][FLINK-14316] Properly manage rpcConnection in JobManagerLeaderListener under leader change
URL: https://github.com/apache/flink/pull/11604#issuecomment-607305637
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 7abc228aa6b5c08da2d890fea4576cd2ed371a3a (Wed Apr 01 15:08:09 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11604:
[BP-1.10][FLINK-14316] Properly manage rpcConnection in
JobManagerLeaderListener under leader change
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11604: [BP-1.10][FLINK-14316] Properly manage rpcConnection in JobManagerLeaderListener under leader change
URL: https://github.com/apache/flink/pull/11604#issuecomment-607318784
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7abc228aa6b5c08da2d890fea4576cd2ed371a3a",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/157560581",
"triggerID" : "7abc228aa6b5c08da2d890fea4576cd2ed371a3a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7abc228aa6b5c08da2d890fea4576cd2ed371a3a Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/157560581)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] tillrohrmann commented on issue #11604:
[BP-1.10][FLINK-14316] Properly manage rpcConnection in
JobManagerLeaderListener under leader change
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on issue #11604: [BP-1.10][FLINK-14316] Properly manage rpcConnection in JobManagerLeaderListener under leader change
URL: https://github.com/apache/flink/pull/11604#issuecomment-607716428
Merge manually
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #11604: [BP-1.10][FLINK-14316]
Properly manage rpcConnection in JobManagerLeaderListener under leader change
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11604: [BP-1.10][FLINK-14316] Properly manage rpcConnection in JobManagerLeaderListener under leader change
URL: https://github.com/apache/flink/pull/11604#issuecomment-607318784
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7abc228aa6b5c08da2d890fea4576cd2ed371a3a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "7abc228aa6b5c08da2d890fea4576cd2ed371a3a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7abc228aa6b5c08da2d890fea4576cd2ed371a3a UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11604:
[BP-1.10][FLINK-14316] Properly manage rpcConnection in
JobManagerLeaderListener under leader change
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11604: [BP-1.10][FLINK-14316] Properly manage rpcConnection in JobManagerLeaderListener under leader change
URL: https://github.com/apache/flink/pull/11604#issuecomment-607318784
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7abc228aa6b5c08da2d890fea4576cd2ed371a3a",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/157560581",
"triggerID" : "7abc228aa6b5c08da2d890fea4576cd2ed371a3a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7abc228aa6b5c08da2d890fea4576cd2ed371a3a Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/157560581)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11604:
[BP-1.10][FLINK-14316] Properly manage rpcConnection in
JobManagerLeaderListener under leader change
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11604: [BP-1.10][FLINK-14316] Properly manage rpcConnection in JobManagerLeaderListener under leader change
URL: https://github.com/apache/flink/pull/11604#issuecomment-607305637
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 7abc228aa6b5c08da2d890fea4576cd2ed371a3a (Wed Apr 15 11:39:28 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] tillrohrmann commented on issue #11604:
[BP-1.10][FLINK-14316] Properly manage rpcConnection in
JobManagerLeaderListener under leader change
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on issue #11604: [BP-1.10][FLINK-14316] Properly manage rpcConnection in JobManagerLeaderListener under leader change
URL: https://github.com/apache/flink/pull/11604#issuecomment-607715597
Merging this PR since the original PR has been approved.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services