You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "Cao Manh Dat (Jira)" <ji...@apache.org> on 2019/10/02 08:48:00 UTC

[jira] [Created] (SOLR-13810) RequestStatus on completed task should have almost identical response like sync call

Cao Manh Dat created SOLR-13810:
-----------------------------------

             Summary: RequestStatus on completed task should have almost identical response like sync call
                 Key: SOLR-13810
                 URL: https://issues.apache.org/jira/browse/SOLR-13810
             Project: Solr
          Issue Type: Improvement
      Security Level: Public (Default Security Level. Issues are Public)
            Reporter: Cao Manh Dat
            Assignee: Cao Manh Dat


Right now, the response for REQUEST_STATUS for completed tasks are horrible. 
With the remove of {{INCLUDE_TOP_LEVEL_RESPONSE}} in {{OverseerCollectionMessageHandler}} the response will get cleaner. 
But it does not contains useful information like the normal sync call. To solve this problem, I propose the response should contains the same amount of infor like sync call, like this

sync call for create collection
{code:json}
{
  "responseHeader":{
    "status":0,
    "QTime":5787},
  "success":{
    "127.0.0.1:63714_solr":{
      "responseHeader":{
        "status":0,
        "QTime":4447},
      "core":"solrj_test_shard2_replica_n3"},
    "127.0.0.1:63713_solr":{
      "responseHeader":{
        "status":0,
        "QTime":4447},
      "core":"solrj_test_shard1_replica_n2"},
    "127.0.0.1:63711_solr":{
      "responseHeader":{
        "status":0,
        "QTime":5290},
      "core":"solrj_test_shard1_replica_n1"},
    "127.0.0.1:63712_solr":{
      "responseHeader":{
        "status":0,
        "QTime":5295},
      "core":"solrj_test_shard2_replica_n4"}}}
{code}

REQUEST_STATUS for create collection (async) with {{INCLUDE_TOP_LEVEL_RESPONSE == false}} (default in Solr 9)
{code}
{
  "responseHeader":{},
  "success":{
    "127.0.0.1:53789_solr":{
      "responseHeader":{
        "status":0,
        "QTime":0},
      "STATUS":"completed",
      "core":"solrj_test_shard2_replica_n3",
      "Response":"TaskId: 09a0cc34-ea20-4430-b602-...."},
    "127.0.0.1:53788_solr":{
      "responseHeader":{
        "status":0,
        "QTime":0},
      "STATUS":"completed",
      "core":"solrj_test_shard1_replica_n2",
      "Response":"TaskId: 09a0cc34-ea20-4430-b602-..."},
    "127.0.0.1:53790_solr":{
      "responseHeader":{
        "status":0,
        "QTime":0},
      "STATUS":"completed",
      "core":"solrj_test_shard1_replica_n1",
      "Response":"TaskId: 09a0cc34-ea20-4430-b602-7..."},
    "127.0.0.1:53787_solr":{
      "responseHeader":{
        "status":0,
        "QTime":0},
      "STATUS":"completed",
      "core":"solrj_test_shard2_replica_n4",
      "Response":"TaskId: 09a0cc34-ea20-4430-b602-..."}},
  "status":{
    "state":"completed",
    "msg":"found [09a0cc34-ea20-4430-b602-7557dfb6e511] in completed tasks"}}
{code}

I think we should remove the {{Response}} part as well, but it can be done in another issue.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org