You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@servicecomb.apache.org by GitBox <gi...@apache.org> on 2018/01/15 03:41:41 UTC
[GitHub] eric-lee-ltk commented on a change in pull request #116: SCB-220 avoid redundant compensation
eric-lee-ltk commented on a change in pull request #116: SCB-220 avoid redundant compensation
URL: https://github.com/apache/incubator-servicecomb-saga/pull/116#discussion_r161426533
##########
File path: alpha/alpha-server/src/main/java/org/apache/servicecomb/saga/alpha/server/TxEventEnvelopeRepository.java
##########
@@ -19,15 +19,33 @@
import java.util.List;
+import org.apache.servicecomb.saga.alpha.core.TxEvent;
import org.springframework.data.jpa.repository.Query;
import org.springframework.data.repository.CrudRepository;
interface TxEventEnvelopeRepository extends CrudRepository<TxEventEnvelope, Long> {
- TxEventEnvelope findByEventGlobalTxId(String globalTxId);
+ List<TxEventEnvelope> findByEventGlobalTxId(String globalTxId);
- @Query("SELECT DISTINCT new org.apache.servicecomb.saga.alpha.server.TxEventEnvelope("
+ @Query("SELECT DISTINCT new org.apache.servicecomb.saga.alpha.core.TxEvent("
+ "t.event.serviceName, t.event.instanceId, t.event.globalTxId, t.event.localTxId, t.event.parentTxId, t.event.type, t.event.compensationMethod, t.event.payloads"
+ ") FROM TxEventEnvelope t "
+ "WHERE t.event.globalTxId = ?1 AND t.event.type = ?2")
- List<TxEventEnvelope> findByEventGlobalTxIdAndEventType(String globalTxId, String type);
+ List<TxEvent> findByEventGlobalTxIdAndEventType(String globalTxId, String type);
+
+ TxEventEnvelope findFirstByEventGlobalTxIdAndEventLocalTxIdAndEventType(String globalTxId, String localTxId, String type);
+
+ @Query("SELECT DISTINCT new org.apache.servicecomb.saga.alpha.core.TxEvent("
+ + "t.event.serviceName, t.event.instanceId, t.event.globalTxId, t.event.localTxId, t.event.parentTxId, t.event.type, t.event.compensationMethod, t.event.payloads"
+ + ") FROM TxEventEnvelope t "
+ + "WHERE t.event.globalTxId = ?1 AND t.event.type = 'TxStartedEvent' AND EXISTS ( "
+ + " FROM TxEventEnvelope t1 "
+ + " WHERE t1.event.globalTxId = ?1 "
+ + " AND t1.event.localTxId = t.event.localTxId "
+ + " AND t1.event.type = 'TxEndedEvent'"
+ + ") AND NOT EXISTS ( "
+ + " FROM TxEventEnvelope t2 "
+ + " WHERE t2.event.globalTxId = ?1 "
+ + " AND t2.event.localTxId = t.event.localTxId "
+ + " AND t2.event.type = 'TxCompensatedEvent')")
+ List<TxEvent> findStartedEventsWithMatchingEndedButNotCompensatedEvents(String globalTxId);
Review comment:
seems the started events are not necessary since you just need to find out all ended events without their corresponding compensated events?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services