[jira] [Comment Edited] (FLINK-34386) Add RocksDB bloom filter metrics

["Piotr Nowojski (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-34386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17818837#comment-17818837 ] 

Piotr Nowojski edited comment on FLINK-34386 at 2/20/24 2:42 PM:
-----------------------------------------------------------------

merged commit 890a995 into apache:master now

Thanks [~hejufang001]!


was (Author: pnowojski):
merged commit 890a995 into apache:master now

> Add RocksDB bloom filter metrics
> --------------------------------
>
>                 Key: FLINK-34386
>                 URL: https://issues.apache.org/jira/browse/FLINK-34386
>             Project: Flink
>          Issue Type: Improvement
>          Components: Runtime / State Backends
>    Affects Versions: 1.18.0
>            Reporter: Jufang He
>            Assignee: Jufang He
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.20.0
>
>
> In our production environment, with RocksDB bloom filter enabled, the performance optimization effect on task state reading is obvious. However, there is a lack of usage metrics for bloom filter, If these Metrics are reported via Metrics reporter, it is easy to monitor the effectiveness of bloom filter optimization.
> And these metrics are available from RocksDB Statistics:
> BLOOM_FILTER_USEFUL: times bloom filter has avoided file reads.
> BLOOM_FILTER_FULL_POSITIVE: times bloom FullFilter has not avoided the reads.
> BLOOM_FILTER_FULL_TRUE_POSITIVE: times bloom FullFilter has not avoided the reads and data actually exist.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)