You are viewing a plain text version of this content. The canonical link for it is here.
Posted to soap-dev@xml.apache.org by ne...@apache.org on 2001/02/14 03:29:28 UTC
cvs commit: xml-soap/java/src/org/apache/soap/rpc RPCMessage.java
neyama 01/02/13 18:29:28
Modified: java/src/org/apache/soap Body.java Envelope.java
java/src/org/apache/soap/rpc RPCMessage.java
Log:
While Body#marshall() prints line separators before and after body
entries, RPCMessage#marshall() does NOT print a line separator after
the last body entry.
This causes a problem in combination with SOAP digital signature
because info set of the target envelope is broken in marshalling and
unmarshalling.
This patch fixes the problem.
Revision Changes Path
1.6 +1 -0 xml-soap/java/src/org/apache/soap/Body.java
Index: Body.java
===================================================================
RCS file: /home/cvs/xml-soap/java/src/org/apache/soap/Body.java,v
retrieving revision 1.5
retrieving revision 1.6
diff -u -r1.5 -r1.6
--- Body.java 2001/01/08 12:25:11 1.5
+++ Body.java 2001/02/14 02:29:27 1.6
@@ -166,6 +166,7 @@
throw new IllegalArgumentException("Unknown type of body entry: '" +
obj.getClass () + "'");
}
+ sink.write(StringUtils.lineSeparator);
}
}
1.6 +2 -1 xml-soap/java/src/org/apache/soap/Envelope.java
Index: Envelope.java
===================================================================
RCS file: /home/cvs/xml-soap/java/src/org/apache/soap/Envelope.java,v
retrieving revision 1.5
retrieving revision 1.6
diff -u -r1.5 -r1.6
--- Envelope.java 2001/01/17 22:27:19 1.5
+++ Envelope.java 2001/02/14 02:29:27 1.6
@@ -214,7 +214,8 @@
}
}
- sink.write("</" + soapEnvNSPrefix + ':' + Constants.ELEM_ENVELOPE + '>');
+ sink.write("</" + soapEnvNSPrefix + ':' + Constants.ELEM_ENVELOPE +
+ '>' + StringUtils.lineSeparator);
}
/**
1.12 +1 -2 xml-soap/java/src/org/apache/soap/rpc/RPCMessage.java
Index: RPCMessage.java
===================================================================
RCS file: /home/cvs/xml-soap/java/src/org/apache/soap/rpc/RPCMessage.java,v
retrieving revision 1.11
retrieving revision 1.12
diff -u -r1.11 -r1.12
--- RPCMessage.java 2001/02/12 02:17:44 1.11
+++ RPCMessage.java 2001/02/14 02:29:27 1.12
@@ -307,8 +307,7 @@
serializeParams(params, actualMsgEncStyle, sink, nsStack, xjmr, ctx);
sink.write("</" + targetObjectNSPrefix + ':' +
- methodName + suffix + '>' +
- StringUtils.lineSeparator);
+ methodName + suffix + '>');
}
nsStack.popScope();