You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Klaus Ma <kl...@gmail.com> on 2015/12/14 13:09:39 UTC
Review Request 41345: [WIP] MESOS-3892: Add a helper function to the
Agent
to retrieve the list of executors that are using optimistically offered,
revocable resources.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41345/
-----------------------------------------------------------
Review request for mesos.
Bugs: MESOS-3982
https://issues.apache.org/jira/browse/MESOS-3982
Repository: mesos
Description
-------
Add a helper function to the Agent to retrieve the list of executors that are using optimistically offered, revocable resources.
Diffs
-----
src/slave/slave.hpp b7586ce
src/slave/slave.cpp 9bd86e1
Diff: https://reviews.apache.org/r/41345/diff/
Testing
-------
make && make check
Thanks,
Klaus Ma
Re: Review Request 41345: [WIP] MESOS-3892: Add a helper function to
the
Agent to retrieve the list of executors that are using optimistically
offered, revocable resources.
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41345/#review110882
-----------------------------------------------------------
src/slave/slave.hpp (line 582)
<https://reviews.apache.org/r/41345/#comment170897>
Only has std::list<ExecutorID> is not enough, it is better put the whole executor here
- Guangya Liu
On Dec. 16, 2015, 3:11 a.m., Klaus Ma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41345/
> -----------------------------------------------------------
>
> (Updated Dec. 16, 2015, 3:11 a.m.)
>
>
> Review request for mesos, Guangya Liu, Yongqiao Wang, and Qian Zhang.
>
>
> Bugs: MESOS-3982
> https://issues.apache.org/jira/browse/MESOS-3982
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add a helper function to the Agent to retrieve the list of executors that are using optimistically offered, revocable resources.
>
>
> Diffs
> -----
>
> include/mesos/type_utils.hpp b370b51
> src/slave/slave.hpp b7586ce
> src/slave/slave.cpp 9bd86e1
>
> Diff: https://reviews.apache.org/r/41345/diff/
>
>
> Testing
> -------
>
> make && make check
>
>
> Thanks,
>
> Klaus Ma
>
>
Re: Review Request 41345: [WIP] MESOS-3892: Add a helper function to
the
Agent to retrieve the list of executors that are using optimistically
offered, revocable resources.
Posted by Klaus Ma <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41345/
-----------------------------------------------------------
(Updated Dec. 16, 2015, 11:11 a.m.)
Review request for mesos, Guangya Liu, Yongqiao Wang, and Qian Zhang.
Changes
-------
Add reviews and fix build error
Bugs: MESOS-3982
https://issues.apache.org/jira/browse/MESOS-3982
Repository: mesos
Description
-------
Add a helper function to the Agent to retrieve the list of executors that are using optimistically offered, revocable resources.
Diffs (updated)
-----
include/mesos/type_utils.hpp b370b51
src/slave/slave.hpp b7586ce
src/slave/slave.cpp 9bd86e1
Diff: https://reviews.apache.org/r/41345/diff/
Testing
-------
make && make check
Thanks,
Klaus Ma
Re: Review Request 41345: [WIP] MESOS-3892: Add a helper function to
the
Agent to retrieve the list of executors that are using optimistically
offered, revocable resources.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41345/#review110304
-----------------------------------------------------------
Bad review!
Reviews applied: []
Error:
No reviewers specified. Please find a reviewer by asking on JIRA or the mailing list.
- Mesos ReviewBot
On Dec. 14, 2015, 12:12 p.m., Klaus Ma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41345/
> -----------------------------------------------------------
>
> (Updated Dec. 14, 2015, 12:12 p.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-3982
> https://issues.apache.org/jira/browse/MESOS-3982
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add a helper function to the Agent to retrieve the list of executors that are using optimistically offered, revocable resources.
>
>
> Diffs
> -----
>
> src/slave/slave.hpp b7586ce
> src/slave/slave.cpp 9bd86e1
>
> Diff: https://reviews.apache.org/r/41345/diff/
>
>
> Testing
> -------
>
> make && make check
>
>
> Thanks,
>
> Klaus Ma
>
>
Re: Review Request 41345: [WIP] MESOS-3892: Add a helper function to
the
Agent to retrieve the list of executors that are using optimistically
offered, revocable resources.
Posted by Klaus Ma <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41345/
-----------------------------------------------------------
(Updated Dec. 14, 2015, 8:12 p.m.)
Review request for mesos.
Changes
-------
Remove duplicated codes
Bugs: MESOS-3982
https://issues.apache.org/jira/browse/MESOS-3982
Repository: mesos
Description
-------
Add a helper function to the Agent to retrieve the list of executors that are using optimistically offered, revocable resources.
Diffs (updated)
-----
src/slave/slave.hpp b7586ce
src/slave/slave.cpp 9bd86e1
Diff: https://reviews.apache.org/r/41345/diff/
Testing
-------
make && make check
Thanks,
Klaus Ma