You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/08/07 16:07:09 UTC
[GitHub] [incubator-superset] codecov-io edited a comment on issue #8002:
[WiP] [SQLLab] Fix, database api unlimited page size v2
codecov-io edited a comment on issue #8002: [WiP] [SQLLab] Fix, database api unlimited page size v2
URL: https://github.com/apache/incubator-superset/pull/8002#issuecomment-519097762
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8002?src=pr&el=h1) Report
> Merging [#8002](https://codecov.io/gh/apache/incubator-superset/pull/8002?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/b380879c41e785efbaa155a5b20254f619f08093?src=pr&el=desc) will **decrease** coverage by `7.6%`.
> The diff coverage is `100%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/8002/graphs/tree.svg?width=650&token=KsB0fHcx6l&height=150&src=pr)](https://codecov.io/gh/apache/incubator-superset/pull/8002?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #8002 +/- ##
==========================================
- Coverage 73.23% 65.62% -7.61%
==========================================
Files 115 469 +354
Lines 11839 22421 +10582
Branches 0 2431 +2431
==========================================
+ Hits 8670 14714 +6044
- Misses 3169 7587 +4418
- Partials 0 120 +120
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/8002?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/assets/src/components/TableSelector.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8002/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jb21wb25lbnRzL1RhYmxlU2VsZWN0b3IuanN4) | `84.16% <ø> (ø)` | |
| [superset/views/database/api.py](https://codecov.io/gh/apache/incubator-superset/pull/8002/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvYXBpLnB5) | `100% <100%> (ø)` | :arrow_up: |
| [superset/assets/src/components/Checkbox.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8002/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jb21wb25lbnRzL0NoZWNrYm94LmpzeA==) | `100% <0%> (ø)` | |
| [...ations/deckgl/layers/Polygon/PolygonChartPlugin.js](https://codecov.io/gh/apache/incubator-superset/pull/8002/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aXN1YWxpemF0aW9ucy9kZWNrZ2wvbGF5ZXJzL1BvbHlnb24vUG9seWdvbkNoYXJ0UGx1Z2luLmpz) | `0% <0%> (ø)` | |
| [...ets/src/dashboard/components/dnd/DragDroppable.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8002/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvY29tcG9uZW50cy9kbmQvRHJhZ0Ryb3BwYWJsZS5qc3g=) | `94.59% <0%> (ø)` | |
| [...c/visualizations/deckgl/layers/Polygon/Polygon.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8002/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aXN1YWxpemF0aW9ucy9kZWNrZ2wvbGF5ZXJzL1BvbHlnb24vUG9seWdvbi5qc3g=) | `0% <0%> (ø)` | |
| [superset/assets/src/components/EditableTitle.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8002/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jb21wb25lbnRzL0VkaXRhYmxlVGl0bGUuanN4) | `81.53% <0%> (ø)` | |
| [superset/assets/src/setup/setupPlugins.js](https://codecov.io/gh/apache/incubator-superset/pull/8002/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9zZXR1cC9zZXR1cFBsdWdpbnMuanM=) | `0% <0%> (ø)` | |
| [...t/assets/src/components/InfoTooltipWithTrigger.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8002/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jb21wb25lbnRzL0luZm9Ub29sdGlwV2l0aFRyaWdnZXIuanN4) | `41.66% <0%> (ø)` | |
| [.../src/dashboard/components/UndoRedoKeylisteners.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8002/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvY29tcG9uZW50cy9VbmRvUmVkb0tleWxpc3RlbmVycy5qc3g=) | `9.52% <0%> (ø)` | |
| ... and [347 more](https://codecov.io/gh/apache/incubator-superset/pull/8002/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8002?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8002?src=pr&el=footer). Last update [b380879...7bab055](https://codecov.io/gh/apache/incubator-superset/pull/8002?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org