[GitHub] ddragosd commented on a change in pull request #2256: surface errors in runtimes.manifest configuration in the controller logs

[gi...@git.apache.org]

ddragosd commented on a change in pull request #2256: surface errors in runtimes.manifest configuration in the controller logs
URL: https://github.com/apache/incubator-openwhisk/pull/2256#discussion_r121324374
 
 

 ##########
 File path: tests/src/test/scala/whisk/core/entity/test/ExecManifestTests.scala
 ##########
 @@ -170,4 +176,22 @@ class ExecManifestTests
                     image.localImageName("r", "p", Some("tag")) shouldBe s"r/p/$name:tag"
             }
     }
+
+    it should "throw an error when configured manifest is invalid" in {
+        val config_manifest = "{\"nodejs\":[{\"kind\":\"nodejs\",\"image\":{\"name\":\"nodejsaction\"},\"deprecated\":true},{\"kind\":\"nodejs:6\",\"default\":true,\"image\":{\"name\":\"nodejs6action\"}}]}"
 
 Review comment:
   I've updated the test description
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services