You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/05/11 14:06:48 UTC
[GitHub] [arrow-datafusion] andygrove opened a new pull request, #2515: Protobuf dedupe
andygrove opened a new pull request, #2515:
URL: https://github.com/apache/arrow-datafusion/pull/2515
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes https://github.com/apache/arrow-datafusion/issues/2513 and https://github.com/apache/arrow-datafusion/issues/2514
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
No need to have two copies of the same source file
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
- Delete copy of datafusion.proto file
- Use more appropriate java package name
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
Yes, for java users using these .proto files
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #2515: WIP: Remove duplicate `datafusion.proto` file and use more appropriate Java package names
Posted by GitBox <gi...@apache.org>.
alamb commented on PR #2515:
URL: https://github.com/apache/arrow-datafusion/pull/2515#issuecomment-1127607010
I think we might be able to merge this PR now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] andygrove commented on a diff in pull request #2515: Remove duplicate `datafusion.proto` file and use more appropriate Java package names
Posted by GitBox <gi...@apache.org>.
andygrove commented on code in PR #2515:
URL: https://github.com/apache/arrow-datafusion/pull/2515#discussion_r870758945
##########
datafusion-cli/Cargo.lock:
##########
@@ -1,2531 +0,0 @@
-# This file is automatically @generated by Cargo.
Review Comment:
Oh, I did not mean to delete this file. I think we want to keep lock files for binaries.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] andygrove commented on pull request #2515: WIP: Remove duplicate `datafusion.proto` file and use more appropriate Java package names
Posted by GitBox <gi...@apache.org>.
andygrove commented on PR #2515:
URL: https://github.com/apache/arrow-datafusion/pull/2515#issuecomment-1125169955
Moving to draft so we don't merge before 8.0.0 PR is merged
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] andygrove closed pull request #2515: WIP: Remove duplicate `datafusion.proto` file and use more appropriate Java package names
Posted by GitBox <gi...@apache.org>.
andygrove closed pull request #2515: WIP: Remove duplicate `datafusion.proto` file and use more appropriate Java package names
URL: https://github.com/apache/arrow-datafusion/pull/2515
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] andygrove commented on pull request #2515: WIP: Remove duplicate `datafusion.proto` file and use more appropriate Java package names
Posted by GitBox <gi...@apache.org>.
andygrove commented on PR #2515:
URL: https://github.com/apache/arrow-datafusion/pull/2515#issuecomment-1133049950
Now that ballista is in the new repo I will open a PR over there instead
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #2515: Remove duplicate `datafusion.proto` file and use more appropriate Java package names
Posted by GitBox <gi...@apache.org>.
alamb commented on code in PR #2515:
URL: https://github.com/apache/arrow-datafusion/pull/2515#discussion_r870740055
##########
datafusion-cli/Cargo.lock:
##########
@@ -1,2531 +0,0 @@
-# This file is automatically @generated by Cargo.
Review Comment:
I think the idea behind this file was to allow datafusion-cli to be built by itself. https://github.com/apache/arrow-datafusion/pull/2112 by @happysalada
However, I agree it is getting annoying in my local checkout as well (seems to change regularly)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] andygrove commented on pull request #2515: Remove duplicate `datafusion.proto` file and use more appropriate Java package names
Posted by GitBox <gi...@apache.org>.
andygrove commented on PR #2515:
URL: https://github.com/apache/arrow-datafusion/pull/2515#issuecomment-1124446165
Failing on AMD64 with `No space left on device`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org