You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joseph Wu <jo...@mesosphere.io> on 2016/02/10 23:34:32 UTC
Review Request 43432: Fix CGROUPS_ROOT_* tests on systemd platforms.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43432/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joris Van Remoortere.
Repository: mesos
Description
-------
Adds an analogous call to `systemd::initialize` (compared to `src/slave/main.cpp`) in the mesos tests main function. This un-breaks the `CGROUPS_ROOT_*` tests on CentOS 6/7 and Ubuntu 15.
Diffs
-----
src/tests/main.cpp 942488e57419ace8b7a821f53024aced0f43c7d9
Diff: https://reviews.apache.org/r/43432/diff/
Testing
-------
make check
sudo bin/mesos-tests.sh --gtest_filter="*ROOT*" (CentOS 7)
Thanks,
Joseph Wu
Re: Review Request 43432: Fix CGROUPS_ROOT_* tests on systemd
platforms.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43432/#review118782
-----------------------------------------------------------
Ship it!
Ship It!
- Joris Van Remoortere
On Feb. 11, 2016, 12:34 a.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43432/
> -----------------------------------------------------------
>
> (Updated Feb. 11, 2016, 12:34 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joris Van Remoortere.
>
>
> Bugs: MESOS-4636
> https://issues.apache.org/jira/browse/MESOS-4636
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Tests do not run with systemd configured, so any dependency on systemd will fail some checks. This fixes the `LinuxLauncher` to use the correct systemd-guard function.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/linux_launcher.cpp d38c7a94a179123b618d4048fb90d59418474f21
>
> Diff: https://reviews.apache.org/r/43432/diff/
>
>
> Testing
> -------
>
> make check
> sudo bin/mesos-tests.sh --gtest_filter="*ROOT*" (CentOS 7)
>
>
> Thanks,
>
> Joseph Wu
>
>
Re: Review Request 43432: Fix CGROUPS_ROOT_* tests on systemd
platforms.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43432/
-----------------------------------------------------------
(Updated Feb. 10, 2016, 4:34 p.m.)
Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joris Van Remoortere.
Changes
-------
Change the approach after syncing with Joris.
Bugs: MESOS-4636
https://issues.apache.org/jira/browse/MESOS-4636
Repository: mesos
Description (updated)
-------
Tests do not run with systemd configured, so any dependency on systemd will fail some checks. This fixes the `LinuxLauncher` to use the correct systemd-guard function.
Diffs (updated)
-----
src/slave/containerizer/mesos/linux_launcher.cpp d38c7a94a179123b618d4048fb90d59418474f21
Diff: https://reviews.apache.org/r/43432/diff/
Testing
-------
make check
sudo bin/mesos-tests.sh --gtest_filter="*ROOT*" (CentOS 7)
Thanks,
Joseph Wu
Re: Review Request 43432: Fix CGROUPS_ROOT_* tests on systemd
platforms.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43432/
-----------------------------------------------------------
(Updated Feb. 10, 2016, 2:53 p.m.)
Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joris Van Remoortere.
Bugs: MESOS-4636
https://issues.apache.org/jira/browse/MESOS-4636
Repository: mesos
Description
-------
Adds an analogous call to `systemd::initialize` (compared to `src/slave/main.cpp`) in the mesos tests main function. This un-breaks the `CGROUPS_ROOT_*` tests on CentOS 6/7 and Ubuntu 15.
Diffs
-----
src/tests/main.cpp 942488e57419ace8b7a821f53024aced0f43c7d9
Diff: https://reviews.apache.org/r/43432/diff/
Testing
-------
make check
sudo bin/mesos-tests.sh --gtest_filter="*ROOT*" (CentOS 7)
Thanks,
Joseph Wu