You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by "yaowanli (via GitHub)" <gi...@apache.org> on 2025/11/09 15:49:09 UTC
[PR] Version 3.3.x has modified the behavior of parameter passing, therefo… [dolphinscheduler]
yaowanli opened a new pull request, #17660:
URL: https://github.com/apache/dolphinscheduler/pull/17660
…re the usage of parameter passing in the documentation has been changed.
<!--Thanks very much for contributing to Apache DolphinScheduler, we are happy that you want to help us improve DolphinScheduler! -->
## Purpose of the pull request
Version 3.3.x has modified the behavior of parameter passing, therefore the usage of parameter passing in the documentation has been changed.
In this update, I submitted a documentation update regarding changes to parameter passing usage.
## Brief change log
The example images and instructions for parameter passing in the document have been modified.
## Verify this pull request
<!--*(Please pick either of the following options)*-->
This pull request is code cleanup without any test coverage.
*(or)*
This pull request is already covered by existing tests, such as *(please describe tests)*.
(or)
This change added tests and can be verified as follows:
<!--*(example:)*
- *Added dolphinscheduler-dao tests for end-to-end.*
- *Added CronUtilsTest to verify the change.*
- *Manually verified the change by testing locally.* -->
(or)
## Pull Request Notice
[Pull Request Notice](https://github.com/apache/dolphinscheduler/blob/dev/docs/docs/en/contribute/join/pull-request.md)
If your pull request contains incompatible change, you should also add it to `docs/docs/en/guide/upgrade/incompatible.md`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Fix-17639] Parameter passing docs improvement [dolphinscheduler]
Posted by "SbloodyS (via GitHub)" <gi...@apache.org>.
SbloodyS closed pull request #17660: [Fix-17639] Parameter passing docs improvement
URL: https://github.com/apache/dolphinscheduler/pull/17660
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Fix-17639] Parameter passing docs improvement [dolphinscheduler]
Posted by "SbloodyS (via GitHub)" <gi...@apache.org>.
SbloodyS commented on PR #17660:
URL: https://github.com/apache/dolphinscheduler/pull/17660#issuecomment-3695352693
Please using english to describe. @cometLIU
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Fix-17639] Parameter passing docs improvement [dolphinscheduler]
Posted by "cometLIU (via GitHub)" <gi...@apache.org>.
cometLIU commented on PR #17660:
URL: https://github.com/apache/dolphinscheduler/pull/17660#issuecomment-3695347021
额，参数传递这么重要的功能，文档居然没有写的很明白，这文档真的很坑。比如 3.3.1 版本里面的节点间参数传递，支持sehll 2sql；并且shell里面还需要定义参数名和shell的out参数一致；然后sql2sql节点间的参数传递，还不支持
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Fix-17639] Parameter passing docs improvement [dolphinscheduler]
Posted by "SbloodyS (via GitHub)" <gi...@apache.org>.
SbloodyS commented on code in PR #17660:
URL: https://github.com/apache/dolphinscheduler/pull/17660#discussion_r2509177351
##########
docs/docs/en/guide/parameter/context.md:
##########
@@ -23,7 +23,17 @@ The value of upstream parameter can be updated in downstream node in the same wa
Upstream parameter will be override when defining parameter with the same name in downstream node.
-> Note: If there are no dependencies between nodes, local parameters cannot be passed upstream.
+> Note:
+>
+>**1. Parameter passing behavior has changed in version 3.3.x**
+>
+> In older version 3.2.x, downstream node B could obtain the out type output X of upstream node A without configuring an IN type local variable X.
Review Comment:
```suggestion
> In older version before 3.2.2, downstream node B could obtain the out type output X of upstream node A without configuring an IN type local variable X.
```
##########
docs/docs/en/guide/parameter/context.md:
##########
@@ -23,7 +23,17 @@ The value of upstream parameter can be updated in downstream node in the same wa
Upstream parameter will be override when defining parameter with the same name in downstream node.
-> Note: If there are no dependencies between nodes, local parameters cannot be passed upstream.
+> Note:
+>
+>**1. Parameter passing behavior has changed in version 3.3.x**
+>
+> In older version 3.2.x, downstream node B could obtain the out type output X of upstream node A without configuring an IN type local variable X.
+>
+> In the new version 3.3.x, the logic for obtaining local variables has been modified: downstream node B can only use the out type output X of upstream node A if it has configured an IN type local variable X.
Review Comment:
```suggestion
> In the new version after 3.3.0, the logic for obtaining local variables has been modified: downstream node B can only use the out type output X of upstream node A if it has configured an IN type local variable X.
```
##########
docs/docs/zh/guide/parameter/context.md:
##########
@@ -23,7 +23,19 @@ DolphinScheduler 允许在任务间进行参数传递，目前传递方向仅支
如果定义了同名的传递参数，上游节点的参数将被覆盖。
-> 注：若节点之间没有依赖关系，则局部参数无法通过上游传递。
+> 注:
+>
+> **1.参数传递的行为在3.3.x版本中发生了变化**
+>
+> 在旧版本3.2.x中，下游节点B无需配置IN类型局部变量X即可获取上游节点A的out类型输出X；
+>
+> 在新版本3.3.x中修改领了局部变量的获取逻辑：只有下游节点B配置了IN类型的局部变量X，才可使用上游节点A的out类型输出X。
Review Comment:
```suggestion
> 在新版本高于3.3.0中修改领了局部变量的获取逻辑：只有下游节点B配置了IN类型的局部变量X，才可使用上游节点A的out类型输出X。
```
##########
docs/docs/zh/guide/parameter/context.md:
##########
@@ -23,7 +23,19 @@ DolphinScheduler 允许在任务间进行参数传递，目前传递方向仅支
如果定义了同名的传递参数，上游节点的参数将被覆盖。
-> 注：若节点之间没有依赖关系，则局部参数无法通过上游传递。
+> 注:
+>
+> **1.参数传递的行为在3.3.x版本中发生了变化**
+>
+> 在旧版本3.2.x中，下游节点B无需配置IN类型局部变量X即可获取上游节点A的out类型输出X；
Review Comment:
```suggestion
> 在旧版本低于3.2.2中，下游节点B无需配置IN类型局部变量X即可获取上游节点A的out类型输出X；
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Fix-17639] Parameter passing docs improvement [dolphinscheduler]
Posted by "cometLIU (via GitHub)" <gi...@apache.org>.
cometLIU commented on PR #17660:
URL: https://github.com/apache/dolphinscheduler/pull/17660#issuecomment-3775741003
in version 3.3.1, downstream SQL node A can't use the out type output X of upstream SQL node A。 but the documentation is surprisingly unclear
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Version 3.3.x has modified the behavior of parameter passing, therefo… [dolphinscheduler]
Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #17660:
URL: https://github.com/apache/dolphinscheduler/pull/17660#issuecomment-3508468341
Thanks for opening this pull request! Please check out our contributing guidelines. (https://github.com/apache/dolphinscheduler/blob/dev/docs/docs/en/contribute/join/pull-request.md)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org