You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/05/17 16:04:03 UTC

[GitHub] [airflow] eladkal opened a new issue, #23756: Amazon EKS example DAG raises warnning

eladkal opened a new issue, #23756:
URL: https://github.com/apache/airflow/issues/23756

   ### Body
   
   ```
   Importing package: airflow.providers.amazon.aws.example_dags
   [2022-05-17 15:53:10,675] {eks.py:287} WARNING - The nodegroup_subnets should be List or string representing Python list and is {{ dag_run.conf['nodegroup_subnets'] }}. Defaulting to []
   ```
   
   https://github.com/apache/airflow/blob/dec05fb6b29f2aff454bcbc3939b3b78ba5b785f/airflow/providers/amazon/aws/example_dags/example_eks_templated.py#L82
   
   example for waning raising in the CI:
   https://github.com/apache/airflow/runs/6474027737?check_suite_focus=true#step:12:1010
   
   We should fix it. The example DAG should not yield warnings.
   
   ### Committer
   
   - [X] I acknowledge that I am a maintainer/committer of the Apache Airflow project.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] potiuk commented on issue #23756: Amazon EKS example DAG raises warnning

Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #23756:
URL: https://github.com/apache/airflow/issues/23756#issuecomment-1132297872

   Done
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] potiuk closed issue #23756: Amazon EKS example DAG raises warnning

Posted by GitBox <gi...@apache.org>.
potiuk closed issue #23756: Amazon EKS example DAG raises warnning
URL: https://github.com/apache/airflow/issues/23756


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] josh-fell commented on issue #23756: Amazon EKS example DAG raises warnning

Posted by GitBox <gi...@apache.org>.
josh-fell commented on issue #23756:
URL: https://github.com/apache/airflow/issues/23756#issuecomment-1133490100

   The issue is that `nodegroup_subnets` is a template field for the operator and the string evaluation on that arg is happening as part of the constructor. We've been slowly finding more and more of these instances and pushing them out of `__init__()`, but template fields are not rendered (i.e. retain their stringified Jinja value until _just_ before the `execute()` method is called. So string evaluations on template fields should not happen until the `execute()` scope. This would also generally emit a warning if `nodegroup_subnets` was an `XComArg` as well.
   
   Moving that evaluation section to the scope of the `execute()` method should do the trick and be functionally correct.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] potiuk commented on issue #23756: Amazon EKS example DAG raises warnning

Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #23756:
URL: https://github.com/apache/airflow/issues/23756#issuecomment-1130747741

   Yeah. we should remove those warnings!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] Dark-Knight11 commented on issue #23756: Amazon EKS example DAG raises warnning

Posted by GitBox <gi...@apache.org>.
Dark-Knight11 commented on issue #23756:
URL: https://github.com/apache/airflow/issues/23756#issuecomment-1131913094

   Hi, I would like to work on this issue. Can you please assign it to me? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] Dark-Knight11 commented on issue #23756: Amazon EKS example DAG raises warnning

Posted by GitBox <gi...@apache.org>.
Dark-Knight11 commented on issue #23756:
URL: https://github.com/apache/airflow/issues/23756#issuecomment-1132878265

   Hi, I looked into the issue and was confused about what to do. 
   `ast.literal_eval` is not able to process this string `{{ dag_run.conf['nodegroup_subnets'] }}`
   I also looked in other files where literal_eval is used. `DockerOperator` uses it but I'm getting errors there as well.
   Can you please help me with correct string format or do we need to make changes in `EksCreateNodegroupOperator`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org