You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2022/03/25 15:59:01 UTC

[GitHub] [trafficcontrol] ericholguin opened a new issue #6691: deliveryservices returns Internal Server Error when config parameter doesn't exist

ericholguin opened a new issue #6691:
URL: https://github.com/apache/trafficcontrol/issues/6691


   <!--
   ************ STOP!! ************
   If this issue identifies a security vulnerability, DO NOT submit it! Instead, contact
   the Apache Traffic Control Security Team at security@trafficcontrol.apache.org and follow the
   guidelines at https://apache.org/security regarding vulnerability disclosure.
   
   - For *SUPPORT QUESTIONS*, use the #traffic-control channel on the ASF slack (https://s.apache.org/tc-slack-request)
   or the Traffic Control Users mailing list (send an email to users-subscribe@trafficcontrol.apache.org to subscribe).
   - Before submitting, please **SEARCH GITHUB** for a similar issue or PR
       * https://github.com/apache/trafficcontrol/issues
       * https://github.com/apache/trafficcontrol/pulls
   -->
   
   <!-- Do not submit security vulnerabilities or support requests here - see above -->
   ## This Bug Report affects these Traffic Control components:
   <!-- delete all those that don't apply -->
   
   - Traffic Ops
   
   
   ## Current behavior:
   <!-- Describe how the bug happens -->
   When sending either a `POST` or `PUT` request to `/deliveryservices` and either the`midHeaderRewrite` or `edgeHeaderRewrite` have a value BUT there is no remap.config parameter created, this will result in an Internal Server Error.
   
   Traffic Ops error.log will show:
   ```
   ERROR: api.go:263: ... ensuring ds parameters:: creating edge header rewrite parameters: executing parameter query for ATS config location: parameter missing (do you have a name=location config_file=remap.config parameter?
   ```
   
   Coming from: https://github.com/apache/trafficcontrol/blob/d4286d867db2a094c39e127336869ad8cc0eb74f/traffic_ops/traffic_ops_golang/deliveryservice/deliveryservices.go#L2019
   
   ## Expected behavior:
   <!-- Describe what the behavior would be without the bug -->
   Should return a 400 Bad Request with the proper message mentioning that the parameter is required.
   
   ## Steps to reproduce:
   <!-- If the current behavior is a bug, please provide the *STEPS TO REPRODUCE* and
   include the applicable TC version.
   -->
   In CiaB, open TP create a delivery service with an **Edge Header Rewrite Rule** e.g. "edgeHeader1\nedgeHeader2", after having all other values correctly filled in click on the Create button, you should see an Internal Server Error at the top of the page and it will not have created the delivery service. Do the same again this time with  an **Mid Header Rewrite Rule** e.g. "midHeader1\midHeader2" you should again see an Internal Server Error at the top of the page and it will not have created the delivery service.
   
   The same can be done using the Traffic Ops API with either of the edge or mid header rewrite fields containing a value.
   
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficcontrol] ocket8888 commented on issue #6691: deliveryservices returns Internal Server Error when config parameter doesn't exist

Posted by GitBox <gi...@apache.org>.
ocket8888 commented on issue #6691:
URL: https://github.com/apache/trafficcontrol/issues/6691#issuecomment-1081182814


   If it's really a requirement that any working ATC instance have this Parameter, it ought to be in our seed data


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org