You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@samza.apache.org by "Jake Maes (JIRA)" <ji...@apache.org> on 2017/03/22 15:00:48 UTC

[jira] [Resolved] (SAMZA-1156) Improve ApplicationRunner method naming and class structure.

     [ https://issues.apache.org/jira/browse/SAMZA-1156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jake Maes resolved SAMZA-1156.
------------------------------
       Resolution: Fixed
    Fix Version/s: 0.13.0

Issue resolved by pull request 93
[https://github.com/apache/samza/pull/93]

> Improve ApplicationRunner method naming and class structure.
> ------------------------------------------------------------
>
>                 Key: SAMZA-1156
>                 URL: https://issues.apache.org/jira/browse/SAMZA-1156
>             Project: Samza
>          Issue Type: Bug
>            Reporter: Jake Maes
>            Assignee: Jake Maes
>             Fix For: 0.13.0
>
>
> This ticket tracks the improvements suggested by [~navina] in PR 88
> https://github.com/apache/samza/pull/88
> Specifically, we need to:
> 1. Rename streamFromConfig() to getStream(), which makes more sense now that Config is no longer an argument. 
> 2. Change ApplicationRunner from an interface to an abstract class and pull the constructor up from AbstractApplicationRunner. This provides a simple contract in the samza API while retaining the static constructor and the common implementations in AbstractApplicationRunner. The net is that users can extend ApplicationRunner directly or via AbstractApplicationRunner to inherit the common implementation of getStream.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)