[GitHub] [spark] dillitz commented on pull request #41829: [SPARK-44275][CONNECT] Add configurable retry mechanism to Scala Spark Connect

["dillitz (via GitHub)" <gi...@apache.org>]

dillitz commented on PR #41829:
URL: https://github.com/apache/spark/pull/41829#issuecomment-1622454229

   > @dillitz Since #41743 merged, I think it would be best to:
   > 
   > * moving the retrier to it's own utility class, used from the blocking stub (like GrpcExceptionConverter object)
   > * implement a non blocking stub as well
   > * implement retries for addArtifacts. It is a client-side stream, so also needs special handling: only sending the first element in the stream should be retried.
   > * implement functions in SparkConnectClient needed for ArtifactManager, so that ArtifactManager uses the client instead of sending rpcs directly
   
   Not sure if I managed to implement the retries for the ArtifactManager correctly. I need your expertise here @juliuszsompolski. Previously implemented retries should be successfully moved to the `CustomSparkConnectBlockingStub`/`GrpcRetryHandler`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org