You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by "desaikomal (via GitHub)" <gi...@apache.org> on 2023/07/18 23:17:33 UTC
[GitHub] [helix] desaikomal opened a new pull request, #2561: CustomizedView need to handle ungraceful shutdown of instances
desaikomal opened a new pull request, #2561:
URL: https://github.com/apache/helix/pull/2561
### Issues
- [ ] My PR addresses the following Helix issues and references them in the PR description:
### Description
- [X] Here are some details about my PR, including screenshots of any UI changes:
Helix Customized View allows customers to view aggregated view from various instances. When an instance ungracefully dies, the customizedState for that instance is not cleaned up. When this ungraceful instance comes back online, before it can reset the customizedState, Helix controller will report stale data from the previous session.
During graceful shutdown, user explicitly resets the state in per-instance view but during ungraceful shutdown, it doesn't clean up. This change deletes the per-instance customized state in live-instance down callback listener.
### Tests
- [x] The following tests are written for this issue:
testDeleteInstanceCustomizedStateAggregation()
(List the names of added unit/integration tests)
- The following is the result of the "mvn test" command on the appropriate module:
mvn test is in progress will update it here as soon as it finishes it.
(If CI test fails due to known issue, please specify the issue and test PR locally. Then copy & paste the result of "mvn test" to here.)
### Changes that Break Backward Compatibility (Optional)
- My PR contains changes that break backward compatibility or previous assumptions for certain methods or API. They include:
(Consider including all behavior changes for public methods or API. Also include these changes in merge description so that other developers are aware of these changes. This allows them to make relevant code changes in feature branches accounting for the new method/API behavior.)
### Documentation (Optional)
- In case of new functionality, my PR adds documentation in the following wiki page:
(Link the GitHub wiki you added)
### Commits
- My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Code Quality
- My diff has been formatted using helix-style.xml
(helix-style-intellij.xml if IntelliJ IDE is used)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] huangminchn commented on a diff in pull request #2561: CustomizedView need to handle ungraceful shutdown of instances
Posted by "huangminchn (via GitHub)" <gi...@apache.org>.
huangminchn commented on code in PR #2561:
URL: https://github.com/apache/helix/pull/2561#discussion_r1268758480
##########
helix-core/src/main/java/org/apache/helix/controller/GenericHelixController.java:
##########
@@ -1391,6 +1393,8 @@ protected void checkLiveInstancesObservation(List<LiveInstance> liveInstances,
manager.removeListener(keyBuilder.messages(instance), this);
// remove customized state root listener for disconnected instances
manager.removeListener(keyBuilder.customizedStatesRoot(instance), this);
+ // delete the customized state root path for disconnected instances
+ manager.deleteCustomizedStateRootForInstance(instance);
Review Comment:
Have a couple of the questions regarding this change:
1. Is there retry before marking a participant node as down? What are those config values for Venice?
2. My main concern is false negative (a node is mistakenly marked as down); so after a participant node, which used to be live, rejoins the cluster, Helix controller will resend state transition messages (offline->standby) to rebootstrap existing resources in the node, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] desaikomal closed pull request #2561: CustomizedView need to handle ungraceful shutdown of instances
Posted by "desaikomal (via GitHub)" <gi...@apache.org>.
desaikomal closed pull request #2561: CustomizedView need to handle ungraceful shutdown of instances
URL: https://github.com/apache/helix/pull/2561
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] desaikomal commented on pull request #2561: CustomizedView need to handle ungraceful shutdown of instances
Posted by "desaikomal (via GitHub)" <gi...@apache.org>.
desaikomal commented on PR #2561:
URL: https://github.com/apache/helix/pull/2561#issuecomment-1642192154
I am pulling this request as DRAFT as there is a test case failure which needs investigation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org