Re: [PR] fix: Fixing Helm chart flower ingress service reference [airflow]

["andormarkus (via GitHub)" <gi...@apache.org>]

andormarkus commented on PR #41179:
URL: https://github.com/apache/airflow/pull/41179#issuecomment-2343275404

   Hi @romsharon98 
   
   Sorry for the late reply I was on extended vacation.
   
   I have run into to a problem when I added the `"fullnameOverride": "test-basic"` it looks like the `chart/templates/_helpers.yaml` is not executed when I run the tests.
   
   Here are my tests
   `helm_tests/webserver/test_ingress_web.py`
   ```python
       def test_backend_service_name(self):
           docs = render_chart(
               values={"ingress": {"web": {"enabled": True}}},
               show_only=["templates/webserver/webserver-ingress.yaml"],
           )
   
           assert "release-name-webserver" == jmespath.search("spec.rules[0].http.paths[0].backend.service.name", docs[0])
   
       def test_backend_service_name_with_fullname_override(self):
           docs = render_chart(
               values={"fullnameOverride": "test-basic",
                       "ingress": {"web": {"enabled": True}}},
               show_only=["templates/webserver/webserver-ingress.yaml"],
   
           )
   
           assert "test-basic-webserver" == jmespath.search("spec.rules[0].http.paths[0].backend.service.name", docs[0])
   ```
   
   
   `helm_tests/webserver/test_ingress_flower.py`
   
   ```python
       def test_backend_service_name(self):
           docs = render_chart(
               values={"ingress": {"enabled": True}, "flower": {"enabled": True}},
               show_only=["templates/flower/flower-ingress.yaml"],
           )
   
           assert "release-name-flower" == jmespath.search("spec.rules[0].http.paths[0].backend.service.name", docs[0])
   
       def test_backend_service_name_with_fullname_override(self):
           docs = render_chart(
               values={"fullnameOverride": "test-basic",
                       "ingress": {"enabled": True}, "flower": {"enabled": True}},
               show_only=["templates/flower/flower-ingress.yaml"],
   
           )
   
           assert "test-basic-flower" == jmespath.search("spec.rules[0].http.paths[0].backend.service.name", docs[0])
   
   ```
   
   
   I run the test using the following command
   
   ```shell
    breeze testing helm-tests --helm-test-package webserver  
   ```
   
   ```shell
   FAILED helm_tests/webserver/test_ingress_flower.py::TestIngressFlower::test_backend_service_name_with_fullname_override - AssertionError: assert equals failed
     'test-basic-flower'    'release-name-flower'
   FAILED helm_tests/webserver/test_ingress_web.py::TestIngressWeb::test_backend_service_name_with_fullname_override - AssertionError: assert equals failed
     'test-basic-webserver'    'release-name-webserver'
   ```
   
   
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org