[GitHub] [couchdb] big-r81 commented on a diff in pull request #4140: Upgrade hash algorithm for cookie auth

[GitBox <gi...@apache.org>]

big-r81 commented on code in PR #4140:
URL: https://github.com/apache/couchdb/pull/4140#discussion_r941586259


##########
src/couch/src/couch_httpd_auth.erl:
##########
@@ -296,9 +296,9 @@ cookie_authentication_handler(#httpd{mochi_req = MochiReq} = Req, AuthModule) ->
                 end,
             % Verify expiry and hash
             CurrentTime = make_cookie_time(),
+            HashAlgorithms = get_config_hash_algorithms(),
             case chttpd_util:get_chttpd_auth_config("secret") of
                 undefined ->
-                    couch_log:debug("cookie auth secret is not set", []),

Review Comment:
   oh yeah I was too quick there while removing my debug output.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org