You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Brandon Li <br...@hortonworks.com> on 2015/04/01 19:41:03 UTC
Review Request 32731: AMBARI-10280 Need to check if rpcbind or
portmap is started before starting NFS Gateway
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32731/
-----------------------------------------------------------
Review request for Ambari and Alejandro Fernandez.
Bugs: AMBARI-10280
https://issues.apache.org/jira/browse/AMBARI-10280
Repository: ambari
Description
-------
AMBARI-10280 Need to check if rpcbind or portmap is started before starting NFS Gateway
Diffs
-----
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_nfsgateway.py e908ecf
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params.py 7061057
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/status_params.py c7c5325
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/utils.py 0b9af6b
Diff: https://reviews.apache.org/r/32731/diff/
Testing
-------
Manually tested it on VM.
The python unit test test_nfsgateway.py failed because now NFS is started by root not hdfs anymore.
Thanks,
Brandon Li
Re: Review Request 32731: AMBARI-10280 Need to check if rpcbind or
portmap is started before starting NFS Gateway
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32731/#review78593
-----------------------------------------------------------
Ship it!
Need unit test results.
ambari-server/src/test/python/stacks/2.0.6/HDFS/test_nfsgateway.py
<https://reviews.apache.org/r/32731/#comment127486>
If this is not needed, then remove it.
ambari-server/src/test/python/stacks/2.0.6/HDFS/test_nfsgateway.py
<https://reviews.apache.org/r/32731/#comment127487>
Can you add the same comments about the bug in Linux here, since this is where I dont want a dev to inadvertently change this back to "hdfs".
- Alejandro Fernandez
On April 1, 2015, 9:10 p.m., Brandon Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32731/
> -----------------------------------------------------------
>
> (Updated April 1, 2015, 9:10 p.m.)
>
>
> Review request for Ambari and Alejandro Fernandez.
>
>
> Bugs: AMBARI-10280
> https://issues.apache.org/jira/browse/AMBARI-10280
>
>
> Repository: ambari
>
>
> Description
> -------
>
> AMBARI-10280 Need to check if rpcbind or portmap is started before starting NFS Gateway
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_nfsgateway.py e908ecf
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params.py 58773bd
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/status_params.py c7c5325
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/utils.py 0b9af6b
> ambari-server/src/test/python/stacks/2.0.6/HDFS/test_nfsgateway.py 4fdf740
>
> Diff: https://reviews.apache.org/r/32731/diff/
>
>
> Testing
> -------
>
> Manually tested it on VM.
> The python unit test test_nfsgateway.py failed because now NFS is started by root not hdfs anymore.
>
>
> Thanks,
>
> Brandon Li
>
>
Re: Review Request 32731: AMBARI-10280 Need to check if rpcbind or
portmap is started before starting NFS Gateway
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32731/#review78609
-----------------------------------------------------------
Ship it!
Ship It!
- Alejandro Fernandez
On April 1, 2015, 10:08 p.m., Brandon Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32731/
> -----------------------------------------------------------
>
> (Updated April 1, 2015, 10:08 p.m.)
>
>
> Review request for Ambari and Alejandro Fernandez.
>
>
> Bugs: AMBARI-10280
> https://issues.apache.org/jira/browse/AMBARI-10280
>
>
> Repository: ambari
>
>
> Description
> -------
>
> AMBARI-10280 Need to check if rpcbind or portmap is started before starting NFS Gateway
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_nfsgateway.py e908ecf
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params.py 58773bd
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/status_params.py c7c5325
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/utils.py 0b9af6b
> ambari-server/src/test/python/stacks/2.0.6/HDFS/test_nfsgateway.py 4fdf740
>
> Diff: https://reviews.apache.org/r/32731/diff/
>
>
> Testing
> -------
>
> Manually tested it on VM.
> The python unit test test_nfsgateway.py failed because now NFS is started by root not hdfs anymore.
>
>
> Thanks,
>
> Brandon Li
>
>
Re: Review Request 32731: AMBARI-10280 Need to check if rpcbind or
portmap is started before starting NFS Gateway
Posted by Brandon Li <br...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32731/
-----------------------------------------------------------
(Updated April 2, 2015, 12:28 a.m.)
Review request for Ambari and Alejandro Fernandez.
Bugs: AMBARI-10280
https://issues.apache.org/jira/browse/AMBARI-10280
Repository: ambari
Description
-------
AMBARI-10280 Need to check if rpcbind or portmap is started before starting NFS Gateway
Diffs
-----
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_nfsgateway.py e908ecf
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params.py 58773bd
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/status_params.py c7c5325
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/utils.py 0b9af6b
ambari-server/src/test/python/stacks/2.0.6/HDFS/test_nfsgateway.py 4fdf740
Diff: https://reviews.apache.org/r/32731/diff/
Testing (updated)
-------
Manually tested it on VM.
The python unit test test_nfsgateway.py passed and manual installation test passed to with the most recent updated patch.
Thanks,
Brandon Li
Re: Review Request 32731: AMBARI-10280 Need to check if rpcbind or
portmap is started before starting NFS Gateway
Posted by Brandon Li <br...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32731/
-----------------------------------------------------------
(Updated April 1, 2015, 11:43 p.m.)
Review request for Ambari and Alejandro Fernandez.
Changes
-------
This patch passed unit tests and manual Ambari installation tests.
Bugs: AMBARI-10280
https://issues.apache.org/jira/browse/AMBARI-10280
Repository: ambari
Description
-------
AMBARI-10280 Need to check if rpcbind or portmap is started before starting NFS Gateway
Diffs (updated)
-----
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_nfsgateway.py e908ecf
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params.py 58773bd
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/status_params.py c7c5325
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/utils.py 0b9af6b
ambari-server/src/test/python/stacks/2.0.6/HDFS/test_nfsgateway.py 4fdf740
Diff: https://reviews.apache.org/r/32731/diff/
Testing
-------
Manually tested it on VM.
The python unit test test_nfsgateway.py failed because now NFS is started by root not hdfs anymore.
Thanks,
Brandon Li
Re: Review Request 32731: AMBARI-10280 Need to check if rpcbind or
portmap is started before starting NFS Gateway
Posted by Brandon Li <br...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32731/
-----------------------------------------------------------
(Updated April 1, 2015, 10:08 p.m.)
Review request for Ambari and Alejandro Fernandez.
Changes
-------
addressed comments for test_nfsgateway.py
Bugs: AMBARI-10280
https://issues.apache.org/jira/browse/AMBARI-10280
Repository: ambari
Description
-------
AMBARI-10280 Need to check if rpcbind or portmap is started before starting NFS Gateway
Diffs (updated)
-----
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_nfsgateway.py e908ecf
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params.py 58773bd
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/status_params.py c7c5325
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/utils.py 0b9af6b
ambari-server/src/test/python/stacks/2.0.6/HDFS/test_nfsgateway.py 4fdf740
Diff: https://reviews.apache.org/r/32731/diff/
Testing
-------
Manually tested it on VM.
The python unit test test_nfsgateway.py failed because now NFS is started by root not hdfs anymore.
Thanks,
Brandon Li
Re: Review Request 32731: AMBARI-10280 Need to check if rpcbind or
portmap is started before starting NFS Gateway
Posted by Brandon Li <br...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32731/
-----------------------------------------------------------
(Updated April 1, 2015, 9:10 p.m.)
Review request for Ambari and Alejandro Fernandez.
Changes
-------
new patch that passed all the unit tests
Bugs: AMBARI-10280
https://issues.apache.org/jira/browse/AMBARI-10280
Repository: ambari
Description
-------
AMBARI-10280 Need to check if rpcbind or portmap is started before starting NFS Gateway
Diffs (updated)
-----
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_nfsgateway.py e908ecf
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params.py 58773bd
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/status_params.py c7c5325
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/utils.py 0b9af6b
ambari-server/src/test/python/stacks/2.0.6/HDFS/test_nfsgateway.py 4fdf740
Diff: https://reviews.apache.org/r/32731/diff/
Testing
-------
Manually tested it on VM.
The python unit test test_nfsgateway.py failed because now NFS is started by root not hdfs anymore.
Thanks,
Brandon Li
Re: Review Request 32731: AMBARI-10280 Need to check if rpcbind or
portmap is started before starting NFS Gateway
Posted by Brandon Li <br...@hortonworks.com>.
> On April 1, 2015, 5:56 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_nfsgateway.py, line 27
> > <https://reviews.apache.org/r/32731/diff/1/?file=912231#file912231line27>
> >
> > This only works on Linux. Please include Jayush and Florian Barca in the code review.
Windows is not support. A different bug BUG-33975 is to disable NFS Gateway from Ambari UI on Windnows.
> On April 1, 2015, 5:56 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_nfsgateway.py, line 31
> > <https://reviews.apache.org/r/32731/diff/1/?file=912231#file912231line31>
> >
> > We have methods named checked_call or call that execute processes and also log stdout. Preferable to use them.
Using shell.call now.
- Brandon
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32731/#review78552
-----------------------------------------------------------
On April 1, 2015, 5:41 p.m., Brandon Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32731/
> -----------------------------------------------------------
>
> (Updated April 1, 2015, 5:41 p.m.)
>
>
> Review request for Ambari and Alejandro Fernandez.
>
>
> Bugs: AMBARI-10280
> https://issues.apache.org/jira/browse/AMBARI-10280
>
>
> Repository: ambari
>
>
> Description
> -------
>
> AMBARI-10280 Need to check if rpcbind or portmap is started before starting NFS Gateway
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_nfsgateway.py e908ecf
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params.py 7061057
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/status_params.py c7c5325
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/utils.py 0b9af6b
>
> Diff: https://reviews.apache.org/r/32731/diff/
>
>
> Testing
> -------
>
> Manually tested it on VM.
> The python unit test test_nfsgateway.py failed because now NFS is started by root not hdfs anymore.
>
>
> Thanks,
>
> Brandon Li
>
>
Re: Review Request 32731: AMBARI-10280 Need to check if rpcbind or
portmap is started before starting NFS Gateway
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32731/#review78552
-----------------------------------------------------------
Please resubmit once unit tests pass.
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_nfsgateway.py
<https://reviews.apache.org/r/32731/#comment127400>
Should use pythonic_function_names().
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_nfsgateway.py
<https://reviews.apache.org/r/32731/#comment127401>
Replace all prints with logger statements
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_nfsgateway.py
<https://reviews.apache.org/r/32731/#comment127403>
This only works on Linux. Please include Jayush and Florian Barca in the code review.
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_nfsgateway.py
<https://reviews.apache.org/r/32731/#comment127405>
We have methods named checked_call or call that execute processes and also log stdout. Preferable to use them.
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_nfsgateway.py
<https://reviews.apache.org/r/32731/#comment127406>
Need to import Fail.
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_nfsgateway.py
<https://reviews.apache.org/r/32731/#comment127407>
May want to add python comments as to why this process needs to be started as root, based on the bug in Linux, and when it can be removed to use HDFS user instead.
- Alejandro Fernandez
On April 1, 2015, 5:41 p.m., Brandon Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32731/
> -----------------------------------------------------------
>
> (Updated April 1, 2015, 5:41 p.m.)
>
>
> Review request for Ambari and Alejandro Fernandez.
>
>
> Bugs: AMBARI-10280
> https://issues.apache.org/jira/browse/AMBARI-10280
>
>
> Repository: ambari
>
>
> Description
> -------
>
> AMBARI-10280 Need to check if rpcbind or portmap is started before starting NFS Gateway
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_nfsgateway.py e908ecf
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params.py 7061057
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/status_params.py c7c5325
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/utils.py 0b9af6b
>
> Diff: https://reviews.apache.org/r/32731/diff/
>
>
> Testing
> -------
>
> Manually tested it on VM.
> The python unit test test_nfsgateway.py failed because now NFS is started by root not hdfs anymore.
>
>
> Thanks,
>
> Brandon Li
>
>