You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/05/16 07:35:40 UTC

[GitHub] [superset] villebro commented on a diff in pull request #20071: chore: Fix and enhance Applitools workflows

villebro commented on code in PR #20071:
URL: https://github.com/apache/superset/pull/20071#discussion_r873384133


##########
.github/workflows/superset-applitool-cypress.yml:
##########
@@ -36,7 +36,12 @@ jobs:
         ports:
           - 16379:6379
     steps:
-      - uses: actions/checkout@v3
+      - name: "Checkout ${{ github.ref }} ( ${{ github.sha }} )"
+        uses: actions/checkout@v3

Review Comment:
   bycatch: we should probably also bump all `actions/checkout@v2` to `actions/checkout@v3` (also in that same follow-up).



##########
.github/workflows/superset-applitool-cypress.yml:
##########
@@ -6,7 +6,7 @@ on:
 
 jobs:
   cypress-applitools:
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-20.04

Review Comment:
   We should probably pin all workflows to `ubuntu-20.04` (let's do it in a follow-up)



##########
.github/workflows/superset-applitool-cypress.yml:
##########
@@ -59,8 +64,8 @@ jobs:
         uses: ./.github/actions/cached-dependencies
         with:
           run: testdata
-      - name: Set up Node.js
-        uses: actions/setup-node@v3.1.1
+      - name: Setup Node.js
+        uses: actions/setup-node@v2

Review Comment:
   Same here - I'd rather use `actions/setup-node@v3` as it uses Node 16 (https://github.com/actions/setup-node/releases/tag/v3.0.0) - any reason why we're tagging `v2`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org