You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@carbondata.apache.org by GitBox <gi...@apache.org> on 2021/06/23 07:53:56 UTC

[GitHub] [carbondata] akkio-97 opened a new pull request #4162: [CARBONDATA-4210] Handle 3.1 parsing failures related to alter complex types

akkio-97 opened a new pull request #4162:
URL: https://github.com/apache/carbondata/pull/4162


    ### Why is this PR needed?
    
    
    ### What changes were proposed in this PR?
   
       
    ### Does this PR introduce any user interface change?
    - No
    - Yes. (please explain the change and update document)
   
    ### Is any new testcase added?
    - No
    - Yes
   
       
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [carbondata] vikramahuja1001 commented on a change in pull request #4162: [CARBONDATA-4210] Handle 3.1 parsing failures related to alter complex types

Posted by GitBox <gi...@apache.org>.
vikramahuja1001 commented on a change in pull request #4162:
URL: https://github.com/apache/carbondata/pull/4162#discussion_r657011202



##########
File path: integration/spark/pom.xml
##########
@@ -646,6 +646,9 @@
     </profile>
     <profile>
       <id>spark-3.1</id>
+      <activation>

Review comment:
       revert these changes




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [carbondata] brijoobopanna commented on pull request #4162: [CARBONDATA-4210] Handle 3.1 parsing failures related to alter complex types

Posted by GitBox <gi...@apache.org>.
brijoobopanna commented on pull request #4162:
URL: https://github.com/apache/carbondata/pull/4162#issuecomment-874645774


   retest this please
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4162: [CARBONDATA-4210] Handle 3.1 parsing failures related to alter complex types

Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4162:
URL: https://github.com/apache/carbondata/pull/4162#issuecomment-875267604


   Build Failed  with Spark 2.4.5, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_2.4.5/3913/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4162: [CARBONDATA-4210] Handle 3.1 parsing failures related to alter complex types

Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4162:
URL: https://github.com/apache/carbondata/pull/4162#issuecomment-866938369


   Build Failed  with Spark 2.4.5, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_2.4.5/3874/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [carbondata] vikramahuja1001 commented on a change in pull request #4162: [CARBONDATA-4210] Handle 3.1 parsing failures related to alter complex types

Posted by GitBox <gi...@apache.org>.
vikramahuja1001 commented on a change in pull request #4162:
URL: https://github.com/apache/carbondata/pull/4162#discussion_r657011422



##########
File path: pom.xml
##########
@@ -126,11 +126,15 @@
     <hadoop.version>2.7.2</hadoop.version>

Review comment:
       revert all changes in this class




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4162: [CARBONDATA-4210] Handle 3.1 parsing failures related to alter complex types

Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4162:
URL: https://github.com/apache/carbondata/pull/4162#issuecomment-866937803


   Build Failed  with Spark 2.3.4, Please check CI http://121.244.95.60:12602/job/ApacheCarbonPRBuilder2.3/5619/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4162: [CARBONDATA-4210] Handle 3.1 parsing failures related to alter complex types

Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4162:
URL: https://github.com/apache/carbondata/pull/4162#issuecomment-868314892


   Build Failed  with Spark 2.3.4, Please check CI http://121.244.95.60:12602/job/ApacheCarbonPRBuilder2.3/5632/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4162: [CARBONDATA-4210] Handle 3.1 parsing failures related to alter complex types

Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4162:
URL: https://github.com/apache/carbondata/pull/4162#issuecomment-874761870


   Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12602/job/ApacheCarbonPRBuilder2.3/5652/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [carbondata] akkio-97 commented on a change in pull request #4162: [CARBONDATA-4210] Handle 3.1 parsing failures related to alter complex types

Posted by GitBox <gi...@apache.org>.
akkio-97 commented on a change in pull request #4162:
URL: https://github.com/apache/carbondata/pull/4162#discussion_r657015458



##########
File path: pom.xml
##########
@@ -126,11 +126,15 @@
     <hadoop.version>2.7.2</hadoop.version>

Review comment:
       done




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [carbondata] kunal642 commented on pull request #4162: [CARBONDATA-4210] Handle 3.1 parsing failures related to alter complex types

Posted by GitBox <gi...@apache.org>.
kunal642 commented on pull request #4162:
URL: https://github.com/apache/carbondata/pull/4162#issuecomment-878210678


   LGTM


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4162: [CARBONDATA-4210] Handle 3.1 parsing failures related to alter complex types

Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4162:
URL: https://github.com/apache/carbondata/pull/4162#issuecomment-867407210


   Build Failed  with Spark 3.1, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_3.1/29/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4162: [CARBONDATA-4210] Handle 3.1 parsing failures related to alter complex types

Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4162:
URL: https://github.com/apache/carbondata/pull/4162#issuecomment-866705590


   Build Failed  with Spark 2.3.4, Please check CI http://121.244.95.60:12602/job/ApacheCarbonPRBuilder2.3/5618/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [carbondata] ydvpankaj99 commented on pull request #4162: [CARBONDATA-4210] Handle 3.1 parsing failures related to alter complex types

Posted by GitBox <gi...@apache.org>.
ydvpankaj99 commented on pull request #4162:
URL: https://github.com/apache/carbondata/pull/4162#issuecomment-869370757


   retest this please


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4162: [CARBONDATA-4210] Handle 3.1 parsing failures related to alter complex types

Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4162:
URL: https://github.com/apache/carbondata/pull/4162#issuecomment-867538452


   Build Failed  with Spark 2.3.4, Please check CI http://121.244.95.60:12602/job/ApacheCarbonPRBuilder2.3/5628/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4162: [CARBONDATA-4210] Handle 3.1 parsing failures related to alter complex types

Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4162:
URL: https://github.com/apache/carbondata/pull/4162#issuecomment-867403047


   Build Failed  with Spark 2.4.5, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_2.4.5/3882/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4162: [CARBONDATA-4210] Handle 3.1 parsing failures related to alter complex types

Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4162:
URL: https://github.com/apache/carbondata/pull/4162#issuecomment-869474269


   Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12602/job/ApacheCarbonPRBuilder2.3/5641/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [carbondata] akkio-97 commented on pull request #4162: [CARBONDATA-4210] Handle 3.1 parsing failures related to alter complex types

Posted by GitBox <gi...@apache.org>.
akkio-97 commented on pull request #4162:
URL: https://github.com/apache/carbondata/pull/4162#issuecomment-867329252


   retest this please


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4162: [CARBONDATA-4210] Handle 3.1 parsing failures related to alter complex types

Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4162:
URL: https://github.com/apache/carbondata/pull/4162#issuecomment-874652440


   Build Failed  with Spark 2.4.5, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_2.4.5/3909/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [carbondata] akkio-97 commented on pull request #4162: [CARBONDATA-4210] Handle 3.1 parsing failures related to alter complex types

Posted by GitBox <gi...@apache.org>.
akkio-97 commented on pull request #4162:
URL: https://github.com/apache/carbondata/pull/4162#issuecomment-875399805


   retest this please


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4162: [CARBONDATA-4210] Handle 3.1 parsing failures related to alter complex types

Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4162:
URL: https://github.com/apache/carbondata/pull/4162#issuecomment-875280863


   Build Success with Spark 3.1, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_3.1/60/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4162: [CARBONDATA-4210] Handle 3.1 parsing failures related to alter complex types

Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4162:
URL: https://github.com/apache/carbondata/pull/4162#issuecomment-874652440






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4162: [CARBONDATA-4210] Handle 3.1 parsing failures related to alter complex types

Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4162:
URL: https://github.com/apache/carbondata/pull/4162#issuecomment-866941432


   Build Failed  with Spark 3.1, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_3.1/21/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4162: [CARBONDATA-4210] Handle 3.1 parsing failures related to alter complex types

Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4162:
URL: https://github.com/apache/carbondata/pull/4162#issuecomment-868320516


   Build Failed  with Spark 3.1, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_3.1/36/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4162: [CARBONDATA-4210] Handle 3.1 parsing failures related to alter complex types

Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4162:
URL: https://github.com/apache/carbondata/pull/4162#issuecomment-875528453


   Build Failed  with Spark 2.4.5, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_2.4.5/3921/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [carbondata] akkio-97 commented on pull request #4162: [CARBONDATA-4210] Handle 3.1 parsing failures related to alter complex types

Posted by GitBox <gi...@apache.org>.
akkio-97 commented on pull request #4162:
URL: https://github.com/apache/carbondata/pull/4162#issuecomment-866732161


   retest this please


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [carbondata] akkio-97 commented on pull request #4162: [CARBONDATA-4210] Handle 3.1 parsing failures related to alter complex types

Posted by GitBox <gi...@apache.org>.
akkio-97 commented on pull request #4162:
URL: https://github.com/apache/carbondata/pull/4162#issuecomment-878085142


   retest this please


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4162: [CARBONDATA-4210] Handle 3.1 parsing failures related to alter complex types

Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4162:
URL: https://github.com/apache/carbondata/pull/4162#issuecomment-875521531


   Build Success with Spark 3.1, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_3.1/69/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [carbondata] ydvpankaj99 commented on pull request #4162: [CARBONDATA-4210] Handle 3.1 parsing failures related to alter complex types

Posted by GitBox <gi...@apache.org>.
ydvpankaj99 commented on pull request #4162:
URL: https://github.com/apache/carbondata/pull/4162#issuecomment-868256052


   retest this please


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4162: [CARBONDATA-4210] Handle 3.1 parsing failures related to alter complex types

Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4162:
URL: https://github.com/apache/carbondata/pull/4162#issuecomment-869469841


   Build Failed  with Spark 2.4.5, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_2.4.5/3898/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4162: [CARBONDATA-4210] Handle 3.1 parsing failures related to alter complex types

Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4162:
URL: https://github.com/apache/carbondata/pull/4162#issuecomment-866718310


   Build Failed  with Spark 3.1, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_3.1/20/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [carbondata] brijoobopanna commented on pull request #4162: [CARBONDATA-4210] Handle 3.1 parsing failures related to alter complex types

Posted by GitBox <gi...@apache.org>.
brijoobopanna commented on pull request #4162:
URL: https://github.com/apache/carbondata/pull/4162#issuecomment-874645774


   retest this please
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4162: [CARBONDATA-4210] Handle 3.1 parsing failures related to alter complex types

Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4162:
URL: https://github.com/apache/carbondata/pull/4162#issuecomment-866709083


   Build Failed  with Spark 2.4.5, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_2.4.5/3873/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [carbondata] asfgit closed pull request #4162: [CARBONDATA-4210] Handle 3.1 parsing failures related to alter complex types

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #4162:
URL: https://github.com/apache/carbondata/pull/4162


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4162: [CARBONDATA-4210] Handle 3.1 parsing failures related to alter complex types

Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4162:
URL: https://github.com/apache/carbondata/pull/4162#issuecomment-878187103






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4162: [CARBONDATA-4210] Handle 3.1 parsing failures related to alter complex types

Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4162:
URL: https://github.com/apache/carbondata/pull/4162#issuecomment-867539197


   Build Failed  with Spark 2.4.5, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_2.4.5/3885/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4162: [CARBONDATA-4210] Handle 3.1 parsing failures related to alter complex types

Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4162:
URL: https://github.com/apache/carbondata/pull/4162#issuecomment-869480392


   Build Success with Spark 3.1, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_3.1/45/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4162: [CARBONDATA-4210] Handle 3.1 parsing failures related to alter complex types

Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4162:
URL: https://github.com/apache/carbondata/pull/4162#issuecomment-875522504


   Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12602/job/ApacheCarbonPRBuilder2.3/5665/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [carbondata] ydvpankaj99 commented on pull request #4162: [CARBONDATA-4210] Handle 3.1 parsing failures related to alter complex types

Posted by GitBox <gi...@apache.org>.
ydvpankaj99 commented on pull request #4162:
URL: https://github.com/apache/carbondata/pull/4162#issuecomment-867426233


   retest this please


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [carbondata] akkio-97 commented on a change in pull request #4162: [CARBONDATA-4210] Handle 3.1 parsing failures related to alter complex types

Posted by GitBox <gi...@apache.org>.
akkio-97 commented on a change in pull request #4162:
URL: https://github.com/apache/carbondata/pull/4162#discussion_r657031414



##########
File path: integration/spark/src/main/scala/org/apache/spark/sql/parser/CarbonSparkSqlParserUtil.scala
##########
@@ -447,21 +447,31 @@ object CarbonSparkSqlParserUtil {
       table: String,
       columnName: String,
       columnNameCopy: String,
-      dataType: String,
+      dataType: Option[String],
       values: Option[List[(Int, Int)]],
-      comment: Option[String]
+      comment: Option[String],
+      complexChild: Option[Field]
   ): CarbonAlterTableColRenameDataTypeChangeCommand = {
     val isColumnRename = !columnName.equalsIgnoreCase(columnNameCopy)
-    val alterTableColRenameAndDataTypeChangeModel =
+    val alterTableColRenameAndDataTypeChangeModel = if (!dataType.equals(None)) {

Review comment:
       done




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [carbondata] ydvpankaj99 commented on pull request #4162: [CARBONDATA-4210] Handle 3.1 parsing failures related to alter complex types

Posted by GitBox <gi...@apache.org>.
ydvpankaj99 commented on pull request #4162:
URL: https://github.com/apache/carbondata/pull/4162#issuecomment-875213197


   retest this please


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [carbondata] akkio-97 commented on a change in pull request #4162: [CARBONDATA-4210] Handle 3.1 parsing failures related to alter complex types

Posted by GitBox <gi...@apache.org>.
akkio-97 commented on a change in pull request #4162:
URL: https://github.com/apache/carbondata/pull/4162#discussion_r657013051



##########
File path: integration/spark/pom.xml
##########
@@ -646,6 +646,9 @@
     </profile>
     <profile>
       <id>spark-3.1</id>
+      <activation>

Review comment:
       done




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4162: [CARBONDATA-4210] Handle 3.1 parsing failures related to alter complex types

Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4162:
URL: https://github.com/apache/carbondata/pull/4162#issuecomment-875271861


   Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12602/job/ApacheCarbonPRBuilder2.3/5657/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4162: [CARBONDATA-4210] Handle 3.1 parsing failures related to alter complex types

Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4162:
URL: https://github.com/apache/carbondata/pull/4162#issuecomment-867396846


   Build Failed  with Spark 2.3.4, Please check CI http://121.244.95.60:12602/job/ApacheCarbonPRBuilder2.3/5625/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4162: [CARBONDATA-4210] Handle 3.1 parsing failures related to alter complex types

Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4162:
URL: https://github.com/apache/carbondata/pull/4162#issuecomment-874653019


   Build Failed  with Spark 3.1, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_3.1/56/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4162: [CARBONDATA-4210] Handle 3.1 parsing failures related to alter complex types

Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4162:
URL: https://github.com/apache/carbondata/pull/4162#issuecomment-868317040


   Build Failed  with Spark 2.4.5, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_2.4.5/3889/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4162: [CARBONDATA-4210] Handle 3.1 parsing failures related to alter complex types

Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4162:
URL: https://github.com/apache/carbondata/pull/4162#issuecomment-867539933


   Build Failed  with Spark 3.1, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_3.1/32/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [carbondata] vikramahuja1001 commented on a change in pull request #4162: [CARBONDATA-4210] Handle 3.1 parsing failures related to alter complex types

Posted by GitBox <gi...@apache.org>.
vikramahuja1001 commented on a change in pull request #4162:
URL: https://github.com/apache/carbondata/pull/4162#discussion_r657013330



##########
File path: integration/spark/src/main/scala/org/apache/spark/sql/parser/CarbonSparkSqlParserUtil.scala
##########
@@ -447,21 +447,31 @@ object CarbonSparkSqlParserUtil {
       table: String,
       columnName: String,
       columnNameCopy: String,
-      dataType: String,
+      dataType: Option[String],
       values: Option[List[(Int, Int)]],
-      comment: Option[String]
+      comment: Option[String],
+      complexChild: Option[Field]
   ): CarbonAlterTableColRenameDataTypeChangeCommand = {
     val isColumnRename = !columnName.equalsIgnoreCase(columnNameCopy)
-    val alterTableColRenameAndDataTypeChangeModel =
+    val alterTableColRenameAndDataTypeChangeModel = if (!dataType.equals(None)) {

Review comment:
       instead of duplicating the whole thing, just put the columnName/columnNameCopy and datatype.get.tolowerCase/complexChild to 2 variables depending on the conditions and use them, because most of the variables are same.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org