You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/06/07 20:43:38 UTC

[GitHub] [beam] ibzib commented on a change in pull request #14955: [BEAM-11811] Disallow num_workers > max_num_workers for Go Dataflow runner

ibzib commented on a change in pull request #14955:
URL: https://github.com/apache/beam/pull/14955#discussion_r646926411



##########
File path: sdks/go/pkg/beam/runners/dataflow/dataflowlib/job.go
##########
@@ -345,5 +346,14 @@ func validateWorkerSettings(ctx context.Context, opts *JobOptions) error {
 		opts.WorkerZone = opts.Zone
 		opts.Zone = ""
 	}
+
+	numWorkers := opts.NumWorkers
+	maxNumWorkers := opts.MaxNumWorkers
+	if numWorkers < 0 {

Review comment:
       Should we should check maxNumWorkers >= 0 too?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org