About style information on skin/commons/xslt/html/tab2menu.xsl

[Juan Jose Pablos <ch...@che-che.com>]

Hi,

In order to change the selected color for the tab, i needed to change 
the xsl file on the commons skin.

¿Style information is suposed to be in the commons xsl file?


on  skin/commons/xslt/html/tab2menu.xsl:

   <xsl:template name="base-selected">
..
..
       <font color="#000000">
         <xsl:value-of select="@label"/>
       </font>
..

   </xsl:template>

Same for the base-not-selected. template.

I remove the font tags, and I added a class="base-selected" to the <a> tag.

I added these entries on the page.css style info

div.tab a.base-selected { color: #000000; }
div.tab a.base-not-selected { font: Arial, Helvetica, Sans-serif; }

This has the same effect, but allow to change the style on the css 
instead of the xsl file.


would you agree with me that this is an enhancement and that I should 
open a issue?

Re: About style information on skin/commons/xslt/html/tab2menu.xsl

[Juan Jose Pablos <ch...@che-che.com>]

Jeff,


> Usually, skins will override all the *.xsl files, even if only to define
> the CSS class names.  However it wouldn't hurt to define a standard set
> of class attributes in the common skin.  Patches welcome.

we could add a standard.css with all the classes in the template skin so 
, users could overwirte the style there.

I created an issue for this FOR-34

Cheche

Re: About style information on skin/commons/xslt/html/tab2menu.xsl

[Jeff Turner <je...@apache.org>]

On Fri, Mar 28, 2003 at 06:34:42PM +0100, Juan Jose Pablos wrote:
> Hi,
> 
> In order to change the selected color for the tab, i needed to change 
> the xsl file on the commons skin.
> 
> ¿Style information is suposed to be in the commons xsl file?
> 
> 
> on  skin/commons/xslt/html/tab2menu.xsl:
> 
>   <xsl:template name="base-selected">
> ..
> ..
>       <font color="#000000">
>         <xsl:value-of select="@label"/>
>       </font>
> ..
> 
>   </xsl:template>
> 
> Same for the base-not-selected. template.
> 
> I remove the font tags, and I added a class="base-selected" to the <a> tag.
> 
> I added these entries on the page.css style info
> 
> div.tab a.base-selected { color: #000000; }
> div.tab a.base-not-selected { font: Arial, Helvetica, Sans-serif; }
> 
> This has the same effect, but allow to change the style on the css 
> instead of the xsl file.

Usually, skins will override all the *.xsl files, even if only to define
the CSS class names.  However it wouldn't hurt to define a standard set
of class attributes in the common skin.  Patches welcome.


--Jeff