You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/02/28 18:49:40 UTC
[GitHub] [superset] ktmud opened a new pull request #13374: chore: convert chartReducer to TypeScript
ktmud opened a new pull request #13374:
URL: https://github.com/apache/superset/pull/13374
### SUMMARY
Follow up of #13221 , converting `chartReducer` to TypeScript.
Other related components waiting to be converted:
- [ ] `chartAction`
- [ ] `ChartRenderer`
- [ ] `exploreReducer`
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A
### TEST PLAN
CI should pass, all Explore page functionalities should work as before
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [x] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud merged pull request #13374: chore: convert chartReducer to TypeScript
Posted by GitBox <gi...@apache.org>.
ktmud merged pull request #13374:
URL: https://github.com/apache/superset/pull/13374
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13374: chore: convert chartReducer to TypeScript
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13374:
URL: https://github.com/apache/superset/pull/13374#issuecomment-787504724
# [Codecov](https://codecov.io/gh/apache/superset/pull/13374?src=pr&el=h1) Report
> Merging [#13374](https://codecov.io/gh/apache/superset/pull/13374?src=pr&el=desc) (167af5c) into [master](https://codecov.io/gh/apache/superset/commit/3c62069bbb0d07ff0194fbb159c2e04fd98fafc2?el=desc) (3c62069) will **decrease** coverage by `4.31%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/13374?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13374 +/- ##
==========================================
- Coverage 77.09% 72.77% -4.32%
==========================================
Files 898 597 -301
Lines 45711 21272 -24439
Branches 5495 5498 +3
==========================================
- Hits 35241 15481 -19760
+ Misses 10344 5665 -4679
Partials 126 126
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `57.68% <100.00%> (+0.05%)` | :arrow_up: |
| hive | `?` | |
| javascript | `62.56% <66.66%> (-0.01%)` | :arrow_down: |
| mysql | `?` | |
| postgres | `?` | |
| presto | `?` | |
| python | `?` | |
| sqlite | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13374?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/chart/chartReducer.ts](https://codecov.io/gh/apache/superset/pull/13374/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0UmVkdWNlci50cw==) | `64.38% <100.00%> (ø)` | |
| [.../src/explore/components/ControlPanelsContainer.tsx](https://codecov.io/gh/apache/superset/pull/13374/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9Db250cm9sUGFuZWxzQ29udGFpbmVyLnRzeA==) | `97.27% <100.00%> (+0.07%)` | :arrow_up: |
| [...t-frontend/src/explore/reducers/getInitialState.ts](https://codecov.io/gh/apache/superset/pull/13374/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvZ2V0SW5pdGlhbFN0YXRlLnRz) | `100.00% <100.00%> (ø)` | |
| [...set-frontend/src/dashboard/util/getDropPosition.js](https://codecov.io/gh/apache/superset/pull/13374/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERyb3BQb3NpdGlvbi5qcw==) | `90.90% <0.00%> (-1.52%)` | :arrow_down: |
| [superset/tasks/celery\_app.py](https://codecov.io/gh/apache/superset/pull/13374/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3MvY2VsZXJ5X2FwcC5weQ==) | | |
| [superset/legacy.py](https://codecov.io/gh/apache/superset/pull/13374/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbGVnYWN5LnB5) | | |
| [superset/db\_engine\_specs/db2.py](https://codecov.io/gh/apache/superset/pull/13374/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2RiMi5weQ==) | | |
| [superset/views/redirects.py](https://codecov.io/gh/apache/superset/pull/13374/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvcmVkaXJlY3RzLnB5) | | |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/13374/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | | |
| ... and [297 more](https://codecov.io/gh/apache/superset/pull/13374/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13374?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13374?src=pr&el=footer). Last update [8f09c62...2dc906b](https://codecov.io/gh/apache/superset/pull/13374?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13374: chore: convert chartReducer to TypeScript
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13374:
URL: https://github.com/apache/superset/pull/13374#issuecomment-787504724
# [Codecov](https://codecov.io/gh/apache/superset/pull/13374?src=pr&el=h1) Report
> Merging [#13374](https://codecov.io/gh/apache/superset/pull/13374?src=pr&el=desc) (fd92652) into [master](https://codecov.io/gh/apache/superset/commit/08183dfe57b7c4d01c745528baa670c459a51445?el=desc) (08183df) will **increase** coverage by `4.83%`.
> The diff coverage is `68.96%`.
[](https://codecov.io/gh/apache/superset/pull/13374?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13374 +/- ##
==========================================
+ Coverage 72.13% 76.96% +4.83%
==========================================
Files 898 898
Lines 45681 45725 +44
Branches 5495 5423 -72
==========================================
+ Hits 32952 35193 +2241
+ Misses 12517 10403 -2114
+ Partials 212 129 -83
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `57.09% <100.00%> (?)` | |
| hive | `79.97% <ø> (?)` | |
| javascript | `62.75% <48.27%> (+0.17%)` | :arrow_up: |
| mysql | `80.30% <ø> (ø)` | |
| postgres | `80.34% <ø> (ø)` | |
| python | `80.73% <ø> (+0.29%)` | :arrow_up: |
| sqlite | `79.96% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13374?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...rset-frontend/src/components/ButtonGroup/index.tsx](https://codecov.io/gh/apache/superset/pull/13374/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQnV0dG9uR3JvdXAvaW5kZXgudHN4) | `100.00% <ø> (ø)` | |
| [...et-frontend/src/components/ErrorBoundary/index.jsx](https://codecov.io/gh/apache/superset/pull/13374/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JCb3VuZGFyeS9pbmRleC5qc3g=) | `95.45% <ø> (ø)` | |
| [...-frontend/src/components/Select/Select.stories.tsx](https://codecov.io/gh/apache/superset/pull/13374/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L1NlbGVjdC5zdG9yaWVzLnRzeA==) | `0.00% <0.00%> (ø)` | |
| [superset-frontend/src/components/Select/Select.tsx](https://codecov.io/gh/apache/superset/pull/13374/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L1NlbGVjdC50c3g=) | `90.81% <ø> (ø)` | |
| [superset-frontend/src/components/Select/styles.tsx](https://codecov.io/gh/apache/superset/pull/13374/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L3N0eWxlcy50c3g=) | `86.30% <ø> (+24.65%)` | :arrow_up: |
| [...et-frontend/src/components/Timer/Timer.stories.tsx](https://codecov.io/gh/apache/superset/pull/13374/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGltZXIvVGltZXIuc3Rvcmllcy50c3g=) | `0.00% <0.00%> (ø)` | |
| [superset-frontend/src/components/Timer/index.tsx](https://codecov.io/gh/apache/superset/pull/13374/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGltZXIvaW5kZXgudHN4) | `95.83% <ø> (ø)` | |
| [superset-frontend/src/chart/Chart.jsx](https://codecov.io/gh/apache/superset/pull/13374/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0LmpzeA==) | `64.81% <100.00%> (+17.64%)` | :arrow_up: |
| [superset-frontend/src/chart/chartReducer.ts](https://codecov.io/gh/apache/superset/pull/13374/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0UmVkdWNlci50cw==) | `64.38% <100.00%> (ø)` | |
| [superset-frontend/src/components/Select/index.ts](https://codecov.io/gh/apache/superset/pull/13374/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L2luZGV4LnRz) | `100.00% <100.00%> (ø)` | |
| ... and [220 more](https://codecov.io/gh/apache/superset/pull/13374/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13374?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13374?src=pr&el=footer). Last update [391d909...fd92652](https://codecov.io/gh/apache/superset/pull/13374?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13374: chore: convert chartReducer to TypeScript
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13374:
URL: https://github.com/apache/superset/pull/13374#issuecomment-787504724
# [Codecov](https://codecov.io/gh/apache/superset/pull/13374?src=pr&el=h1) Report
> Merging [#13374](https://codecov.io/gh/apache/superset/pull/13374?src=pr&el=desc) (45a133c) into [master](https://codecov.io/gh/apache/superset/commit/08183dfe57b7c4d01c745528baa670c459a51445?el=desc) (08183df) will **increase** coverage by `0.81%`.
> The diff coverage is `68.96%`.
[](https://codecov.io/gh/apache/superset/pull/13374?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13374 +/- ##
==========================================
+ Coverage 72.13% 72.94% +0.81%
==========================================
Files 898 597 -301
Lines 45681 21275 -24406
Branches 5495 5423 -72
==========================================
- Hits 32952 15520 -17432
+ Misses 12517 5628 -6889
+ Partials 212 127 -85
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `57.66% <100.00%> (?)` | |
| javascript | `62.75% <48.27%> (+0.17%)` | :arrow_up: |
| mysql | `?` | |
| postgres | `?` | |
| python | `?` | |
| sqlite | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13374?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...rset-frontend/src/components/ButtonGroup/index.tsx](https://codecov.io/gh/apache/superset/pull/13374/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQnV0dG9uR3JvdXAvaW5kZXgudHN4) | `100.00% <ø> (ø)` | |
| [...et-frontend/src/components/ErrorBoundary/index.jsx](https://codecov.io/gh/apache/superset/pull/13374/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JCb3VuZGFyeS9pbmRleC5qc3g=) | `95.45% <ø> (ø)` | |
| [...-frontend/src/components/Select/Select.stories.tsx](https://codecov.io/gh/apache/superset/pull/13374/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L1NlbGVjdC5zdG9yaWVzLnRzeA==) | `0.00% <0.00%> (ø)` | |
| [superset-frontend/src/components/Select/Select.tsx](https://codecov.io/gh/apache/superset/pull/13374/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L1NlbGVjdC50c3g=) | `90.81% <ø> (ø)` | |
| [superset-frontend/src/components/Select/styles.tsx](https://codecov.io/gh/apache/superset/pull/13374/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L3N0eWxlcy50c3g=) | `86.30% <ø> (+24.65%)` | :arrow_up: |
| [...et-frontend/src/components/Timer/Timer.stories.tsx](https://codecov.io/gh/apache/superset/pull/13374/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGltZXIvVGltZXIuc3Rvcmllcy50c3g=) | `0.00% <0.00%> (ø)` | |
| [superset-frontend/src/components/Timer/index.tsx](https://codecov.io/gh/apache/superset/pull/13374/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGltZXIvaW5kZXgudHN4) | `95.83% <ø> (ø)` | |
| [superset-frontend/src/chart/Chart.jsx](https://codecov.io/gh/apache/superset/pull/13374/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0LmpzeA==) | `64.81% <100.00%> (+17.64%)` | :arrow_up: |
| [superset-frontend/src/chart/chartReducer.ts](https://codecov.io/gh/apache/superset/pull/13374/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0UmVkdWNlci50cw==) | `64.38% <100.00%> (ø)` | |
| [superset-frontend/src/components/Select/index.ts](https://codecov.io/gh/apache/superset/pull/13374/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L2luZGV4LnRz) | `100.00% <100.00%> (ø)` | |
| ... and [519 more](https://codecov.io/gh/apache/superset/pull/13374/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13374?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13374?src=pr&el=footer). Last update [8f09c62...2dc906b](https://codecov.io/gh/apache/superset/pull/13374?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud commented on a change in pull request #13374: chore: convert chartReducer to TypeScript
Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #13374:
URL: https://github.com/apache/superset/pull/13374#discussion_r584341845
##########
File path: superset-frontend/src/chart/chartReducer.ts
##########
@@ -134,7 +143,7 @@ export default function chartReducer(charts = {}, action) {
}
const annotationQuery = {
...state.annotationQuery,
- [action.annotation.name]: action.queryRequest,
+ [action.annotation.name]: action.queryController,
Review comment:
Bycatch by TypeScript: it seems the `ANNOTATION_QUERY_STARTED` is supposed to cancel previous annotation queries, but it used the wrong action prop. The source of the action is here:
https://github.com/apache/superset/blob/6731cd0be6852c890a5e856e79470d08eb760437/superset-frontend/src/chart/chartAction.js#L97
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13374: chore: convert chartReducer to TypeScript
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13374:
URL: https://github.com/apache/superset/pull/13374#issuecomment-787504724
# [Codecov](https://codecov.io/gh/apache/superset/pull/13374?src=pr&el=h1) Report
> Merging [#13374](https://codecov.io/gh/apache/superset/pull/13374?src=pr&el=desc) (fd92652) into [master](https://codecov.io/gh/apache/superset/commit/08183dfe57b7c4d01c745528baa670c459a51445?el=desc) (08183df) will **decrease** coverage by `4.21%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/13374?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13374 +/- ##
==========================================
- Coverage 72.13% 67.91% -4.22%
==========================================
Files 898 794 -104
Lines 45681 40335 -5346
Branches 5495 4023 -1472
==========================================
- Hits 32952 27395 -5557
- Misses 12517 12940 +423
+ Partials 212 0 -212
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `48.65% <100.00%> (?)` | |
| javascript | `?` | |
| mysql | `80.30% <ø> (ø)` | |
| postgres | `80.34% <ø> (ø)` | |
| python | `80.43% <ø> (ø)` | |
| sqlite | `79.96% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13374?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...rset-frontend/src/components/ButtonGroup/index.tsx](https://codecov.io/gh/apache/superset/pull/13374/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQnV0dG9uR3JvdXAvaW5kZXgudHN4) | `100.00% <ø> (ø)` | |
| [...et-frontend/src/components/ErrorBoundary/index.jsx](https://codecov.io/gh/apache/superset/pull/13374/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JCb3VuZGFyeS9pbmRleC5qc3g=) | `50.00% <ø> (ø)` | |
| [superset-frontend/src/components/Select/Select.tsx](https://codecov.io/gh/apache/superset/pull/13374/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L1NlbGVjdC50c3g=) | `88.50% <ø> (ø)` | |
| [superset-frontend/src/components/Select/styles.tsx](https://codecov.io/gh/apache/superset/pull/13374/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L3N0eWxlcy50c3g=) | `93.75% <ø> (+32.10%)` | :arrow_up: |
| [superset-frontend/src/components/Timer/index.tsx](https://codecov.io/gh/apache/superset/pull/13374/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGltZXIvaW5kZXgudHN4) | `95.00% <ø> (ø)` | |
| [...onfigModal/FiltersConfigForm/FiltersConfigForm.tsx](https://codecov.io/gh/apache/superset/pull/13374/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0ZpbHRlcnNDb25maWdGb3JtLnRzeA==) | `12.76% <ø> (-72.95%)` | :arrow_down: |
| [...rset-frontend/src/explore/components/SaveModal.tsx](https://codecov.io/gh/apache/superset/pull/13374/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9TYXZlTW9kYWwudHN4) | `3.79% <ø> (-83.02%)` | :arrow_down: |
| [superset-frontend/src/chart/Chart.jsx](https://codecov.io/gh/apache/superset/pull/13374/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0LmpzeA==) | `62.96% <100.00%> (+15.79%)` | :arrow_up: |
| [superset-frontend/src/chart/chartReducer.ts](https://codecov.io/gh/apache/superset/pull/13374/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0UmVkdWNlci50cw==) | `55.22% <100.00%> (ø)` | |
| [.../src/explore/components/ControlPanelsContainer.tsx](https://codecov.io/gh/apache/superset/pull/13374/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9Db250cm9sUGFuZWxzQ29udGFpbmVyLnRzeA==) | `96.84% <100.00%> (+8.99%)` | :arrow_up: |
| ... and [520 more](https://codecov.io/gh/apache/superset/pull/13374/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13374?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13374?src=pr&el=footer). Last update [391d909...fd92652](https://codecov.io/gh/apache/superset/pull/13374?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13374: chore: convert chartReducer to TypeScript
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13374:
URL: https://github.com/apache/superset/pull/13374#issuecomment-787504724
# [Codecov](https://codecov.io/gh/apache/superset/pull/13374?src=pr&el=h1) Report
> Merging [#13374](https://codecov.io/gh/apache/superset/pull/13374?src=pr&el=desc) (fd92652) into [master](https://codecov.io/gh/apache/superset/commit/08183dfe57b7c4d01c745528baa670c459a51445?el=desc) (08183df) will **increase** coverage by `3.29%`.
> The diff coverage is `68.96%`.
[](https://codecov.io/gh/apache/superset/pull/13374?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13374 +/- ##
==========================================
+ Coverage 72.13% 75.42% +3.29%
==========================================
Files 898 898
Lines 45681 45724 +43
Branches 5495 5423 -72
==========================================
+ Hits 32952 34489 +1537
+ Misses 12517 11093 -1424
+ Partials 212 142 -70
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `48.65% <100.00%> (?)` | |
| javascript | `62.75% <48.27%> (+0.17%)` | :arrow_up: |
| mysql | `80.30% <ø> (ø)` | |
| postgres | `80.34% <ø> (ø)` | |
| python | `80.43% <ø> (ø)` | |
| sqlite | `79.96% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13374?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...rset-frontend/src/components/ButtonGroup/index.tsx](https://codecov.io/gh/apache/superset/pull/13374/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQnV0dG9uR3JvdXAvaW5kZXgudHN4) | `100.00% <ø> (ø)` | |
| [...et-frontend/src/components/ErrorBoundary/index.jsx](https://codecov.io/gh/apache/superset/pull/13374/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JCb3VuZGFyeS9pbmRleC5qc3g=) | `95.45% <ø> (ø)` | |
| [...-frontend/src/components/Select/Select.stories.tsx](https://codecov.io/gh/apache/superset/pull/13374/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L1NlbGVjdC5zdG9yaWVzLnRzeA==) | `0.00% <0.00%> (ø)` | |
| [superset-frontend/src/components/Select/Select.tsx](https://codecov.io/gh/apache/superset/pull/13374/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L1NlbGVjdC50c3g=) | `90.81% <ø> (ø)` | |
| [superset-frontend/src/components/Select/styles.tsx](https://codecov.io/gh/apache/superset/pull/13374/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L3N0eWxlcy50c3g=) | `86.30% <ø> (+24.65%)` | :arrow_up: |
| [...et-frontend/src/components/Timer/Timer.stories.tsx](https://codecov.io/gh/apache/superset/pull/13374/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGltZXIvVGltZXIuc3Rvcmllcy50c3g=) | `0.00% <0.00%> (ø)` | |
| [superset-frontend/src/components/Timer/index.tsx](https://codecov.io/gh/apache/superset/pull/13374/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGltZXIvaW5kZXgudHN4) | `95.83% <ø> (ø)` | |
| [superset-frontend/src/chart/Chart.jsx](https://codecov.io/gh/apache/superset/pull/13374/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0LmpzeA==) | `64.81% <100.00%> (+17.64%)` | :arrow_up: |
| [superset-frontend/src/chart/chartReducer.ts](https://codecov.io/gh/apache/superset/pull/13374/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0UmVkdWNlci50cw==) | `64.38% <100.00%> (ø)` | |
| [superset-frontend/src/components/Select/index.ts](https://codecov.io/gh/apache/superset/pull/13374/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L2luZGV4LnRz) | `100.00% <100.00%> (ø)` | |
| ... and [167 more](https://codecov.io/gh/apache/superset/pull/13374/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13374?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13374?src=pr&el=footer). Last update [391d909...fd92652](https://codecov.io/gh/apache/superset/pull/13374?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13374: chore: convert chartReducer to TypeScript
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13374:
URL: https://github.com/apache/superset/pull/13374#issuecomment-787504724
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #13374: chore: convert chartReducer to TypeScript
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #13374:
URL: https://github.com/apache/superset/pull/13374#issuecomment-787504724
# [Codecov](https://codecov.io/gh/apache/superset/pull/13374?src=pr&el=h1) Report
> Merging [#13374](https://codecov.io/gh/apache/superset/pull/13374?src=pr&el=desc) (167af5c) into [master](https://codecov.io/gh/apache/superset/commit/3c62069bbb0d07ff0194fbb159c2e04fd98fafc2?el=desc) (3c62069) will **decrease** coverage by `4.31%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/13374?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13374 +/- ##
==========================================
- Coverage 77.09% 72.77% -4.32%
==========================================
Files 898 597 -301
Lines 45711 21272 -24439
Branches 5495 5498 +3
==========================================
- Hits 35241 15481 -19760
+ Misses 10344 5665 -4679
Partials 126 126
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `57.68% <100.00%> (+0.05%)` | :arrow_up: |
| hive | `?` | |
| javascript | `62.56% <66.66%> (-0.01%)` | :arrow_down: |
| mysql | `?` | |
| postgres | `?` | |
| presto | `?` | |
| python | `?` | |
| sqlite | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13374?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/chart/chartReducer.ts](https://codecov.io/gh/apache/superset/pull/13374/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0UmVkdWNlci50cw==) | `64.38% <100.00%> (ø)` | |
| [.../src/explore/components/ControlPanelsContainer.tsx](https://codecov.io/gh/apache/superset/pull/13374/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9Db250cm9sUGFuZWxzQ29udGFpbmVyLnRzeA==) | `97.27% <100.00%> (+0.07%)` | :arrow_up: |
| [...t-frontend/src/explore/reducers/getInitialState.ts](https://codecov.io/gh/apache/superset/pull/13374/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvZ2V0SW5pdGlhbFN0YXRlLnRz) | `100.00% <100.00%> (ø)` | |
| [...set-frontend/src/dashboard/util/getDropPosition.js](https://codecov.io/gh/apache/superset/pull/13374/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERyb3BQb3NpdGlvbi5qcw==) | `90.90% <0.00%> (-1.52%)` | :arrow_down: |
| [superset/views/dynamic\_plugins.py](https://codecov.io/gh/apache/superset/pull/13374/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZHluYW1pY19wbHVnaW5zLnB5) | | |
| [superset/examples/country\_map.py](https://codecov.io/gh/apache/superset/pull/13374/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvY291bnRyeV9tYXAucHk=) | | |
| [superset/jinja\_context.py](https://codecov.io/gh/apache/superset/pull/13374/diff?src=pr&el=tree#diff-c3VwZXJzZXQvamluamFfY29udGV4dC5weQ==) | | |
| [superset/examples/random\_time\_series.py](https://codecov.io/gh/apache/superset/pull/13374/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvcmFuZG9tX3RpbWVfc2VyaWVzLnB5) | | |
| [superset/common/query\_context.py](https://codecov.io/gh/apache/superset/pull/13374/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | | |
| ... and [297 more](https://codecov.io/gh/apache/superset/pull/13374/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13374?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13374?src=pr&el=footer). Last update [3c62069...167af5c](https://codecov.io/gh/apache/superset/pull/13374?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13374: chore: convert chartReducer to TypeScript
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13374:
URL: https://github.com/apache/superset/pull/13374#issuecomment-787504724
# [Codecov](https://codecov.io/gh/apache/superset/pull/13374?src=pr&el=h1) Report
> Merging [#13374](https://codecov.io/gh/apache/superset/pull/13374?src=pr&el=desc) (45a133c) into [master](https://codecov.io/gh/apache/superset/commit/08183dfe57b7c4d01c745528baa670c459a51445?el=desc) (08183df) will **increase** coverage by `0.81%`.
> The diff coverage is `68.96%`.
[](https://codecov.io/gh/apache/superset/pull/13374?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13374 +/- ##
==========================================
+ Coverage 72.13% 72.94% +0.81%
==========================================
Files 898 597 -301
Lines 45681 21275 -24406
Branches 5495 5423 -72
==========================================
- Hits 32952 15520 -17432
+ Misses 12517 5628 -6889
+ Partials 212 127 -85
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `57.66% <100.00%> (?)` | |
| javascript | `62.75% <48.27%> (+0.17%)` | :arrow_up: |
| mysql | `?` | |
| postgres | `?` | |
| python | `?` | |
| sqlite | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13374?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...rset-frontend/src/components/ButtonGroup/index.tsx](https://codecov.io/gh/apache/superset/pull/13374/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQnV0dG9uR3JvdXAvaW5kZXgudHN4) | `100.00% <ø> (ø)` | |
| [...et-frontend/src/components/ErrorBoundary/index.jsx](https://codecov.io/gh/apache/superset/pull/13374/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JCb3VuZGFyeS9pbmRleC5qc3g=) | `95.45% <ø> (ø)` | |
| [...-frontend/src/components/Select/Select.stories.tsx](https://codecov.io/gh/apache/superset/pull/13374/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L1NlbGVjdC5zdG9yaWVzLnRzeA==) | `0.00% <0.00%> (ø)` | |
| [superset-frontend/src/components/Select/Select.tsx](https://codecov.io/gh/apache/superset/pull/13374/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L1NlbGVjdC50c3g=) | `90.81% <ø> (ø)` | |
| [superset-frontend/src/components/Select/styles.tsx](https://codecov.io/gh/apache/superset/pull/13374/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L3N0eWxlcy50c3g=) | `86.30% <ø> (+24.65%)` | :arrow_up: |
| [...et-frontend/src/components/Timer/Timer.stories.tsx](https://codecov.io/gh/apache/superset/pull/13374/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGltZXIvVGltZXIuc3Rvcmllcy50c3g=) | `0.00% <0.00%> (ø)` | |
| [superset-frontend/src/components/Timer/index.tsx](https://codecov.io/gh/apache/superset/pull/13374/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGltZXIvaW5kZXgudHN4) | `95.83% <ø> (ø)` | |
| [superset-frontend/src/chart/Chart.jsx](https://codecov.io/gh/apache/superset/pull/13374/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0LmpzeA==) | `64.81% <100.00%> (+17.64%)` | :arrow_up: |
| [superset-frontend/src/chart/chartReducer.ts](https://codecov.io/gh/apache/superset/pull/13374/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0UmVkdWNlci50cw==) | `64.38% <100.00%> (ø)` | |
| [superset-frontend/src/components/Select/index.ts](https://codecov.io/gh/apache/superset/pull/13374/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L2luZGV4LnRz) | `100.00% <100.00%> (ø)` | |
| ... and [519 more](https://codecov.io/gh/apache/superset/pull/13374/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13374?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13374?src=pr&el=footer). Last update [391d909...fd92652](https://codecov.io/gh/apache/superset/pull/13374?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13374: chore: convert chartReducer to TypeScript
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13374:
URL: https://github.com/apache/superset/pull/13374#issuecomment-787504724
# [Codecov](https://codecov.io/gh/apache/superset/pull/13374?src=pr&el=h1) Report
> Merging [#13374](https://codecov.io/gh/apache/superset/pull/13374?src=pr&el=desc) (167af5c) into [master](https://codecov.io/gh/apache/superset/commit/3c62069bbb0d07ff0194fbb159c2e04fd98fafc2?el=desc) (3c62069) will **decrease** coverage by `4.31%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/13374?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13374 +/- ##
==========================================
- Coverage 77.09% 72.77% -4.32%
==========================================
Files 898 597 -301
Lines 45711 21272 -24439
Branches 5495 5498 +3
==========================================
- Hits 35241 15481 -19760
+ Misses 10344 5665 -4679
Partials 126 126
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `57.68% <100.00%> (+0.05%)` | :arrow_up: |
| hive | `?` | |
| javascript | `62.56% <66.66%> (-0.01%)` | :arrow_down: |
| mysql | `?` | |
| postgres | `?` | |
| presto | `?` | |
| python | `?` | |
| sqlite | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13374?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/chart/chartReducer.ts](https://codecov.io/gh/apache/superset/pull/13374/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0UmVkdWNlci50cw==) | `64.38% <100.00%> (ø)` | |
| [.../src/explore/components/ControlPanelsContainer.tsx](https://codecov.io/gh/apache/superset/pull/13374/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9Db250cm9sUGFuZWxzQ29udGFpbmVyLnRzeA==) | `97.27% <100.00%> (+0.07%)` | :arrow_up: |
| [...t-frontend/src/explore/reducers/getInitialState.ts](https://codecov.io/gh/apache/superset/pull/13374/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvZ2V0SW5pdGlhbFN0YXRlLnRz) | `100.00% <100.00%> (ø)` | |
| [...set-frontend/src/dashboard/util/getDropPosition.js](https://codecov.io/gh/apache/superset/pull/13374/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERyb3BQb3NpdGlvbi5qcw==) | `90.90% <0.00%> (-1.52%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/superset/pull/13374/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | | |
| [superset/security/api.py](https://codecov.io/gh/apache/superset/pull/13374/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc2VjdXJpdHkvYXBpLnB5) | | |
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/13374/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | | |
| [superset/sql\_lab.py](https://codecov.io/gh/apache/superset/pull/13374/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX2xhYi5weQ==) | | |
| [superset/db\_engine\_specs/\_\_init\_\_.py](https://codecov.io/gh/apache/superset/pull/13374/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL19faW5pdF9fLnB5) | | |
| ... and [297 more](https://codecov.io/gh/apache/superset/pull/13374/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13374?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13374?src=pr&el=footer). Last update [3c62069...167af5c](https://codecov.io/gh/apache/superset/pull/13374?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13374: chore: convert chartReducer to TypeScript
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13374:
URL: https://github.com/apache/superset/pull/13374#issuecomment-787504724
# [Codecov](https://codecov.io/gh/apache/superset/pull/13374?src=pr&el=h1) Report
> Merging [#13374](https://codecov.io/gh/apache/superset/pull/13374?src=pr&el=desc) (fd92652) into [master](https://codecov.io/gh/apache/superset/commit/08183dfe57b7c4d01c745528baa670c459a51445?el=desc) (08183df) will **increase** coverage by `4.83%`.
> The diff coverage is `68.96%`.
[](https://codecov.io/gh/apache/superset/pull/13374?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13374 +/- ##
==========================================
+ Coverage 72.13% 76.96% +4.83%
==========================================
Files 898 898
Lines 45681 45725 +44
Branches 5495 5423 -72
==========================================
+ Hits 32952 35194 +2242
+ Misses 12517 10402 -2115
+ Partials 212 129 -83
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `57.09% <100.00%> (?)` | |
| hive | `79.97% <ø> (?)` | |
| javascript | `62.75% <48.27%> (+0.17%)` | :arrow_up: |
| mysql | `80.30% <ø> (ø)` | |
| postgres | `80.34% <ø> (ø)` | |
| python | `80.73% <ø> (+0.30%)` | :arrow_up: |
| sqlite | `79.96% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13374?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...rset-frontend/src/components/ButtonGroup/index.tsx](https://codecov.io/gh/apache/superset/pull/13374/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQnV0dG9uR3JvdXAvaW5kZXgudHN4) | `100.00% <ø> (ø)` | |
| [...et-frontend/src/components/ErrorBoundary/index.jsx](https://codecov.io/gh/apache/superset/pull/13374/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JCb3VuZGFyeS9pbmRleC5qc3g=) | `95.45% <ø> (ø)` | |
| [...-frontend/src/components/Select/Select.stories.tsx](https://codecov.io/gh/apache/superset/pull/13374/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L1NlbGVjdC5zdG9yaWVzLnRzeA==) | `0.00% <0.00%> (ø)` | |
| [superset-frontend/src/components/Select/Select.tsx](https://codecov.io/gh/apache/superset/pull/13374/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L1NlbGVjdC50c3g=) | `90.81% <ø> (ø)` | |
| [superset-frontend/src/components/Select/styles.tsx](https://codecov.io/gh/apache/superset/pull/13374/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L3N0eWxlcy50c3g=) | `86.30% <ø> (+24.65%)` | :arrow_up: |
| [...et-frontend/src/components/Timer/Timer.stories.tsx](https://codecov.io/gh/apache/superset/pull/13374/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGltZXIvVGltZXIuc3Rvcmllcy50c3g=) | `0.00% <0.00%> (ø)` | |
| [superset-frontend/src/components/Timer/index.tsx](https://codecov.io/gh/apache/superset/pull/13374/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGltZXIvaW5kZXgudHN4) | `95.83% <ø> (ø)` | |
| [superset-frontend/src/chart/Chart.jsx](https://codecov.io/gh/apache/superset/pull/13374/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0LmpzeA==) | `64.81% <100.00%> (+17.64%)` | :arrow_up: |
| [superset-frontend/src/chart/chartReducer.ts](https://codecov.io/gh/apache/superset/pull/13374/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0UmVkdWNlci50cw==) | `64.38% <100.00%> (ø)` | |
| [superset-frontend/src/components/Select/index.ts](https://codecov.io/gh/apache/superset/pull/13374/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L2luZGV4LnRz) | `100.00% <100.00%> (ø)` | |
| ... and [220 more](https://codecov.io/gh/apache/superset/pull/13374/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13374?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13374?src=pr&el=footer). Last update [391d909...fd92652](https://codecov.io/gh/apache/superset/pull/13374?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13374: chore: convert chartReducer to TypeScript
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13374:
URL: https://github.com/apache/superset/pull/13374#issuecomment-787504724
# [Codecov](https://codecov.io/gh/apache/superset/pull/13374?src=pr&el=h1) Report
> Merging [#13374](https://codecov.io/gh/apache/superset/pull/13374?src=pr&el=desc) (fd92652) into [master](https://codecov.io/gh/apache/superset/commit/08183dfe57b7c4d01c745528baa670c459a51445?el=desc) (08183df) will **increase** coverage by `8.29%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/13374?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13374 +/- ##
==========================================
+ Coverage 72.13% 80.43% +8.29%
==========================================
Files 898 301 -597
Lines 45681 24450 -21231
Branches 5495 0 -5495
==========================================
- Hits 32952 19666 -13286
+ Misses 12517 4784 -7733
+ Partials 212 0 -212
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `?` | |
| mysql | `80.30% <ø> (ø)` | |
| postgres | `80.34% <ø> (ø)` | |
| python | `80.43% <ø> (ø)` | |
| sqlite | `79.96% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13374?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...et-frontend/src/explore/controlPanels/sections.jsx](https://codecov.io/gh/apache/superset/pull/13374/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9zZWN0aW9ucy5qc3g=) | | |
| [...ters/FiltersConfigModal/FiltersConfigForm/state.ts](https://codecov.io/gh/apache/superset/pull/13374/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL3N0YXRlLnRz) | | |
| [...rc/views/CRUD/alert/components/AlertStatusIcon.tsx](https://codecov.io/gh/apache/superset/pull/13374/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvY29tcG9uZW50cy9BbGVydFN0YXR1c0ljb24udHN4) | | |
| [...uperset-frontend/src/SqlLab/components/ShowSQL.tsx](https://codecov.io/gh/apache/superset/pull/13374/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1Nob3dTUUwudHN4) | | |
| [...perset-frontend/src/utils/getControlsForVizType.js](https://codecov.io/gh/apache/superset/pull/13374/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL2dldENvbnRyb2xzRm9yVml6VHlwZS5qcw==) | | |
| [superset-frontend/src/views/CRUD/types.ts](https://codecov.io/gh/apache/superset/pull/13374/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvdHlwZXMudHM=) | | |
| [...nd/src/dashboard/util/isInDifferentFilterScopes.js](https://codecov.io/gh/apache/superset/pull/13374/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2lzSW5EaWZmZXJlbnRGaWx0ZXJTY29wZXMuanM=) | | |
| [...set-frontend/src/components/Icons/AntdEnhanced.tsx](https://codecov.io/gh/apache/superset/pull/13374/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSWNvbnMvQW50ZEVuaGFuY2VkLnRzeA==) | | |
| [...et-frontend/src/SqlLab/components/QueryHistory.jsx](https://codecov.io/gh/apache/superset/pull/13374/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5SGlzdG9yeS5qc3g=) | | |
| [...rontend/src/components/ErrorMessage/ErrorAlert.tsx](https://codecov.io/gh/apache/superset/pull/13374/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL0Vycm9yQWxlcnQudHN4) | | |
| ... and [573 more](https://codecov.io/gh/apache/superset/pull/13374/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13374?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13374?src=pr&el=footer). Last update [391d909...fd92652](https://codecov.io/gh/apache/superset/pull/13374?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13374: chore: convert chartReducer to TypeScript
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13374:
URL: https://github.com/apache/superset/pull/13374#issuecomment-787504724
# [Codecov](https://codecov.io/gh/apache/superset/pull/13374?src=pr&el=h1) Report
> Merging [#13374](https://codecov.io/gh/apache/superset/pull/13374?src=pr&el=desc) (fd92652) into [master](https://codecov.io/gh/apache/superset/commit/08183dfe57b7c4d01c745528baa670c459a51445?el=desc) (08183df) will **increase** coverage by `4.89%`.
> The diff coverage is `68.96%`.
[](https://codecov.io/gh/apache/superset/pull/13374?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13374 +/- ##
==========================================
+ Coverage 72.13% 77.02% +4.89%
==========================================
Files 898 898
Lines 45681 45725 +44
Branches 5495 5423 -72
==========================================
+ Hits 32952 35221 +2269
+ Misses 12517 10375 -2142
+ Partials 212 129 -83
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `57.09% <100.00%> (?)` | |
| hive | `79.97% <ø> (?)` | |
| javascript | `62.75% <48.27%> (+0.17%)` | :arrow_up: |
| mysql | `80.30% <ø> (ø)` | |
| postgres | `80.34% <ø> (ø)` | |
| presto | `80.00% <ø> (?)` | |
| python | `80.84% <ø> (+0.41%)` | :arrow_up: |
| sqlite | `79.96% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13374?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...rset-frontend/src/components/ButtonGroup/index.tsx](https://codecov.io/gh/apache/superset/pull/13374/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQnV0dG9uR3JvdXAvaW5kZXgudHN4) | `100.00% <ø> (ø)` | |
| [...et-frontend/src/components/ErrorBoundary/index.jsx](https://codecov.io/gh/apache/superset/pull/13374/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JCb3VuZGFyeS9pbmRleC5qc3g=) | `95.45% <ø> (ø)` | |
| [...-frontend/src/components/Select/Select.stories.tsx](https://codecov.io/gh/apache/superset/pull/13374/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L1NlbGVjdC5zdG9yaWVzLnRzeA==) | `0.00% <0.00%> (ø)` | |
| [superset-frontend/src/components/Select/Select.tsx](https://codecov.io/gh/apache/superset/pull/13374/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L1NlbGVjdC50c3g=) | `90.81% <ø> (ø)` | |
| [superset-frontend/src/components/Select/styles.tsx](https://codecov.io/gh/apache/superset/pull/13374/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L3N0eWxlcy50c3g=) | `86.30% <ø> (+24.65%)` | :arrow_up: |
| [...et-frontend/src/components/Timer/Timer.stories.tsx](https://codecov.io/gh/apache/superset/pull/13374/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGltZXIvVGltZXIuc3Rvcmllcy50c3g=) | `0.00% <0.00%> (ø)` | |
| [superset-frontend/src/components/Timer/index.tsx](https://codecov.io/gh/apache/superset/pull/13374/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGltZXIvaW5kZXgudHN4) | `95.83% <ø> (ø)` | |
| [superset-frontend/src/chart/Chart.jsx](https://codecov.io/gh/apache/superset/pull/13374/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0LmpzeA==) | `64.81% <100.00%> (+17.64%)` | :arrow_up: |
| [superset-frontend/src/chart/chartReducer.ts](https://codecov.io/gh/apache/superset/pull/13374/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0UmVkdWNlci50cw==) | `64.38% <100.00%> (ø)` | |
| [superset-frontend/src/components/Select/index.ts](https://codecov.io/gh/apache/superset/pull/13374/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L2luZGV4LnRz) | `100.00% <100.00%> (ø)` | |
| ... and [221 more](https://codecov.io/gh/apache/superset/pull/13374/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13374?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13374?src=pr&el=footer). Last update [391d909...fd92652](https://codecov.io/gh/apache/superset/pull/13374?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13374: chore: convert chartReducer to TypeScript
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13374:
URL: https://github.com/apache/superset/pull/13374#issuecomment-787504724
# [Codecov](https://codecov.io/gh/apache/superset/pull/13374?src=pr&el=h1) Report
> Merging [#13374](https://codecov.io/gh/apache/superset/pull/13374?src=pr&el=desc) (167af5c) into [master](https://codecov.io/gh/apache/superset/commit/08183dfe57b7c4d01c745528baa670c459a51445?el=desc) (08183df) will **increase** coverage by `0.64%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/13374?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13374 +/- ##
==========================================
+ Coverage 72.13% 72.77% +0.64%
==========================================
Files 898 597 -301
Lines 45681 21272 -24409
Branches 5495 5498 +3
==========================================
- Hits 32952 15481 -17471
+ Misses 12517 5665 -6852
+ Partials 212 126 -86
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `57.68% <100.00%> (?)` | |
| javascript | `62.56% <66.66%> (-0.01%)` | :arrow_down: |
| mysql | `?` | |
| postgres | `?` | |
| python | `?` | |
| sqlite | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13374?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/chart/chartReducer.ts](https://codecov.io/gh/apache/superset/pull/13374/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0UmVkdWNlci50cw==) | `64.38% <100.00%> (ø)` | |
| [.../src/explore/components/ControlPanelsContainer.tsx](https://codecov.io/gh/apache/superset/pull/13374/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9Db250cm9sUGFuZWxzQ29udGFpbmVyLnRzeA==) | `97.27% <100.00%> (+9.42%)` | :arrow_up: |
| [...t-frontend/src/explore/reducers/getInitialState.ts](https://codecov.io/gh/apache/superset/pull/13374/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvZ2V0SW5pdGlhbFN0YXRlLnRz) | `100.00% <100.00%> (+68.42%)` | :arrow_up: |
| [superset-frontend/src/views/routes.tsx](https://codecov.io/gh/apache/superset/pull/13374/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL3JvdXRlcy50c3g=) | `56.81% <0.00%> (-6.82%)` | :arrow_down: |
| [...rontend/src/explore/components/DatasourcePanel.tsx](https://codecov.io/gh/apache/superset/pull/13374/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhc291cmNlUGFuZWwudHN4) | `76.92% <0.00%> (-3.08%)` | :arrow_down: |
| [...-frontend/src/datasource/ChangeDatasourceModal.tsx](https://codecov.io/gh/apache/superset/pull/13374/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFzb3VyY2UvQ2hhbmdlRGF0YXNvdXJjZU1vZGFsLnRzeA==) | `84.33% <0.00%> (-1.03%)` | :arrow_down: |
| [...t-frontend/src/views/CRUD/welcome/SavedQueries.tsx](https://codecov.io/gh/apache/superset/pull/13374/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9TYXZlZFF1ZXJpZXMudHN4) | `62.50% <0.00%> (-0.66%)` | :arrow_down: |
| [...erset-frontend/src/SqlLab/components/ResultSet.tsx](https://codecov.io/gh/apache/superset/pull/13374/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1Jlc3VsdFNldC50c3g=) | `68.46% <0.00%> (-0.31%)` | :arrow_down: |
| [.../src/components/dataViewCommon/TableCollection.tsx](https://codecov.io/gh/apache/superset/pull/13374/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvZGF0YVZpZXdDb21tb24vVGFibGVDb2xsZWN0aW9uLnRzeA==) | `100.00% <0.00%> (ø)` | |
| [superset/dashboards/commands/create.py](https://codecov.io/gh/apache/superset/pull/13374/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9jcmVhdGUucHk=) | | |
| ... and [508 more](https://codecov.io/gh/apache/superset/pull/13374/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13374?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13374?src=pr&el=footer). Last update [8f09c62...2dc906b](https://codecov.io/gh/apache/superset/pull/13374?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud closed pull request #13374: chore: convert chartReducer to TypeScript
Posted by GitBox <gi...@apache.org>.
ktmud closed pull request #13374:
URL: https://github.com/apache/superset/pull/13374
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud closed pull request #13374: chore: convert chartReducer to TypeScript
Posted by GitBox <gi...@apache.org>.
ktmud closed pull request #13374:
URL: https://github.com/apache/superset/pull/13374
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org