You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2018/12/27 01:13:48 UTC
[GitHub] kaxil commented on a change in pull request #4371:
[AIRFLOW-2939][AIRFLOW-3568] fix TypeError on
GoogleCloudStorageToS3Operator / S3ToGoogleCloudStorageOperator
kaxil commented on a change in pull request #4371: [AIRFLOW-2939][AIRFLOW-3568] fix TypeError on GoogleCloudStorageToS3Operator / S3ToGoogleCloudStorageOperator
URL: https://github.com/apache/incubator-airflow/pull/4371#discussion_r244067118
##########
File path: airflow/contrib/operators/gcs_to_s3.py
##########
@@ -101,7 +101,7 @@ def execute(self, context):
# Google Cloud Storage and not in S3
bucket_name, _ = S3Hook.parse_s3_url(self.dest_s3_key)
existing_files = s3_hook.list_keys(bucket_name)
- files = set(files) - set(existing_files)
+ files = list(set(files) - set(existing_files))
Review comment:
not sure on this. `xcom` push should be able to support any pickleable object like list, set
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services