You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/06/02 15:43:02 UTC

[GitHub] [arrow] kiszk commented on a change in pull request #7292: ARROW-8471: [C++][Integration] Represent 64 bit integers as strings

kiszk commented on a change in pull request #7292:
URL: https://github.com/apache/arrow/pull/7292#discussion_r433975329



##########
File path: cpp/src/arrow/type_traits.h
##########
@@ -644,6 +644,14 @@ template <typename T, typename R = void>
 using enable_if_physical_unsigned_integer =
     enable_if_t<is_physical_unsigned_integer_type<T>::value, R>;
 
+template <typename T>
+using is_physical_integer_type =
+    std::integral_constant<bool, is_physical_unsigned_integer_type<T>::value ||
+                                     is_physical_signed_integer_type<T>::value>;

Review comment:
       not sure 100%. but, is this indentation correct?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org