You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/09/17 00:55:36 UTC
[GitHub] [spark] HyukjinKwon commented on a change in pull request #34012: [SPARK-36773] Fixed uts to check the compression for parquet
HyukjinKwon commented on a change in pull request #34012:
URL: https://github.com/apache/spark/pull/34012#discussion_r710618686
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetCompressionCodecPrecedenceSuite.scala
##########
@@ -105,7 +105,7 @@ class ParquetCompressionCodecPrecedenceSuite extends ParquetTest with SharedSpar
test("Create parquet table with compression") {
Seq(true, false).foreach { isPartitioned =>
- Seq("UNCOMPRESSED", "SNAPPY", "GZIP").foreach { compressionCodec =>
+ Seq("UNCOMPRESSED", "SNAPPY", "GZIP", "LZ4", "ZSTD").foreach { compressionCodec =>
Review comment:
`org.apache.hadoop.io.compress.ZStandardCodec` is added at Apache Hadoop 2.9.0+. Does the test pass with Hadoop 2 profile?
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetCompressionCodecPrecedenceSuite.scala
##########
@@ -105,7 +105,7 @@ class ParquetCompressionCodecPrecedenceSuite extends ParquetTest with SharedSpar
test("Create parquet table with compression") {
Seq(true, false).foreach { isPartitioned =>
- Seq("UNCOMPRESSED", "SNAPPY", "GZIP").foreach { compressionCodec =>
+ Seq("UNCOMPRESSED", "SNAPPY", "GZIP", "LZ4", "ZSTD").foreach { compressionCodec =>
Review comment:
cc @viirya too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org