[jira] [Commented] (MCOMPILER-576) Deprecate parameter "compilerVersion"

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MCOMPILER-576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17820350#comment-17820350 ] 

ASF GitHub Bot commented on MCOMPILER-576:
------------------------------------------

kwin opened a new pull request, #223:
URL: https://github.com/apache/maven-compiler-plugin/pull/223

   This is no longer evaluated in plexus-compiler-javac (https://github.com/codehaus-plexus/plexus-compiler/issues/356). It was never used by any other plexus compilers in the past.
   
   Following this checklist to help us incorporate your 
   contribution quickly and easily:
   
    - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MCOMPILER) filed 
          for the change (usually before you start working on it).  Trivial changes like typos do not 
          require a JIRA issue.  Your pull request should address just this issue, without 
          pulling in other changes.
    - [ ] Each commit in the pull request should have a meaningful subject line and body.
    - [ ] Format the pull request title like `[MCOMPILER-XXX] - Fixes bug in ApproximateQuantiles`,
          where you replace `MCOMPILER-XXX` with the appropriate JIRA issue. Best practice
          is to use the JIRA issue title in the pull request title and in the first line of the 
          commit message.
    - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
    - [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will 
          be performed on your pull request automatically.
    - [ ] You have run the integration tests successfully (`mvn -Prun-its clean verify`).
   
   If your pull request is about ~20 lines of code you don't need to sign an
   [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
   please ask on the developers list.
   
   To make clear that you license your contribution under 
   the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   you have to acknowledge this by using the following check-box.
   
    - [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   
    - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   




> Deprecate parameter "compilerVersion"
> -------------------------------------
>
>                 Key: MCOMPILER-576
>                 URL: https://issues.apache.org/jira/browse/MCOMPILER-576
>             Project: Maven Compiler Plugin
>          Issue Type: Improvement
>            Reporter: Konrad Windszus
>            Assignee: Konrad Windszus
>            Priority: Major
>             Fix For: next-release
>
>
> The parameter {{compilerVersion}} (https://maven.apache.org/plugins/maven-compiler-plugin/compile-mojo.html#compilerVersion) was used in the past only to derive which how to parameterize the underlying compiler (only used in javac). This was resolved in the context of https://github.com/codehaus-plexus/plexus-compiler/issues/356. Therefore the compiler version is no longer used by any of the plexus compilers. As it never necessarily reflected the actual version of the compiler it should be deprecated.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)