You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@netbeans.apache.org by Laszlo Kishalmi <la...@gmail.com> on 2019/11/20 16:08:10 UTC
PR-s are Piling up!
Dear all,
Please take some time and review PR-s. They are piling up.
Thank you!
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@netbeans.apache.org
For additional commands, e-mail: dev-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
RE: PR-s are Piling up!
Posted by Eric Barboni <sk...@apache.org>.
Hi,
In order to anticipate before 11.,I would like to use new apidoc, https://github.com/apache/netbeans/pull/1532.
This may allow some time to check for Jenkins build adjustment. The resulting look and feel is http://bits.netbeans.org/apidoctest/
I mess up the conversation on the https://github.com/apache/netbeans/pull/1270 by my perfect git(hub) actions.
Best Regards
Eric
-----Message d'origine-----
De : Neil C Smith <ne...@apache.org>
Envoyé : samedi 23 novembre 2019 11:46
À : dev <de...@netbeans.apache.org>
Objet : Re: PR-s are Piling up!
On Fri, 22 Nov 2019 at 23:46, Geertjan Wielenga <ge...@apache.org> wrote:
> I would do these tasks immediately, I just don't know exactly what
> needs to be done -- I don't know what needs to be done and I really
> appreciate the work you and Eric have done in simplifying and
> smoothing out the release process, but currently I do not know how it works.
Well, there's nothing specific to the build/release process to do right now. These PRs need to go into master. Then we need to cherry pick the commits into the release112 branch, ideally by the author cherry picking locally and opening new PRs against the release branch.
As and until we can review and merge the fixes into the release branch, there's not a lot else to do.
Best wishes,
Neil
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@netbeans.apache.org
For additional commands, e-mail: dev-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@netbeans.apache.org
For additional commands, e-mail: dev-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: PR-s are Piling up!
Posted by Neil C Smith <ne...@apache.org>.
On Fri, 22 Nov 2019 at 23:46, Geertjan Wielenga <ge...@apache.org> wrote:
> I would do these tasks immediately, I just don't know exactly what needs to
> be done -- I don't know what needs to be done and I really appreciate the
> work you and Eric have done in simplifying and smoothing out the release
> process, but currently I do not know how it works.
Well, there's nothing specific to the build/release process to do
right now. These PRs need to go into master. Then we need to cherry
pick the commits into the release112 branch, ideally by the author
cherry picking locally and opening new PRs against the release branch.
As and until we can review and merge the fixes into the release
branch, there's not a lot else to do.
Best wishes,
Neil
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@netbeans.apache.org
For additional commands, e-mail: dev-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: PR-s are Piling up!
Posted by Geertjan Wielenga <ge...@apache.org>.
I would do these tasks immediately, I just don't know exactly what needs to
be done -- I don't know what needs to be done and I really appreciate the
work you and Eric have done in simplifying and smoothing out the release
process, but currently I do not know how it works. For me, best would be
complete instructions or maybe a virtual meetup where we go through
everything together, until then the people who can complete this 11.2
related process here are few in number, I think...
Gj
On Fri, Nov 22, 2019 at 12:18 PM Neil C Smith <ne...@apache.org> wrote:
> On Thu, 21 Nov 2019 at 20:25, Geertjan Wielenga <ge...@apache.org>
> wrote:
> > But haven't they been reviewed already? At this point, you can merge them
> > and continue with the process you describe of suggesting a signing
> option.
>
> Theoretically there's an open request for review from Jan on the
> nb-javac one, and an open question on the other whether it's worth
> cherry picking (confirmation we can update that via NBM). Although
> both probably fine to merge to master.
>
> After merging to master, we need 3 more PRs made (ideally by the
> original authors*) on top of release112 to cherry pick the relevant
> commits and add others such as release branch spec version increment.
> Then they can be reviewed and I can merge and get on with other steps.
>
> * IMO original author is best placed to cherry pick, update and build
> an NBM to test in the release and make sure the fix applies correctly.
>
> I can do the RM steps next week, but if it slips into December then
> work commitments mean someone else will have to pick it up.
>
> Likewise, if someone wants to suggest alternative steps or handle the
> RM'ing now, please go ahead!
>
> There was also an alternative question about an Oracle signed nb-javac
> update that wasn't answered, although that doesn't address the other
> bugs.
>
> Best wishes,
>
> Neil
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@netbeans.apache.org
> For additional commands, e-mail: dev-help@netbeans.apache.org
>
> For further information about the NetBeans mailing lists, visit:
> https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
>
>
>
>
Re: PR-s are Piling up!
Posted by Neil C Smith <ne...@apache.org>.
On Thu, 21 Nov 2019 at 20:25, Geertjan Wielenga <ge...@apache.org> wrote:
> But haven't they been reviewed already? At this point, you can merge them
> and continue with the process you describe of suggesting a signing option.
Theoretically there's an open request for review from Jan on the
nb-javac one, and an open question on the other whether it's worth
cherry picking (confirmation we can update that via NBM). Although
both probably fine to merge to master.
After merging to master, we need 3 more PRs made (ideally by the
original authors*) on top of release112 to cherry pick the relevant
commits and add others such as release branch spec version increment.
Then they can be reviewed and I can merge and get on with other steps.
* IMO original author is best placed to cherry pick, update and build
an NBM to test in the release and make sure the fix applies correctly.
I can do the RM steps next week, but if it slips into December then
work commitments mean someone else will have to pick it up.
Likewise, if someone wants to suggest alternative steps or handle the
RM'ing now, please go ahead!
There was also an alternative question about an Oracle signed nb-javac
update that wasn't answered, although that doesn't address the other
bugs.
Best wishes,
Neil
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@netbeans.apache.org
For additional commands, e-mail: dev-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: PR-s are Piling up!
Posted by Geertjan Wielenga <ge...@apache.org>.
But haven't they been reviewed already? At this point, you can merge them
and continue with the process you describe of suggesting a signing option.
Gj
On Thu, Nov 21, 2019 at 8:15 PM Neil C Smith <ne...@apache.org> wrote:
> On Wed, 20 Nov 2019 at 16:08, Laszlo Kishalmi <la...@gmail.com>
> wrote:
> > Please take some time and review PR-s. They are piling up.
>
> As important for 11.3 as that is, it would be even better if we could
> prioritize the patch fix PRs for 11.2! There are 2 cherry-pick PRs
> that still need reviewing and merging to master, and follow-up PRs for
> all 3 for the release112 branch made.
>
> If we can get those in by early next week, I can look at following up
> on some sort of Apache signing option so we can build, vote on and
> ship the updates before we get any more bug reports.
>
> Best wishes,
>
> Neil
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@netbeans.apache.org
> For additional commands, e-mail: dev-help@netbeans.apache.org
>
> For further information about the NetBeans mailing lists, visit:
> https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
>
>
>
>
Re: PR-s are Piling up!
Posted by Neil C Smith <ne...@apache.org>.
On Wed, 20 Nov 2019 at 16:08, Laszlo Kishalmi <la...@gmail.com> wrote:
> Please take some time and review PR-s. They are piling up.
As important for 11.3 as that is, it would be even better if we could
prioritize the patch fix PRs for 11.2! There are 2 cherry-pick PRs
that still need reviewing and merging to master, and follow-up PRs for
all 3 for the release112 branch made.
If we can get those in by early next week, I can look at following up
on some sort of Apache signing option so we can build, vote on and
ship the updates before we get any more bug reports.
Best wishes,
Neil
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@netbeans.apache.org
For additional commands, e-mail: dev-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
AW: PR-s are Piling up!
Posted by Christian Lenz <ch...@gmx.net>.
Will have a look into the PR from Jan Lahoda about the simple UI for textmate stuff. I know it is still in progress but testing as early as possible is good anyway 😊
Von: Geertjan Wielenga
Gesendet: Mittwoch, 20. November 2019 17:46
An: dev@netbeans.apache.org
Betreff: Re: PR-s are Piling up!
Thanks for the ping! Will be looking through them. :-)
Gj
On Wed, 20 Nov 2019 at 17:08, Laszlo Kishalmi <la...@gmail.com>
wrote:
> Dear all,
>
> Please take some time and review PR-s. They are piling up.
>
> Thank you!
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@netbeans.apache.org
> For additional commands, e-mail: dev-help@netbeans.apache.org
>
> For further information about the NetBeans mailing lists, visit:
> https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
>
>
>
>
Re: PR-s are Piling up!
Posted by Geertjan Wielenga <ge...@apache.org>.
Thanks for the ping! Will be looking through them. :-)
Gj
On Wed, 20 Nov 2019 at 17:08, Laszlo Kishalmi <la...@gmail.com>
wrote:
> Dear all,
>
> Please take some time and review PR-s. They are piling up.
>
> Thank you!
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@netbeans.apache.org
> For additional commands, e-mail: dev-help@netbeans.apache.org
>
> For further information about the NetBeans mailing lists, visit:
> https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
>
>
>
>