You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "allisonwang-db (via GitHub)" <gi...@apache.org> on 2023/12/19 06:31:17 UTC
[PR] [SPARK-46452][SQL] Add a new API in DataWriter to write an iterator of records [spark]
allisonwang-db opened a new pull request, #44410:
URL: https://github.com/apache/spark/pull/44410
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
This PR proposes to add a new method in `DataWriter` that supports writing an iterator of records:
```java
void writeAll(Iterator<T> records) throws IOException
```
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
To make the API more flexible and support more use cases (e.g Python data sources). See https://github.com/apache/spark/pull/43791
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
Existing unit tests.
### Was this patch authored or co-authored using generative AI tooling?
<!--
If generative AI tooling has been used in the process of authoring this patch, please include the
phrase: 'Generated-by: ' followed by the name of the tool and its version.
If no, write 'No'.
Please refer to the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) for details.
-->
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46452][SQL] Add a new API in DataWriter to write an iterator of records [spark]
Posted by "allisonwang-db (via GitHub)" <gi...@apache.org>.
allisonwang-db commented on PR #44410:
URL: https://github.com/apache/spark/pull/44410#issuecomment-1863780931
@cloud-fan The test failures are unrelated. I've re-triggered the tests but they still failed: [RETRIES_EXCEEDED] The maximum number of retries has been exceeded.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46452][SQL] Add a new API in DataWriter to write an iterator of records [spark]
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on code in PR #44410:
URL: https://github.com/apache/spark/pull/44410#discussion_r1431023393
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/WriteToDataSourceV2Exec.scala:
##########
@@ -421,7 +421,13 @@ trait V2TableWriteExec extends V2CommandExec with UnaryExecNode {
trait WritingSparkTask[W <: DataWriter[InternalRow]] extends Logging with Serializable {
- protected def write(writer: W, row: InternalRow): Unit
+ protected def write(writer: W, row: InternalRow): Unit = {}
Review Comment:
isn't it internal API?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46452][SQL] Add a new API in DataWriter to write an iterator of records [spark]
Posted by "allisonwang-db (via GitHub)" <gi...@apache.org>.
allisonwang-db commented on code in PR #44410:
URL: https://github.com/apache/spark/pull/44410#discussion_r1432323777
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/WriteToDataSourceV2Exec.scala:
##########
@@ -489,11 +481,30 @@ trait WritingSparkTask[W <: DataWriter[InternalRow]] extends Logging with Serial
dataWriter.close()
})
}
+
+ private case class IteratorWithMetrics(
+ iter: Iterator[InternalRow],
+ dataWriter: W,
+ customMetrics: Map[String, SQLMetric]) extends Iterator[InternalRow] {
Review Comment:
Sure updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46452][SQL] Add a new API in DataWriter to write an iterator of records [spark]
Posted by "allisonwang-db (via GitHub)" <gi...@apache.org>.
allisonwang-db commented on PR #44410:
URL: https://github.com/apache/spark/pull/44410#issuecomment-1862199112
cc @cloud-fan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46452][SQL] Add a new API in DataWriter to write an iterator of records [spark]
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on PR #44410:
URL: https://github.com/apache/spark/pull/44410#issuecomment-1864297130
thanks, merging to master!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46452][SQL] Add a new API in DataWriter to write an iterator of records [spark]
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on code in PR #44410:
URL: https://github.com/apache/spark/pull/44410#discussion_r1432252629
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/WriteToDataSourceV2Exec.scala:
##########
@@ -489,11 +481,30 @@ trait WritingSparkTask[W <: DataWriter[InternalRow]] extends Logging with Serial
dataWriter.close()
})
}
+
+ private case class IteratorWithMetrics(
+ iter: Iterator[InternalRow],
+ dataWriter: W,
+ customMetrics: Map[String, SQLMetric]) extends Iterator[InternalRow] {
Review Comment:
shall we make it extend java Iterator?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46452][SQL] Add a new API in DataWriter to write an iterator of records [spark]
Posted by "allisonwang-db (via GitHub)" <gi...@apache.org>.
allisonwang-db commented on code in PR #44410:
URL: https://github.com/apache/spark/pull/44410#discussion_r1430987068
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/WriteToDataSourceV2Exec.scala:
##########
@@ -421,7 +421,13 @@ trait V2TableWriteExec extends V2CommandExec with UnaryExecNode {
trait WritingSparkTask[W <: DataWriter[InternalRow]] extends Logging with Serializable {
- protected def write(writer: W, row: InternalRow): Unit
+ protected def write(writer: W, row: InternalRow): Unit = {}
Review Comment:
There is a DeltaWriter that has custom implementations of `write`:
https://github.com/apache/spark/blob/0b8e0998c67331bc82428d807476584f3d21f934/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/WriteToDataSourceV2Exec.scala#L529-L559
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46452][SQL] Add a new API in DataWriter to write an iterator of records [spark]
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on code in PR #44410:
URL: https://github.com/apache/spark/pull/44410#discussion_r1430981946
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/WriteToDataSourceV2Exec.scala:
##########
@@ -439,17 +445,17 @@ trait WritingSparkTask[W <: DataWriter[InternalRow]] extends Logging with Serial
var count = 0L
// write the data and commit this writer.
Utils.tryWithSafeFinallyAndFailureCallbacks(block = {
- while (iter.hasNext) {
+ val iterWithMetrics = iter.map { row =>
Review Comment:
can we new a java iterator to make the code clearer? The `count` is now in the closure, which is a bit tricky.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46452][SQL] Add a new API in DataWriter to write an iterator of records [spark]
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on code in PR #44410:
URL: https://github.com/apache/spark/pull/44410#discussion_r1430982336
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/WriteToDataSourceV2Exec.scala:
##########
@@ -421,7 +421,13 @@ trait V2TableWriteExec extends V2CommandExec with UnaryExecNode {
trait WritingSparkTask[W <: DataWriter[InternalRow]] extends Logging with Serializable {
- protected def write(writer: W, row: InternalRow): Unit
+ protected def write(writer: W, row: InternalRow): Unit = {}
Review Comment:
do we still need this method?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46452][SQL] Add a new API in DataWriter to write an iterator of records [spark]
Posted by "allisonwang-db (via GitHub)" <gi...@apache.org>.
allisonwang-db commented on code in PR #44410:
URL: https://github.com/apache/spark/pull/44410#discussion_r1430987659
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/WriteToDataSourceV2Exec.scala:
##########
@@ -421,7 +421,13 @@ trait V2TableWriteExec extends V2CommandExec with UnaryExecNode {
trait WritingSparkTask[W <: DataWriter[InternalRow]] extends Logging with Serializable {
- protected def write(writer: W, row: InternalRow): Unit
+ protected def write(writer: W, row: InternalRow): Unit = {}
Review Comment:
We can migrate that to `writeAll`, but I am not sure if we can remove this `write` method in the trait `WritingSparkTask`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46452][SQL] Add a new API in DataWriter to write an iterator of records [spark]
Posted by "allisonwang-db (via GitHub)" <gi...@apache.org>.
allisonwang-db commented on code in PR #44410:
URL: https://github.com/apache/spark/pull/44410#discussion_r1430987659
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/WriteToDataSourceV2Exec.scala:
##########
@@ -421,7 +421,13 @@ trait V2TableWriteExec extends V2CommandExec with UnaryExecNode {
trait WritingSparkTask[W <: DataWriter[InternalRow]] extends Logging with Serializable {
- protected def write(writer: W, row: InternalRow): Unit
+ protected def write(writer: W, row: InternalRow): Unit = {}
Review Comment:
We can migrate that to `writeAll`, but I am not sure if we can remove this `write` method in the trait `WritingSparkTask` (which will be a breaking change?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46452][SQL] Add a new API in DataWriter to write an iterator of records [spark]
Posted by "allisonwang-db (via GitHub)" <gi...@apache.org>.
allisonwang-db commented on code in PR #44410:
URL: https://github.com/apache/spark/pull/44410#discussion_r1431113211
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/WriteToDataSourceV2Exec.scala:
##########
@@ -421,7 +421,13 @@ trait V2TableWriteExec extends V2CommandExec with UnaryExecNode {
trait WritingSparkTask[W <: DataWriter[InternalRow]] extends Logging with Serializable {
- protected def write(writer: W, row: InternalRow): Unit
+ protected def write(writer: W, row: InternalRow): Unit = {}
Review Comment:
True. Let me update this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46452][SQL] Add a new API in DataWriter to write an iterator of records [spark]
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan closed pull request #44410: [SPARK-46452][SQL] Add a new API in DataWriter to write an iterator of records
URL: https://github.com/apache/spark/pull/44410
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org