You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2019/12/23 20:47:00 UTC

[jira] [Work logged] (GOBBLIN-1008) Upgrade Parquet dependency from twitter artifact to org.apache artifact

     [ https://issues.apache.org/jira/browse/GOBBLIN-1008?focusedWorklogId=362735&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-362735 ]

ASF GitHub Bot logged work on GOBBLIN-1008:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 23/Dec/19 20:46
            Start Date: 23/Dec/19 20:46
    Worklog Time Spent: 10m 
      Work Description: codecov-io commented on issue #2853: [GOBBLIN-1008] Upgrading parquet dependency to org.apache.parquet. Fixing tests
URL: https://github.com/apache/incubator-gobblin/pull/2853#issuecomment-567827520
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2853?src=pr&el=h1) Report
   > Merging [#2853](https://codecov.io/gh/apache/incubator-gobblin/pull/2853?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-gobblin/commit/313faa57617cc8241750990f423d407ed59f3b80?src=pr&el=desc) will **increase** coverage by `0.16%`.
   > The diff coverage is `76.41%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-gobblin/pull/2853/graphs/tree.svg?width=650&token=4MgURJ0bGc&height=150&src=pr)](https://codecov.io/gh/apache/incubator-gobblin/pull/2853?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #2853      +/-   ##
   ============================================
   + Coverage     45.52%   45.68%   +0.16%     
   - Complexity     8996     9062      +66     
   ============================================
     Files          1904     1912       +8     
     Lines         71577    71984     +407     
     Branches       7892     7937      +45     
   ============================================
   + Hits          32585    32886     +301     
   - Misses        35989    36082      +93     
   - Partials       3003     3016      +13
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-gobblin/pull/2853?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...g/apache/gobblin/writer/ParquetHdfsDataWriter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2853/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tcGFycXVldC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi93cml0ZXIvUGFycXVldEhkZnNEYXRhV3JpdGVyLmphdmE=) | `100% <ø> (ø)` | `4 <0> (ø)` | :arrow_down: |
   | [...pache/gobblin/writer/ParquetDataWriterBuilder.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2853/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tcGFycXVldC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi93cml0ZXIvUGFycXVldERhdGFXcml0ZXJCdWlsZGVyLmphdmE=) | `86.2% <ø> (ø)` | `6 <0> (ø)` | :arrow_down: |
   | [...sion/finder/HdfsModifiedTimeHiveVersionFinder.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2853/diff?src=pr&el=tree#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L3ZlcnNpb24vZmluZGVyL0hkZnNNb2RpZmllZFRpbWVIaXZlVmVyc2lvbkZpbmRlci5qYXZh) | `84.61% <ø> (ø)` | `4 <0> (ø)` | :arrow_down: |
   | [...rquet/JsonIntermediateToParquetGroupConverter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2853/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tcGFycXVldC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi9jb252ZXJ0ZXIvcGFycXVldC9Kc29uSW50ZXJtZWRpYXRlVG9QYXJxdWV0R3JvdXBDb252ZXJ0ZXIuamF2YQ==) | `100% <ø> (ø)` | `3 <0> (ø)` | :arrow_down: |
   | [...apache/gobblin/converter/parquet/ParquetGroup.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2853/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tcGFycXVldC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi9jb252ZXJ0ZXIvcGFycXVldC9QYXJxdWV0R3JvdXAuamF2YQ==) | `47.67% <ø> (ø)` | `16 <0> (ø)` | :arrow_down: |
   | [...g/apache/gobblin/writer/ParquetHdfsDataWriter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2853/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tcGFycXVldC1hcGFjaGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vd3JpdGVyL1BhcnF1ZXRIZGZzRGF0YVdyaXRlci5qYXZh) | `100% <100%> (ø)` | `4 <4> (?)` | |
   | [...rquet/JsonIntermediateToParquetGroupConverter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2853/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tcGFycXVldC1hcGFjaGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vY29udmVydGVyL3BhcnF1ZXQvSnNvbkludGVybWVkaWF0ZVRvUGFycXVldEdyb3VwQ29udmVydGVyLmphdmE=) | `100% <100%> (ø)` | `3 <3> (?)` | |
   | [...apache/gobblin/converter/parquet/ParquetGroup.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2853/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tcGFycXVldC1hcGFjaGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vY29udmVydGVyL3BhcnF1ZXQvUGFycXVldEdyb3VwLmphdmE=) | `45.05% <45.05%> (ø)` | `16 <16> (?)` | |
   | [...onverter/parquet/JsonElementConversionFactory.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2853/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tcGFycXVldC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi9jb252ZXJ0ZXIvcGFycXVldC9Kc29uRWxlbWVudENvbnZlcnNpb25GYWN0b3J5LmphdmE=) | `90.38% <71.42%> (+0.06%)` | `13 <2> (+2)` | :arrow_up: |
   | [...pache/gobblin/writer/ParquetDataWriterBuilder.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2853/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tcGFycXVldC1hcGFjaGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vd3JpdGVyL1BhcnF1ZXREYXRhV3JpdGVyQnVpbGRlci5qYXZh) | `86.2% <86.2%> (ø)` | `6 <6> (?)` | |
   | ... and [17 more](https://codecov.io/gh/apache/incubator-gobblin/pull/2853/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2853?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2853?src=pr&el=footer). Last update [313faa5...578a7a2](https://codecov.io/gh/apache/incubator-gobblin/pull/2853?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

            Worklog Id:     (was: 362735)
    Remaining Estimate: 0h
            Time Spent: 10m

> Upgrade Parquet dependency from twitter artifact to org.apache artifact
> -----------------------------------------------------------------------
>
>                 Key: GOBBLIN-1008
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-1008
>             Project: Apache Gobblin
>          Issue Type: Task
>            Reporter: Shirshanka Das
>            Assignee: Shirshanka Das
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> The Parquet dependency in Gobblin is pulling in an old version from twitter (2014)
> Filing this Jira to upgrade the dependency to an org.apache Parquet version. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)