[GitHub] [flink] X-czh commented on a diff in pull request #21673: [FLINK-30513] Cleanup HA storage path on cluster termination

["X-czh (via GitHub)" <gi...@apache.org>]

X-czh commented on code in PR #21673:
URL: https://github.com/apache/flink/pull/21673#discussion_r1122567580


##########
flink-runtime/src/main/java/org/apache/flink/runtime/highavailability/AbstractHaServices.java:
##########
@@ -225,6 +237,13 @@ public CompletableFuture<Void> globalCleanupAsync(JobID jobID, Executor executor
                 executor);
     }
 
+    protected void cleanupClusterHaStoragePath() throws Exception {
+        final Path clusterHaStoragePath =
+                HighAvailabilityServicesUtils.getClusterHighAvailableStoragePath(configuration);
+        final FileSystem fileSystem = clusterHaStoragePath.getFileSystem();
+        fileSystem.delete(clusterHaStoragePath, true);

Review Comment:
   Yes, it will already delete the blob dir. However, as you mentioned, the protocol of BlobStoreService#closeAndCleanupAllData() is not limited to deleting directory, so it is still required.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org