[jira] [Commented] (ORC-537) Build failure with ORC 1.5.6 with snappy

["Owen O'Malley (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ORC-537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16962540#comment-16962540 ] 

Owen O'Malley commented on ORC-537:
-----------------------------------

I believe this is fixed in the ORC 1.6 line.
{code}
  set(SNAPPY_CMAKE_ARGS -DCMAKE_INSTALL_PREFIX=${SNAPPY_HOME}
                        -DBUILD_SHARED_LIBS=OFF -DCMAKE_INSTALL_LIBDIR=lib)
{code}

> Build failure with ORC 1.5.6 with snappy
> ----------------------------------------
>
>                 Key: ORC-537
>                 URL: https://issues.apache.org/jira/browse/ORC-537
>             Project: ORC
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 1.5.6
>         Environment: RHEL 6.7, gcc 7.4, cmake-3.13.1, autoconf-2.69, libtool-2.4.6, automake-1.15.1
>            Reporter: Bob Huemmer
>            Priority: Major
>
> When building ORC 1.5.6 using the following command:
> cmake .. -DCMAKE_BUILD_TYPE=RELEASE -DBUILD_JAVA=OFF -DBUILD_CPP_TESTS=OFF
> I see the following error when performing gmake:
> gmake[2]: *** No rule to make target `c++/libs/thirdparty/snappy_ep-install/lib/libsnappy.a', needed by `tools/src/orc-contents'. Stop.
> gmake[2]: *** Waiting for unfinished jobs....
> gmake[2]: *** No rule to make target `c++/libs/thirdparty/snappy_ep-install/lib/libsnappy.a', needed by `tools/src/orc-scan'. Stop.
> gmake[2]: *** Waiting for unfinished jobs....
> [ 85%] Building CXX object tools/src/CMakeFiles/orc-scan.dir/FileScan.cc.o
> [ 85%] Building CXX object tools/src/CMakeFiles/orc-contents.dir/FileContents.cc.o
> Scanning dependencies of target orc-metadata
> gmake[2]: *** No rule to make target `c++/libs/thirdparty/snappy_ep-install/lib/libsnappy.a', needed by `tools/src/orc-metadata'. Stop.
> gmake[2]: *** Waiting for unfinished jobs....
> [ 86%] Building CXX object tools/src/CMakeFiles/orc-metadata.dir/FileMetadata.cc.o
> gmake[1]: *** [tools/src/CMakeFiles/orc-scan.dir/all] Error 2
> gmake[1]: *** Waiting for unfinished jobs....
> gmake[1]: *** [tools/src/CMakeFiles/orc-contents.dir/all] Error 2
> gmake[1]: *** [tools/src/CMakeFiles/orc-metadata.dir/all] Error 2
> gmake: *** [all] Error 2
>  
> The problem appears to be with snappy's build placing the static library libsnappy.a into orc-rel-release-1.5.6/build/c++/libs/thirdparty/snappy_ep-install/lib64/libsnappy.a. The problem is with "lib64" in this path. I think later the build process looks in this path with "lib" rather than "lib64".
> If I change line 60 of file orc-rel-release-1.5.6/cmake_modules/ThirdpartyToolchain.cmake from
> set(SNAPPY_STATIC_LIB "${SNAPPY_HOME}/{color:#14892c}*lib*{color}/${CMAKE_STATIC_LIBRARY_PREFIX}snappy${CMAKE_STATIC_LIBRARY_SUFFIX}")
> to
> set(SNAPPY_STATIC_LIB "${SNAPPY_HOME}/{color:#14892c}*lib64/*{color}${CMAKE_STATIC_LIBRARY_PREFIX}snappy${CMAKE_STATIC_LIBRARY_SUFFIX}")
> this corrects the problem.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)