You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Erick Erickson (JIRA)" <ji...@apache.org> on 2017/01/20 05:07:26 UTC
[jira] [Comment Edited] (SOLR-10008) Move the reference to
CoreContainer from CoreDescriptor to SolrCore.
[ https://issues.apache.org/jira/browse/SOLR-10008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15831192#comment-15831192 ]
Erick Erickson edited comment on SOLR-10008 at 1/20/17 5:06 AM:
----------------------------------------------------------------
Think of this as a feasibility study. All tests pass, but it does great violence to constructors for SolrCore and CoreDescriptor.getCoreContainer thus breaks back-compat. It's evidence that this is possible, but are there better ways to access CoreContainer across the code?
Most of this patch is just removing the intermediate getCoreDescriptor() from core.getCoreDescriptor().getCoreContainer()....
was (Author: erickerickson):
Think of this as a feasibility study. All tests pass, but it does great violence to constructors for SolrCore and a CoreDescriptor.getCoreContainer thus breaks back-compat. It's evidence that this is possible, but are there better ways to access CoreContainer across the code?
Most of this patch is just removing the intermediate getCoreDescriptor() from core.getCoreDescriptor().getCoreContainer()....
> Move the reference to CoreContainer from CoreDescriptor to SolrCore.
> --------------------------------------------------------------------
>
> Key: SOLR-10008
> URL: https://issues.apache.org/jira/browse/SOLR-10008
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Affects Versions: trunk, 6.4
> Reporter: Erick Erickson
> Assignee: Erick Erickson
> Attachments: SOLR-10008.patch
>
>
> CoreDescriptor referencing CoreContainer is just weird. If anyplace, the SolrCore should have a reference to CoreContainer.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org