You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2020/09/04 09:30:56 UTC
[GitHub] [calcite] danny0405 commented on a change in pull request #2130: [CALCITE-4207] Validation fails for positional aggregate with current_date in 'case' expression
danny0405 commented on a change in pull request #2130:
URL: https://github.com/apache/calcite/pull/2130#discussion_r483503190
##########
File path: core/src/test/java/org/apache/calcite/test/SqlValidatorTest.java
##########
@@ -11685,6 +11685,19 @@ private void checkCustomColumnResolving(String table) {
+ "MYFUN\\(<NUMERIC>, <NUMERIC>\\).*");
}
+ @Test void testPositionalAggregateWithExpandedCurrentDateFunction() {
+ SqlConformance defaultPlusOrdinalGroupBy =
+ new SqlDelegatingConformance(SqlConformanceEnum.DEFAULT) {
+ @Override public boolean isGroupByOrdinal() {
+ return true;
+ }
+ };
+ sql("SELECT HIREDATE >= CURRENT_DATE, COUNT(*) "
+ + "FROM EMP GROUP BY 1")
Review comment:
I'm confused by why the `current_date` caused the problem, does other non-param function triggers the bug too ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org