You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@shenyu.apache.org by GitBox <gi...@apache.org> on 2022/07/01 10:12:06 UTC

[GitHub] [incubator-shenyu-dashboard] 847850277 commented on a diff in pull request #213: feature: use path to search

847850277 commented on code in PR #213:
URL: https://github.com/apache/incubator-shenyu-dashboard/pull/213#discussion_r911826507


##########
src/routes/System/Metadata/index.js:
##########
@@ -398,9 +399,9 @@ export default class Metadata extends Component {
       <div className="plug-content-wrap">
         <div style={{ display: "flex" }}>
           <Input
-            value={appName}
+            value={path}
             onChange={this.searchOnchange}
-            placeholder={getIntlContent("SHENYU.META.INPUTAPPNAME")}
+            placeholder={getIntlContent("SHENYU.META.PATH")}

Review Comment:
   when i use "INPUTPATH", the placeholder has not default value. 
   ![image](https://user-images.githubusercontent.com/12622645/176874581-12091829-7397-46da-bdb3-4ba9be242a12.png)
   
   and i use "PATH",the placeholder has default value. 
   
   ![image](https://user-images.githubusercontent.com/12622645/176874847-24b93c42-0bb7-4390-b3e3-54bde520c25c.png)
   
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org