You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "codecov-io (GitHub)" <gi...@apache.org> on 2019/01/02 07:33:24 UTC
[GitHub] [incubator-dubbo] codecov-io commented on issue #3108: Replace hard coded dubbo-config-api values and small code optimization

# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3108?src=pr&el=h1) Report
> Merging [#3108](https://codecov.io/gh/apache/incubator-dubbo/pull/3108?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/d41408e23f9f0b26f19a7c3e8f8bcfb5e9aaed1f?src=pr&el=desc) will **increase** coverage by `0.03%`.
> The diff coverage is `67.77%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dubbo/pull/3108/graphs/tree.svg?width=650&token=VnEIkiFQT0&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dubbo/pull/3108?src=pr&el=tree)

```diff
@@             Coverage Diff              @@
##             master    #3108      +/-   ##
============================================
+ Coverage     63.52%   63.56%   +0.03%     
  Complexity       75       75              
============================================
  Files           652      653       +1     
  Lines         28183    28189       +6     
  Branches       4791     4784       -7     
============================================
+ Hits          17902    17917      +15     
+ Misses         8023     8014       -9     
  Partials       2258     2258
```


| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/3108?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...c/main/java/org/apache/dubbo/common/Constants.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3108/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vQ29uc3RhbnRzLmphdmE=) | `92.85% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [.../org/apache/dubbo/common/EnvironmentConstants.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3108/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vRW52aXJvbm1lbnRDb25zdGFudHMuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (?)` | |
| [...va/org/apache/dubbo/config/ConfigCenterConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3108/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9Db25maWdDZW50ZXJDb25maWcuamF2YQ==) | `31.03% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...org/apache/dubbo/config/AbstractServiceConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3108/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9BYnN0cmFjdFNlcnZpY2VDb25maWcuamF2YQ==) | `95.77% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...ava/org/apache/dubbo/config/ApplicationConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3108/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9BcHBsaWNhdGlvbkNvbmZpZy5qYXZh) | `84.33% <100%> (+1.62%)` | `0 <0> (ø)` | :arrow_down: |
| [...ain/java/org/apache/dubbo/config/ModuleConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3108/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9Nb2R1bGVDb25maWcuamF2YQ==) | `86.84% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...ain/java/org/apache/dubbo/config/MethodConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3108/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9NZXRob2RDb25maWcuamF2YQ==) | `100% <100%> (+1.72%)` | `0 <0> (ø)` | :arrow_down: |
| [...n/java/org/apache/dubbo/config/ProviderConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3108/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9Qcm92aWRlckNvbmZpZy5qYXZh) | `95.69% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...n/java/org/apache/dubbo/config/RegistryConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3108/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9SZWdpc3RyeUNvbmZpZy5qYXZh) | `84.21% <40%> (+1.85%)` | `0 <0> (ø)` | :arrow_down: |
| [...n/java/org/apache/dubbo/config/ProtocolConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3108/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9Qcm90b2NvbENvbmZpZy5qYXZh) | `75.93% <42.85%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| ... and [18 more](https://codecov.io/gh/apache/incubator-dubbo/pull/3108/diff?src=pr&el=tree-more) | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3108?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3108?src=pr&el=footer). Last update [d41408e...1338133](https://codecov.io/gh/apache/incubator-dubbo/pull/3108?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3108 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org