You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/10/01 05:16:40 UTC
[GitHub] [beam] yichuan66 opened a new pull request #12987: Yichuan66/fix typo
yichuan66 opened a new pull request #12987:
URL: https://github.com/apache/beam/pull/12987
Fixed a small typo. Getting familiar with Beam contribution routine.
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
Post-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
Lang | SDK | Dataflow | Flink | Samza | Spark | Twister2
--- | --- | --- | --- | --- | --- | ---
Go | [](https://ci-beam.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/) | ---
Java | [](https://ci-beam.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Java11/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Java11/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Twister2/lastCompletedBuild/)
Python | [](https://ci-beam.apache.org/job/beam_PostCommit_Python36/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python37/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python38/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow_V2/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Python_PVR_Flink_Cron/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python_VR_Flink/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_Python_VR_Spark/lastCompletedBuild/) | ---
XLang | [](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Direct/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Flink/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Spark/lastCompletedBuild/) | ---
Pre-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
--- |Java | Python | Go | Website | Whitespace | Typescript
--- | --- | --- | --- | --- | --- | ---
Non-portable | [](https://ci-beam.apache.org/job/beam_PreCommit_Java_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PreCommit_PythonLint_Cron/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PreCommit_PythonDocker_Cron/lastCompletedBuild/) <br>[](https://ci-beam.apache.org/job/beam_PreCommit_PythonDocs_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Go_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Website_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Whitespace_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Typescript_Cron/lastCompletedBuild/)
Portable | --- | [](https://ci-beam.apache.org/job/beam_PreCommit_Portable_Python_Cron/lastCompletedBuild/) | --- | --- | --- | ---
See [.test-infra/jenkins/README](https://github.com/apache/beam/blob/master/.test-infra/jenkins/README.md) for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] yichuan66 commented on pull request #12987: Yichuan66/fix typo
Posted by GitBox <gi...@apache.org>.
yichuan66 commented on pull request #12987:
URL: https://github.com/apache/beam/pull/12987#issuecomment-702344005
> Thanks! Happy to review PRs or help you find an appropriate reviewer :)
Thanks Brian! I had a question on how I should learn the Go SDK code efficiently because I want to become productive as soon as I can. I'm currently reading the Go SDK code/design docs by myself, and got questions here and there. It will be greatly appreciated if I could find someone familiar with Go SDK for discussion. I know everyone's time is valuable, so I don't expect real-time response, and I will keep my questions/discussions short and concise. Is there someone you'd like to suggest? Should I communicate via Slack or email? Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] yichuan66 edited a comment on pull request #12987: Yichuan66/fix typo
Posted by GitBox <gi...@apache.org>.
yichuan66 edited a comment on pull request #12987:
URL: https://github.com/apache/beam/pull/12987#issuecomment-702344005
> Thanks! Happy to review PRs or help you find an appropriate reviewer :)
Thanks Brian! I had a question on how I should learn the Go SDK code efficiently because I want to become productive as soon as I can. I'm currently reading the Go SDK code/design docs by myself, and got questions here and there. It will be greatly appreciated if I could find someone familiar with Go SDK for discussion. I know everyone's time is valuable, so I don't expect real-time response (I can compile a list of questions and communicate once a week), and I will keep my questions/discussions short and concise. Is there someone you'd like to suggest? Should I communicate via Slack or email? Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] yichuan66 edited a comment on pull request #12987: Yichuan66/fix typo
Posted by GitBox <gi...@apache.org>.
yichuan66 edited a comment on pull request #12987:
URL: https://github.com/apache/beam/pull/12987#issuecomment-701893996
@TheNeuralBit I'm new and not sure who to look. Can you please take a look? Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] yichuan66 commented on pull request #12987: Yichuan66/fix typo
Posted by GitBox <gi...@apache.org>.
yichuan66 commented on pull request #12987:
URL: https://github.com/apache/beam/pull/12987#issuecomment-701893996
@TheNeuralBit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] yichuan66 edited a comment on pull request #12987: Yichuan66/fix typo
Posted by GitBox <gi...@apache.org>.
yichuan66 edited a comment on pull request #12987:
URL: https://github.com/apache/beam/pull/12987#issuecomment-701893996
@TheNeuralBit I'm new and not sure who to look for. Can you please take a look? Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] TheNeuralBit commented on pull request #12987: Yichuan66/fix typo
Posted by GitBox <gi...@apache.org>.
TheNeuralBit commented on pull request #12987:
URL: https://github.com/apache/beam/pull/12987#issuecomment-702816651
(CC: @lostluck and @youngoli, the primary contributors to the Go SDK)
Sometimes Beam contributors are hanging out in the-asf.slack.com, but I'd say your best bet would be to reach out on the dev mailing list (dev@beam.apache.org) with your questions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] yichuan66 commented on pull request #12987: Yichuan66/fix typo
Posted by GitBox <gi...@apache.org>.
yichuan66 commented on pull request #12987:
URL: https://github.com/apache/beam/pull/12987#issuecomment-702817430
> (CC: @lostluck and @youngoli, the primary contributors to the Go SDK)
>
> Sometimes Beam contributors are hanging out in the-asf.slack.com, but I'd say your best bet would be to reach out on the dev mailing list ([dev@beam.apache.org](mailto:dev@beam.apache.org)) with your questions.
Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] TheNeuralBit merged pull request #12987: Yichuan66/fix typo
Posted by GitBox <gi...@apache.org>.
TheNeuralBit merged pull request #12987:
URL: https://github.com/apache/beam/pull/12987
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lostluck edited a comment on pull request #12987: Yichuan66/fix typo
Posted by GitBox <gi...@apache.org>.
lostluck edited a comment on pull request #12987:
URL: https://github.com/apache/beam/pull/12987#issuecomment-702818753
I definitely recommend emailing the Dev list with your questions so I can answer them there :). I don't scale enough for 1:1 training, though I do occasionally answer things on the beam-go Apache Slack channel.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] TheNeuralBit commented on pull request #12987: Yichuan66/fix typo
Posted by GitBox <gi...@apache.org>.
TheNeuralBit commented on pull request #12987:
URL: https://github.com/apache/beam/pull/12987#issuecomment-702818106
Note that messages sent to dev@beam from anyone who isn't subscribed may be a little bit delayed as they get moderated to filter out spam.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lostluck commented on pull request #12987: Yichuan66/fix typo
Posted by GitBox <gi...@apache.org>.
lostluck commented on pull request #12987:
URL: https://github.com/apache/beam/pull/12987#issuecomment-702818753
I definitely recommend emailing the Dev list with your questions so I can answer them there :). I don't scale enough for 1:1 training, though I do occasionally answer things on the beam-go channel.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org