[GitHub] [superset] rusackas commented on pull request #17976: feat(Select): [cosmetic] support allowTopOptions for select component

[GitBox <gi...@apache.org>]

rusackas commented on pull request #17976:
URL: https://github.com/apache/superset/pull/17976#issuecomment-1017094607


   Thanks for the PR @stephenLYZ. It does solve the issue reported. However, in the end, I agree with the general consensus of the thread: consistency is king. While the use case cited in the bug report does NOT require pagination, and I can see the reasoning for keeping the selected value in-place in that use case, I still tend to agree that we should not have different behaviors of Select components in the application. If we change our minds later, we can re-open this PR and rekindle this project (also adding it to Storybook if we do). In the meantime, I think we can close this. I think we can also close the original issue, but I'll take that up on that thread separately.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org