You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/06/05 23:15:40 UTC
Review Request 67464: Fixed `python3/mesos-style.py`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67464/
-----------------------------------------------------------
Review request for mesos and Armand Grillet.
Repository: mesos
Description
-------
The `cpplint.py` file was made to be single-source compatible with
both Python 2 and Python 3, but `mesos-style.py` was erroneously
changed to look for a copy of it under `support/python3`.
Diffs
-----
support/python3/mesos-style.py 6f9b9d4611c6501f8a2dbda4bfe08cffaadc6d86
Diff: https://reviews.apache.org/r/67464/diff/1/
Testing
-------
Thanks,
Andrew Schwartzmeyer
Re: Review Request 67464: Fixed `python3/mesos-style.py`.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67464/#review204354
-----------------------------------------------------------
PASS: Mesos patch 67464 was successfully built and tested.
Reviews applied: `['67464']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67464
- Mesos Reviewbot Windows
On June 5, 2018, 4:15 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67464/
> -----------------------------------------------------------
>
> (Updated June 5, 2018, 4:15 p.m.)
>
>
> Review request for mesos and Armand Grillet.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The `cpplint.py` file was made to be single-source compatible with
> both Python 2 and Python 3, but `mesos-style.py` was erroneously
> changed to look for a copy of it under `support/python3`.
>
>
> Diffs
> -----
>
> support/python3/mesos-style.py 6f9b9d4611c6501f8a2dbda4bfe08cffaadc6d86
>
>
> Diff: https://reviews.apache.org/r/67464/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 67464: Fixed `python3/mesos-style.py`.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67464/#review204361
-----------------------------------------------------------
Patch looks great!
Reviews applied: [67464]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On June 5, 2018, 11:15 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67464/
> -----------------------------------------------------------
>
> (Updated June 5, 2018, 11:15 p.m.)
>
>
> Review request for mesos and Armand Grillet.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The `cpplint.py` file was made to be single-source compatible with
> both Python 2 and Python 3, but `mesos-style.py` was erroneously
> changed to look for a copy of it under `support/python3`.
>
>
> Diffs
> -----
>
> support/python3/mesos-style.py 6f9b9d4611c6501f8a2dbda4bfe08cffaadc6d86
>
>
> Diff: https://reviews.apache.org/r/67464/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 67464: Fixed `python3/mesos-style.py`.
Posted by Armand Grillet <ag...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67464/#review204403
-----------------------------------------------------------
Ship it!
Ship It!
- Armand Grillet
On June 5, 2018, 11:15 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67464/
> -----------------------------------------------------------
>
> (Updated June 5, 2018, 11:15 p.m.)
>
>
> Review request for mesos and Armand Grillet.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The `cpplint.py` file was made to be single-source compatible with
> both Python 2 and Python 3, but `mesos-style.py` was erroneously
> changed to look for a copy of it under `support/python3`.
>
>
> Diffs
> -----
>
> support/python3/mesos-style.py 6f9b9d4611c6501f8a2dbda4bfe08cffaadc6d86
>
>
> Diff: https://reviews.apache.org/r/67464/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>