You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by "Tonitzpp (via GitHub)" <gi...@apache.org> on 2025/11/27 10:41:49 UTC

[PR] Show volume UUIDs in the backup details page [cloudstack]

Tonitzpp opened a new pull request, #12156:
URL: https://github.com/apache/cloudstack/pull/12156

   ### Description
   
   When accessing the details of a backup in the UI, all the volumes that are part of the backup are listed. However, the listing displays a UUID that does not identify the volume, but the backup file in the storage, which can cause confusion for users. This PR changed the listing details to display the UUID of the volumes.
   
   ### Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [X] Cleanup (Code refactoring and cleanup, that may add test cases)
   - [ ] Build/CI
   - [ ] Test (unit or integration test code)
   
   ### Feature/Enhancement Scale or Bug Severity
   
   #### Feature/Enhancement Scale
   
   - [ ] Major
   - [X] Minor
   
   ### Screenshots (if appropriate):
   
   <details> <summary> Backup volumes before changes: </summary>
   
   Volume path:
   <img width="955" height="590" alt="image" src="https://github.com/user-attachments/assets/884eb09f-8b0a-4904-ac5a-aeaf350f69ac" />
   
   Backup volume:
   <img width="963" height="159" alt="image" src="https://github.com/user-attachments/assets/b2d919a1-f5da-4b3b-b082-b98c85e25ce6" />
   
   </details>
   
   <details> <summary> Backup volumes after changes: </summary>
   
   Volume path:
   <img width="955" height="590" alt="image" src="https://github.com/user-attachments/assets/884eb09f-8b0a-4904-ac5a-aeaf350f69ac" />
   
   Backup volume:
   <img width="963" height="159" alt="image" src="https://github.com/user-attachments/assets/a7ffac40-bb18-440a-b9c6-9b74c89230af" />
   
   </details>
   
   ### How Has This Been Tested?
   
   I created a VM to perform the tests and assigned it a backup offering. After that I created a backup and verified that the volumes UUID had been changed to their respective UUID in the backup details.
   
   #### How did you try to break this feature and the system with this change?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Show volume UUIDs in the backup details page [cloudstack]

Posted by "Tonitzpp (via GitHub)" <gi...@apache.org>.
Tonitzpp commented on PR #12156:
URL: https://github.com/apache/cloudstack/pull/12156#issuecomment-3626506281

   @abh1sar  the path displayed in the GUI is not the backup file path, but the volume path. Furthermore, end users do not have access to the storage to "check the files"; thus, this information is not very valuable to them. On the other hand, displaying the volume UUID is much more useful, as it facilitates API usage.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Show volume UUIDs in the backup details page [cloudstack]

Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #12156:
URL: https://github.com/apache/cloudstack/pull/12156#issuecomment-3626850186

   this change should not cause regressions in GHA


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Show volume UUIDs in the backup details page [cloudstack]

Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #12156:
URL: https://github.com/apache/cloudstack/pull/12156#issuecomment-3626850736

   retrying


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Show volume UUIDs in the backup details page [cloudstack]

Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland merged PR #12156:
URL: https://github.com/apache/cloudstack/pull/12156


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Show volume UUIDs in the backup details page [cloudstack]

Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #12156:
URL: https://github.com/apache/cloudstack/pull/12156#issuecomment-3586240815

   ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/12156?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 3.58%. Comparing base ([`a50de02`](https://app.codecov.io/gh/apache/cloudstack/commit/a50de029bf1d22c2a9ef0de8591f61de0f350f92?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`861028e`](https://app.codecov.io/gh/apache/cloudstack/commit/861028e9f8fa113afee05f6ce2a15af43f53de5c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 37 commits behind head on main.
   > :exclamation:  There is a different number of reports uploaded between BASE (a50de02) and HEAD (861028e). Click for more details.
   > 
   > <details><summary>HEAD has 1 upload less than BASE</summary>
   >
   >| Flag | BASE (a50de02) | HEAD (861028e) |
   >|------|------|------|
   >|unittests|1|0|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@              Coverage Diff              @@
   ##               main   #12156       +/-   ##
   =============================================
   - Coverage     17.56%    3.58%   -13.98%     
   =============================================
     Files          5909      445     -5464     
     Lines        529059    37535   -491524     
     Branches      64617     6903    -57714     
   =============================================
   - Hits          92919     1347    -91572     
   + Misses       425687    36024   -389663     
   + Partials      10453      164    -10289     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/12156/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/12156/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `3.58% <ø> (+<0.01%)` | :arrow_up: |
   | [unittests](https://app.codecov.io/gh/apache/cloudstack/pull/12156/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   </details>
   
   [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/12156?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Show volume UUIDs in the backup details page [cloudstack]

Posted by "bernardodemarco (via GitHub)" <gi...@apache.org>.
bernardodemarco commented on code in PR #12156:
URL: https://github.com/apache/cloudstack/pull/12156#discussion_r2581709570


##########
ui/src/components/view/DetailsTab.vue:
##########
@@ -64,7 +64,7 @@
           </div>
           <div v-else-if="$route.meta.name === 'backup' && item === 'volumes'">
             <div v-for="(volume, idx) in JSON.parse(dataResource[item])" :key="idx">
-              <router-link v-if="!dataResource['vmbackupofferingremoved']" :to="{ path: '/volume/' + volume.uuid }">{{ volume.type }} - {{ volume.path }}</router-link>
+              <router-link v-if="!dataResource['vmbackupofferingremoved']" :to="{ path: '/volume/' + volume.uuid }">{{ volume.type }} - {{ volume.uuid }}</router-link>
               <span v-else>{{ volume.type }} - {{ volume.path }}</span> ({{ parseFloat(volume.size / (1024.0 * 1024.0 * 1024.0)).toFixed(1) }} GB)

Review Comment:
   @Tonitzpp, what happens when the workflow reaches the `v-else` statement (line 68)? Should `volume.path` be displayed then?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Show volume UUIDs in the backup details page [cloudstack]

Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #12156:
URL: https://github.com/apache/cloudstack/pull/12156#discussion_r2569002786


##########
ui/src/components/view/DetailsTab.vue:
##########
@@ -64,7 +64,7 @@
           </div>
           <div v-else-if="$route.meta.name === 'backup' && item === 'volumes'">
             <div v-for="(volume, idx) in JSON.parse(dataResource[item])" :key="idx">
-              <router-link v-if="!dataResource['vmbackupofferingremoved']" :to="{ path: '/volume/' + volume.uuid }">{{ volume.type }} - {{ volume.path }}</router-link>
+              <router-link v-if="!dataResource['vmbackupofferingremoved']" :to="{ path: '/volume/' + volume.uuid }">{{ volume.type }} - {{ volume.uuid }}</router-link>
               <span v-else>{{ volume.type }} - {{ volume.path }}</span> ({{ parseFloat(volume.size / (1024.0 * 1024.0 * 1024.0)).toFixed(1) }} GB)

Review Comment:
   The fallback case on line 68 still displays `volume.path` instead of `volume.uuid`, which is inconsistent with the change on line 67. For consistency with the PR's goal of showing volume UUIDs instead of backup file storage UUIDs, this should also be changed to `volume.uuid`.
   
   ```suggestion
   <span v-else>{{ volume.type }} - {{ volume.uuid }}</span> ({{ parseFloat(volume.size / (1024.0 * 1024.0 * 1024.0)).toFixed(1) }} GB)
   ```
   ```suggestion
                 <span v-else>{{ volume.type }} - {{ volume.uuid }}</span> ({{ parseFloat(volume.size / (1024.0 * 1024.0 * 1024.0)).toFixed(1) }} GB)
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Show volume UUIDs in the backup details page [cloudstack]

Posted by "abh1sar (via GitHub)" <gi...@apache.org>.
abh1sar commented on PR #12156:
URL: https://github.com/apache/cloudstack/pull/12156#issuecomment-3596492169

   IMO simply replacing path with uuid might cause more confusion for people who are used to it.
   And displaying just uuid is not useful for someone who wants to look at the backup file on storage. One can still go to the volume and get the uuid by clicking on the volume in backup details.
   
   If the confusion is about what the string represents, can we prefix it with "path: "


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Show volume UUIDs in the backup details page [cloudstack]

Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #12156:
URL: https://github.com/apache/cloudstack/pull/12156#issuecomment-3585186852

   Congratulations on your first Pull Request and welcome to the Apache CloudStack community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md)
   Here are some useful points:
   - In case of a new feature add useful documentation (raise doc PR at https://github.com/apache/cloudstack-documentation)
   - Be patient and persistent. It might take some time to get a review or get the final approval from the committers.
   - Pay attention to the quality of your code, ensure tests are passing and your PR doesn't have conflicts.
   - Please follow [ASF Code of Conduct](https://github.com/apache/.github/blob/main/.github/CODE_OF_CONDUCT.md) for all communication including (but not limited to) comments on Pull Requests, Issues, Mailing list and Slack.
   - Be sure to read the [CloudStack Coding Conventions](https://cwiki.apache.org/confluence/display/CLOUDSTACK/Coding+conventions).
   Apache CloudStack is a community-driven project and together we are making it better 🚀.
   In case of doubts contact the developers at:
   Mailing List: dev@cloudstack.apache.org (https://cloudstack.apache.org/mailing-lists.html)
   Slack: https://apachecloudstack.slack.com/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Show volume UUIDs in the backup details page [cloudstack]

Posted by "Tonitzpp (via GitHub)" <gi...@apache.org>.
Tonitzpp commented on code in PR #12156:
URL: https://github.com/apache/cloudstack/pull/12156#discussion_r2602387223


##########
ui/src/components/view/DetailsTab.vue:
##########
@@ -64,7 +64,7 @@
           </div>
           <div v-else-if="$route.meta.name === 'backup' && item === 'volumes'">
             <div v-for="(volume, idx) in JSON.parse(dataResource[item])" :key="idx">
-              <router-link v-if="!dataResource['vmbackupofferingremoved']" :to="{ path: '/volume/' + volume.uuid }">{{ volume.type }} - {{ volume.path }}</router-link>
+              <router-link v-if="!dataResource['vmbackupofferingremoved']" :to="{ path: '/volume/' + volume.uuid }">{{ volume.type }} - {{ volume.uuid }}</router-link>
               <span v-else>{{ volume.type }} - {{ volume.path }}</span> ({{ parseFloat(volume.size / (1024.0 * 1024.0 * 1024.0)).toFixed(1) }} GB)

Review Comment:
   When the workflow hits the `v-else`, the `<router-link>` is not rendered. Instead a plain <`span`> is shown with `volume.type` -` volume.uuid`. The correct  to display it is not `volume.path`, but `volume.uuid`; this correction has already been made.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Show volume UUIDs in the backup details page [cloudstack]

Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland closed pull request #12156: Show volume UUIDs in the backup details page
URL: https://github.com/apache/cloudstack/pull/12156


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org