You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/04/14 14:50:29 UTC
[GitHub] [airflow] dimberman opened a new pull request #8299: Clarify docs
for on delete_worker_pods_on_success
dimberman opened a new pull request #8299: Clarify docs for on delete_worker_pods_on_success
URL: https://github.com/apache/airflow/pull/8299
This PR adds a description of how `delete_worker_pods_on_success`
interacts with `delete_worker_pods`
---
Make sure to mark the boxes below before creating PR: [x]
- [ ] Description above provides context of the change
- [ ] Unit tests coverage for changes (not needed for documentation changes)
- [ ] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [ ] Relevant documentation is updated including usage instructions.
- [ ] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] kaxil commented on a change in pull request #8299:
Clarify docs for on delete_worker_pods_on_success
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #8299: Clarify docs for on delete_worker_pods_on_success
URL: https://github.com/apache/airflow/pull/8299#discussion_r408429552
##########
File path: airflow/config_templates/default_airflow.cfg
##########
@@ -815,7 +815,9 @@ worker_container_image_pull_policy = IfNotPresent
# If True, all worker pods will be deleted upon termination
delete_worker_pods = True
-# If True (default), worker pods will be deleted only on task success
+# If True (default), worker pods will be deleted only on task success.
+# Note that this feature overrides `delete_worker_pods`, so failed pods
Review comment:
```suggestion
# Note that this feature overrides ``delete_worker_pods``, so failed pods
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] dimberman closed pull request #8299: Clarify docs for on
delete_worker_pods_on_success
Posted by GitBox <gi...@apache.org>.
dimberman closed pull request #8299: Clarify docs for on delete_worker_pods_on_success
URL: https://github.com/apache/airflow/pull/8299
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] kaxil commented on a change in pull request #8299:
Clarify docs for on delete_worker_pods_on_success
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #8299: Clarify docs for on delete_worker_pods_on_success
URL: https://github.com/apache/airflow/pull/8299#discussion_r408429470
##########
File path: airflow/config_templates/config.yml
##########
@@ -1754,7 +1754,9 @@
default: "True"
- name: delete_worker_pods_on_success
description: |
- If True (default), worker pods will be deleted only on task success
+ If True (default), worker pods will be deleted only on task success.
+ Note that this feature overrides `delete_worker_pods`, so failed pods
Review comment:
```suggestion
Note that this feature overrides ``delete_worker_pods``, so failed pods
```
As it will be rendered in an RST
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services