You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by GitBox <gi...@apache.org> on 2022/07/13 13:46:48 UTC

[GitHub] [incubator-devlake] likyh commented on a diff in pull request #2492: refactor: rename connection.RateLimit to connection.RateLimitPerHour

likyh commented on code in PR #2492:
URL: https://github.com/apache/incubator-devlake/pull/2492#discussion_r920098973


##########
plugins/feishu/models/migrationscripts/archived/connection.go:
##########
@@ -23,12 +23,12 @@ import (
 
 type FeishuConnection struct {
 	commonArchived.Model
-	Name      string `gorm:"type:varchar(100);uniqueIndex" json:"name" validate:"required"`
-	Endpoint  string `mapstructure:"endpoint" env:"GITHUB_ENDPOINT" validate:"required"`
-	Proxy     string `mapstructure:"proxy" env:"GITHUB_PROXY"`
-	RateLimit int    `comment:"api request rate limit per hour"`
-	AppId     string `mapstructure:"app_id" validate:"required" json:"app_id"`
-	SecretKey string `mapstructure:"secret_key" validate:"required" json:"secret_key" encrypt:"yes"`
+	Name             string `gorm:"type:varchar(100);uniqueIndex" json:"name" validate:"required"`
+	Endpoint         string `mapstructure:"endpoint" env:"GITHUB_ENDPOINT" validate:"required"`
+	Proxy            string `mapstructure:"proxy" env:"GITHUB_PROXY"`
+	RateLimitPerHour int    `comment:"api request rate limit per hour"`

Review Comment:
   No, you can not change the archived file. It will break existing magrations.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org