[GitHub] [spark] HyukjinKwon commented on a diff in pull request #38406: [SPARK-40926][CONNECT] Refactor server side tests to only use DataFrame API

[GitBox <gi...@apache.org>]

HyukjinKwon commented on code in PR #38406:
URL: https://github.com/apache/spark/pull/38406#discussion_r1006310003


##########
connector/connect/src/test/scala/org/apache/spark/sql/connect/planner/SparkConnectProtoSuite.scala:
##########
@@ -215,4 +180,16 @@ class SparkConnectProtoSuite extends PlanTest with SparkConnectPlanTest {
     }
     proto.Relation.newBuilder().setLocalRelation(localRelationBuilder.build()).build()
   }
+
+  private def analyzePlan(plan: LogicalPlan): LogicalPlan = {
+    val connectAnalyzed = analysis.SimpleAnalyzer.execute(plan)
+    analysis.SimpleAnalyzer.checkAnalysis(connectAnalyzed)
+    EliminateSubqueryAliases(connectAnalyzed)

Review Comment:
   Why do we need to do this? Would be great to add a comment here to explain.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org