You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Jared Stewart <js...@pivotal.io> on 2017/08/10 17:43:11 UTC

Review Request 61563: GEODE-3383: Refactor deploy tests

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61563/
-----------------------------------------------------------

Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and Patrick Rhomberg.


Repository: geode


Description
-------

GEODE-3383: Refactor deploy tests

- Refactor DeployedJarJUnitTest
- Move several tests into more appropriate locations


Diffs
-----

  geode-core/src/test/java/org/apache/geode/internal/ClassPathLoaderIntegrationTest.java 34d8a2318422edbb3bbdc04920a41693f8d3fe69 
  geode-core/src/test/java/org/apache/geode/internal/DeployedJarJUnitTest.java 178dbae2eaada0cc054502fdf4b6d2ff102b4ed6 
  geode-core/src/test/java/org/apache/geode/internal/JarDeployerDeadlockTest.java PRE-CREATION 
  geode-core/src/test/java/org/apache/geode/management/DeployJarTestSuite.java 6dfab66926c7b246bf839632b293330959f1d728 
  geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/DeployCommandsDUnitTest.java 89148d7752ae1f69e25671ffc43101a63cf7dc64 
  geode-web/src/test/java/org/apache/geode/management/internal/cli/commands/CommandOverHttpDUnitTest.java 7753aafbd7dc5ea4288e27f088400163f6739347 


Diff: https://reviews.apache.org/r/61563/diff/1/


Testing
-------


Thanks,

Jared Stewart


Re: Review Request 61563: GEODE-3383: Refactor deploy tests

Posted by Kirk Lund <ki...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61563/#review183006
-----------------------------------------------------------


Ship it!




Ship It!

- Kirk Lund


On Aug. 11, 2017, 9:52 p.m., Jared Stewart wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61563/
> -----------------------------------------------------------
> 
> (Updated Aug. 11, 2017, 9:52 p.m.)
> 
> 
> Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and Patrick Rhomberg.
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> GEODE-3383: Refactor deploy tests
> 
> - Refactor DeployedJarJUnitTest
> - Move several tests into more appropriate locations
> 
> 
> Diffs
> -----
> 
>   geode-core/src/test/java/org/apache/geode/internal/ClassPathLoaderIntegrationTest.java 34d8a2318422edbb3bbdc04920a41693f8d3fe69 
>   geode-core/src/test/java/org/apache/geode/internal/DeployedJarJUnitTest.java 178dbae2eaada0cc054502fdf4b6d2ff102b4ed6 
>   geode-core/src/test/java/org/apache/geode/internal/JarDeployerDeadlockTest.java PRE-CREATION 
>   geode-core/src/test/java/org/apache/geode/management/DeployJarTestSuite.java 6dfab66926c7b246bf839632b293330959f1d728 
>   geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/DeployCommandsDUnitTest.java 89148d7752ae1f69e25671ffc43101a63cf7dc64 
>   geode-web/src/test/java/org/apache/geode/management/internal/cli/commands/CommandOverHttpDUnitTest.java 7753aafbd7dc5ea4288e27f088400163f6739347 
> 
> 
> Diff: https://reviews.apache.org/r/61563/diff/1/
> 
> 
> Testing
> -------
> 
> Precheckin passed
> 
> 
> Thanks,
> 
> Jared Stewart
> 
>


Re: Review Request 61563: GEODE-3383: Refactor deploy tests

Posted by Jared Stewart <js...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61563/
-----------------------------------------------------------

(Updated Aug. 11, 2017, 9:52 p.m.)


Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and Patrick Rhomberg.


Repository: geode


Description
-------

GEODE-3383: Refactor deploy tests

- Refactor DeployedJarJUnitTest
- Move several tests into more appropriate locations


Diffs
-----

  geode-core/src/test/java/org/apache/geode/internal/ClassPathLoaderIntegrationTest.java 34d8a2318422edbb3bbdc04920a41693f8d3fe69 
  geode-core/src/test/java/org/apache/geode/internal/DeployedJarJUnitTest.java 178dbae2eaada0cc054502fdf4b6d2ff102b4ed6 
  geode-core/src/test/java/org/apache/geode/internal/JarDeployerDeadlockTest.java PRE-CREATION 
  geode-core/src/test/java/org/apache/geode/management/DeployJarTestSuite.java 6dfab66926c7b246bf839632b293330959f1d728 
  geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/DeployCommandsDUnitTest.java 89148d7752ae1f69e25671ffc43101a63cf7dc64 
  geode-web/src/test/java/org/apache/geode/management/internal/cli/commands/CommandOverHttpDUnitTest.java 7753aafbd7dc5ea4288e27f088400163f6739347 


Diff: https://reviews.apache.org/r/61563/diff/1/


Testing (updated)
-------

Precheckin passed


Thanks,

Jared Stewart