You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Steve Loughran (JIRA)" <ji...@apache.org> on 2008/07/28 16:43:31 UTC
[jira] Created: (HADOOP-3844) include message of local exception in
Client call failures
include message of local exception in Client call failures
----------------------------------------------------------
Key: HADOOP-3844
URL: https://issues.apache.org/jira/browse/HADOOP-3844
Project: Hadoop Core
Issue Type: Improvement
Components: ipc
Affects Versions: 0.19.0
Reporter: Steve Loughran
Assignee: Steve Loughran
Priority: Minor
When Client fails with a local exception, that exception is retained, but the message is not propagated to the new exception text, which becomes simply "Call failed on local exception"
The forthcoming patch will change such messages to include that of the nested exception, so producing test reports containing useful data such as
java.io.IOException: Call failed on local exception: Connection refused
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-3844) include message of local exception
in Client call failures
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12618758#action_12618758 ]
Hadoop QA commented on HADOOP-3844:
-----------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12387270/hadoop-3844.patch
against trunk revision 681243.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2997/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2997/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2997/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2997/console
This message is automatically generated.
> include message of local exception in Client call failures
> ----------------------------------------------------------
>
> Key: HADOOP-3844
> URL: https://issues.apache.org/jira/browse/HADOOP-3844
> Project: Hadoop Core
> Issue Type: Improvement
> Components: ipc
> Affects Versions: 0.19.0
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Priority: Minor
> Attachments: hadoop-3844.patch, hadoop-3844.patch
>
>
> When Client fails with a local exception, that exception is retained, but the message is not propagated to the new exception text, which becomes simply "Call failed on local exception"
> The forthcoming patch will change such messages to include that of the nested exception, so producing test reports containing useful data such as
> java.io.IOException: Call failed on local exception: Connection refused
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-3844) include message of local exception
in Client call failures
Posted by "Steve Loughran (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12618650#action_12618650 ]
Steve Loughran commented on HADOOP-3844:
----------------------------------------
Incidentally, this is what the message now looks like: "Call to /127.0.0.1:10 failed on local exception: Connection refused"
> include message of local exception in Client call failures
> ----------------------------------------------------------
>
> Key: HADOOP-3844
> URL: https://issues.apache.org/jira/browse/HADOOP-3844
> Project: Hadoop Core
> Issue Type: Improvement
> Components: ipc
> Affects Versions: 0.19.0
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Priority: Minor
> Attachments: hadoop-3844.patch, hadoop-3844.patch
>
>
> When Client fails with a local exception, that exception is retained, but the message is not propagated to the new exception text, which becomes simply "Call failed on local exception"
> The forthcoming patch will change such messages to include that of the nested exception, so producing test reports containing useful data such as
> java.io.IOException: Call failed on local exception: Connection refused
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-3844) include message of local exception
in Client call failures
Posted by "Steve Loughran (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12647615#action_12647615 ]
Steve Loughran commented on HADOOP-3844:
----------------------------------------
I have a test that brings up a task tracker without a job tracker. I expected it to spin in the started and not live state, but instead we arent spinning on connection failure, and this change -mine- is the cause; the connect and socket exceptions are getting better text, but they are being downgraded at the same time.
Propose: connect and socket exceptions are caught and rethrown with new exceptions of the same type that include diagnostics; all other types are passed through unchanged.
Given this change makes cluster startup more brittle, I would propose either reverting this change or waiting for the replacement.
Stack trace
java.io.IOException: Call to localhost/127.0.0.1:8012 failed on local exception: java.net.ConnectException: Connection refused
at org.apache.hadoop.ipc.Client.call(Client.java:699)
at org.apache.hadoop.ipc.RPC$Invoker.invoke(RPC.java:216)
at org.apache.hadoop.mapred.$Proxy7.getProtocolVersion(Unknown Source)
at org.apache.hadoop.ipc.RPC.getProxy(RPC.java:319)
at org.apache.hadoop.ipc.RPC.getProxy(RPC.java:306)
at org.apache.hadoop.ipc.RPC.getProxy(RPC.java:343)
at org.apache.hadoop.ipc.RPC.waitForProxy(RPC.java:288)
at org.apache.hadoop.mapred.TaskTracker.initialize(TaskTracker.java:453)
at org.apache.hadoop.mapred.TaskTracker.innerStart(TaskTracker.java:831)
at org.apache.hadoop.util.Service.start(Service.java:186)
> include message of local exception in Client call failures
> ----------------------------------------------------------
>
> Key: HADOOP-3844
> URL: https://issues.apache.org/jira/browse/HADOOP-3844
> Project: Hadoop Core
> Issue Type: Improvement
> Components: ipc
> Affects Versions: 0.19.0
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Priority: Minor
> Fix For: 0.19.0
>
> Attachments: hadoop-3844.patch, hadoop-3844.patch
>
>
> When Client fails with a local exception, that exception is retained, but the message is not propagated to the new exception text, which becomes simply "Call failed on local exception"
> The forthcoming patch will change such messages to include that of the nested exception, so producing test reports containing useful data such as
> java.io.IOException: Call failed on local exception: Connection refused
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (HADOOP-3844) include message of local exception
in Client call failures
Posted by "Steve Loughran (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3844?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Steve Loughran reopened HADOOP-3844:
------------------------------------
Leads to a regression in task tracker startup
> include message of local exception in Client call failures
> ----------------------------------------------------------
>
> Key: HADOOP-3844
> URL: https://issues.apache.org/jira/browse/HADOOP-3844
> Project: Hadoop Core
> Issue Type: Improvement
> Components: ipc
> Affects Versions: 0.19.0
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Priority: Minor
> Fix For: 0.19.0
>
> Attachments: hadoop-3844.patch, hadoop-3844.patch
>
>
> When Client fails with a local exception, that exception is retained, but the message is not propagated to the new exception text, which becomes simply "Call failed on local exception"
> The forthcoming patch will change such messages to include that of the nested exception, so producing test reports containing useful data such as
> java.io.IOException: Call failed on local exception: Connection refused
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3844) include message of local exception in
Client call failures
Posted by "Steve Loughran (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3844?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Steve Loughran updated HADOOP-3844:
-----------------------------------
Status: Open (was: Patch Available)
cancelling while I add a further enhancement: listing the host/port that is causing the problem.
> include message of local exception in Client call failures
> ----------------------------------------------------------
>
> Key: HADOOP-3844
> URL: https://issues.apache.org/jira/browse/HADOOP-3844
> Project: Hadoop Core
> Issue Type: Improvement
> Components: ipc
> Affects Versions: 0.19.0
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Priority: Minor
> Attachments: hadoop-3844.patch
>
>
> When Client fails with a local exception, that exception is retained, but the message is not propagated to the new exception text, which becomes simply "Call failed on local exception"
> The forthcoming patch will change such messages to include that of the nested exception, so producing test reports containing useful data such as
> java.io.IOException: Call failed on local exception: Connection refused
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3844) include message of local exception in
Client call failures
Posted by "Steve Loughran (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3844?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Steve Loughran updated HADOOP-3844:
-----------------------------------
Status: Patch Available (was: Open)
improved diagnostics on client side failure
> include message of local exception in Client call failures
> ----------------------------------------------------------
>
> Key: HADOOP-3844
> URL: https://issues.apache.org/jira/browse/HADOOP-3844
> Project: Hadoop Core
> Issue Type: Improvement
> Components: ipc
> Affects Versions: 0.19.0
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Priority: Minor
> Attachments: hadoop-3844.patch
>
>
> When Client fails with a local exception, that exception is retained, but the message is not propagated to the new exception text, which becomes simply "Call failed on local exception"
> The forthcoming patch will change such messages to include that of the nested exception, so producing test reports containing useful data such as
> java.io.IOException: Call failed on local exception: Connection refused
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3844) include message of local exception in
Client call failures
Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3844?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Owen O'Malley updated HADOOP-3844:
----------------------------------
Fix Version/s: 0.19.0
> include message of local exception in Client call failures
> ----------------------------------------------------------
>
> Key: HADOOP-3844
> URL: https://issues.apache.org/jira/browse/HADOOP-3844
> Project: Hadoop Core
> Issue Type: Improvement
> Components: ipc
> Affects Versions: 0.19.0
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Priority: Minor
> Fix For: 0.19.0
>
> Attachments: hadoop-3844.patch, hadoop-3844.patch
>
>
> When Client fails with a local exception, that exception is retained, but the message is not propagated to the new exception text, which becomes simply "Call failed on local exception"
> The forthcoming patch will change such messages to include that of the nested exception, so producing test reports containing useful data such as
> java.io.IOException: Call failed on local exception: Connection refused
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-3844) include message of local exception
in Client call failures
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12617493#action_12617493 ]
Hadoop QA commented on HADOOP-3844:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12387032/hadoop-3844.patch
against trunk revision 679930.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no tests are needed for this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2960/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2960/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2960/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2960/console
This message is automatically generated.
> include message of local exception in Client call failures
> ----------------------------------------------------------
>
> Key: HADOOP-3844
> URL: https://issues.apache.org/jira/browse/HADOOP-3844
> Project: Hadoop Core
> Issue Type: Improvement
> Components: ipc
> Affects Versions: 0.19.0
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Priority: Minor
> Attachments: hadoop-3844.patch
>
>
> When Client fails with a local exception, that exception is retained, but the message is not propagated to the new exception text, which becomes simply "Call failed on local exception"
> The forthcoming patch will change such messages to include that of the nested exception, so producing test reports containing useful data such as
> java.io.IOException: Call failed on local exception: Connection refused
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (HADOOP-3844) include message of local exception
in Client call failures
Posted by "Steve Loughran (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3844?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Steve Loughran resolved HADOOP-3844.
------------------------------------
Resolution: Fixed
closing this again as it is not the cause of the problem, it just changes the error text.
> include message of local exception in Client call failures
> ----------------------------------------------------------
>
> Key: HADOOP-3844
> URL: https://issues.apache.org/jira/browse/HADOOP-3844
> Project: Hadoop Core
> Issue Type: Improvement
> Components: ipc
> Affects Versions: 0.19.0
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Priority: Minor
> Fix For: 0.19.0
>
> Attachments: hadoop-3844.patch, hadoop-3844.patch
>
>
> When Client fails with a local exception, that exception is retained, but the message is not propagated to the new exception text, which becomes simply "Call failed on local exception"
> The forthcoming patch will change such messages to include that of the nested exception, so producing test reports containing useful data such as
> java.io.IOException: Call failed on local exception: Connection refused
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-3844) include message of local exception
in Client call failures
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12624714#action_12624714 ]
Hudson commented on HADOOP-3844:
--------------------------------
Integrated in Hadoop-trunk #581 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/581/])
> include message of local exception in Client call failures
> ----------------------------------------------------------
>
> Key: HADOOP-3844
> URL: https://issues.apache.org/jira/browse/HADOOP-3844
> Project: Hadoop Core
> Issue Type: Improvement
> Components: ipc
> Affects Versions: 0.19.0
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Priority: Minor
> Fix For: 0.19.0
>
> Attachments: hadoop-3844.patch, hadoop-3844.patch
>
>
> When Client fails with a local exception, that exception is retained, but the message is not propagated to the new exception text, which becomes simply "Call failed on local exception"
> The forthcoming patch will change such messages to include that of the nested exception, so producing test reports containing useful data such as
> java.io.IOException: Call failed on local exception: Connection refused
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3844) include message of local exception in
Client call failures
Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3844?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Owen O'Malley updated HADOOP-3844:
----------------------------------
Resolution: Fixed
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
I just committed this. Thanks, Steve!
> include message of local exception in Client call failures
> ----------------------------------------------------------
>
> Key: HADOOP-3844
> URL: https://issues.apache.org/jira/browse/HADOOP-3844
> Project: Hadoop Core
> Issue Type: Improvement
> Components: ipc
> Affects Versions: 0.19.0
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Priority: Minor
> Attachments: hadoop-3844.patch, hadoop-3844.patch
>
>
> When Client fails with a local exception, that exception is retained, but the message is not propagated to the new exception text, which becomes simply "Call failed on local exception"
> The forthcoming patch will change such messages to include that of the nested exception, so producing test reports containing useful data such as
> java.io.IOException: Call failed on local exception: Connection refused
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3844) include message of local exception in
Client call failures
Posted by "Steve Loughran (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3844?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Steve Loughran updated HADOOP-3844:
-----------------------------------
Attachment: hadoop-3844.patch
> include message of local exception in Client call failures
> ----------------------------------------------------------
>
> Key: HADOOP-3844
> URL: https://issues.apache.org/jira/browse/HADOOP-3844
> Project: Hadoop Core
> Issue Type: Improvement
> Components: ipc
> Affects Versions: 0.19.0
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Priority: Minor
> Attachments: hadoop-3844.patch, hadoop-3844.patch
>
>
> When Client fails with a local exception, that exception is retained, but the message is not propagated to the new exception text, which becomes simply "Call failed on local exception"
> The forthcoming patch will change such messages to include that of the nested exception, so producing test reports containing useful data such as
> java.io.IOException: Call failed on local exception: Connection refused
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-3844) include message of local exception
in Client call failures
Posted by "Steve Loughran (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12647617#action_12647617 ]
Steve Loughran commented on HADOOP-3844:
----------------------------------------
actually, this patch isnt the root cause, as the exception was already being wrapped. So this bit of code may have been brittle for some time.
> include message of local exception in Client call failures
> ----------------------------------------------------------
>
> Key: HADOOP-3844
> URL: https://issues.apache.org/jira/browse/HADOOP-3844
> Project: Hadoop Core
> Issue Type: Improvement
> Components: ipc
> Affects Versions: 0.19.0
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Priority: Minor
> Fix For: 0.19.0
>
> Attachments: hadoop-3844.patch, hadoop-3844.patch
>
>
> When Client fails with a local exception, that exception is retained, but the message is not propagated to the new exception text, which becomes simply "Call failed on local exception"
> The forthcoming patch will change such messages to include that of the nested exception, so producing test reports containing useful data such as
> java.io.IOException: Call failed on local exception: Connection refused
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3844) include message of local exception in
Client call failures
Posted by "Steve Loughran (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3844?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Steve Loughran updated HADOOP-3844:
-----------------------------------
Status: Patch Available (was: Open)
This patch includes the hostname:port on a failure, and modifies TestIPC to check for both the address and the nested cause in the exception text.
> include message of local exception in Client call failures
> ----------------------------------------------------------
>
> Key: HADOOP-3844
> URL: https://issues.apache.org/jira/browse/HADOOP-3844
> Project: Hadoop Core
> Issue Type: Improvement
> Components: ipc
> Affects Versions: 0.19.0
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Priority: Minor
> Attachments: hadoop-3844.patch, hadoop-3844.patch
>
>
> When Client fails with a local exception, that exception is retained, but the message is not propagated to the new exception text, which becomes simply "Call failed on local exception"
> The forthcoming patch will change such messages to include that of the nested exception, so producing test reports containing useful data such as
> java.io.IOException: Call failed on local exception: Connection refused
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3844) include message of local exception in
Client call failures
Posted by "Steve Loughran (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3844?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Steve Loughran updated HADOOP-3844:
-----------------------------------
Attachment: hadoop-3844.patch
> include message of local exception in Client call failures
> ----------------------------------------------------------
>
> Key: HADOOP-3844
> URL: https://issues.apache.org/jira/browse/HADOOP-3844
> Project: Hadoop Core
> Issue Type: Improvement
> Components: ipc
> Affects Versions: 0.19.0
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Priority: Minor
> Attachments: hadoop-3844.patch
>
>
> When Client fails with a local exception, that exception is retained, but the message is not propagated to the new exception text, which becomes simply "Call failed on local exception"
> The forthcoming patch will change such messages to include that of the nested exception, so producing test reports containing useful data such as
> java.io.IOException: Call failed on local exception: Connection refused
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.