You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Hao Hao (Code Review)" <ge...@cloudera.org> on 2018/09/11 00:59:15 UTC

[kudu-CR] Remove unnecessary friendship 

Hao Hao has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11416


Change subject: Remove unnecessary friendship
......................................................................

Remove unnecessary friendship

This commit removes unnecessary friendship and declaration in client.h.

Change-Id: Ia7c5f35a8b6a6ec2de1d57bbb4f68b53aae4e700
---
M src/kudu/client/client.h
1 file changed, 0 insertions(+), 5 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/16/11416/1
-- 
To view, visit http://gerrit.cloudera.org:8080/11416
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia7c5f35a8b6a6ec2de1d57bbb4f68b53aae4e700
Gerrit-Change-Number: 11416
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao <ha...@cloudera.com>

[kudu-CR] Remove unnecessary friendship

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11416 )

Change subject: Remove unnecessary friendship
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/11416
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia7c5f35a8b6a6ec2de1d57bbb4f68b53aae4e700
Gerrit-Change-Number: 11416
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Tue, 11 Sep 2018 18:00:58 +0000
Gerrit-HasComments: No

[kudu-CR] Remove unnecessary friendship

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11416 )

Change subject: Remove unnecessary friendship
......................................................................

Remove unnecessary friendship

This commit removes unnecessary friendship and declaration in client.h.

Change-Id: Ia7c5f35a8b6a6ec2de1d57bbb4f68b53aae4e700
Reviewed-on: http://gerrit.cloudera.org:8080/11416
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Reviewed-by: Alexey Serbin <as...@cloudera.com>
---
M src/kudu/client/client.h
1 file changed, 0 insertions(+), 5 deletions(-)

Approvals:
  Kudu Jenkins: Verified
  Adar Dembo: Looks good to me, approved
  Alexey Serbin: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/11416
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia7c5f35a8b6a6ec2de1d57bbb4f68b53aae4e700
Gerrit-Change-Number: 11416
Gerrit-PatchSet: 2
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] Remove unnecessary friendship

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11416 )

Change subject: Remove unnecessary friendship
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/11416
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia7c5f35a8b6a6ec2de1d57bbb4f68b53aae4e700
Gerrit-Change-Number: 11416
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Tue, 11 Sep 2018 18:15:37 +0000
Gerrit-HasComments: No