You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Mike Percy (Code Review)" <ge...@cloudera.org> on 2017/05/01 22:52:32 UTC
[kudu-CR] master: Retry background tasks even if TS UUID not registered
Mike Percy has posted comments on this change.
Change subject: master: Retry background tasks even if TS UUID not registered
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/6534/1//COMMIT_MSG
Commit Message:
PS1, Line 14: This patch causes the task to be retried even if the initial tablet
: server UUID lookup fails.
> I'm not necessarily opposed to this patch, but I don't understand why it's
SendDeleteReplicaRequest() is called as part of CatalogManager::HandleReportedTablet() so it's only guaranteed to be a one-time thing to get a full tablet report that includes this tablet from this tablet server.
http://gerrit.cloudera.org:8080/#/c/6534/1/src/kudu/integration-tests/cluster_itest_util.h
File src/kudu/integration-tests/cluster_itest_util.h:
Line 188:
> Unintended addition?
Done
--
To view, visit http://gerrit.cloudera.org:8080/6534
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3a3de7fe87266f11392fd3bb0c74f19ad803de9d
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Tidy Bot
Gerrit-HasComments: Yes